Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4dafab73-9957-f1df-69fe-3cfa59fb22fb@quicinc.com>
Date:   Fri, 28 Oct 2022 08:08:03 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] PCI: hv: Fix the definition of vector in
 hv_compose_msi_msg()
Content-Language: en-US
To:     <decui@microsoft.com>, <quic_carlv@quicinc.com>,
        <wei.liu@kernel.org>, <kys@microsoft.com>,
        <haiyangz@microsoft.com>, <sthemmin@microsoft.com>,
        <lpieralisi@kernel.org>, <bhelgaas@google.com>,
        <linux-hyperv@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <mikelley@microsoft.com>,
        <robh@kernel.org>, <kw@linux.com>, <helgaas@kernel.org>,
        <alex.williamson@redhat.com>, <boqun.feng@gmail.com>,
        <Boqun.Feng@microsoft.com>
References: <20221027205256.17678-1-decui@microsoft.com>
From:   Jeffrey Hugo <quic_jhugo@quicinc.com>
In-Reply-To: <20221027205256.17678-1-decui@microsoft.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/27/2022 2:52 PM, Dexuan Cui wrote:
> The local variable 'vector' must be u32 rather than u8: see the
> struct hv_msi_desc3.
> 
> 'vector_count' should be u16 rather than u8: see struct hv_msi_desc,
> hv_msi_desc2 and hv_msi_desc3.
> 
> Fixes: a2bad844a67b ("PCI: hv: Fix interrupt mapping for multi-MSI")
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>
> Cc: Carl Vanderlip <quic_carlv@quicinc.com>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>