Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH v2] f2fs: stop discard thread if has fsck tag
Date:   Fri, 28 Oct 2022 22:37:33 +0800
Message-Id: <20221028143733.57322-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nq0s4VcdE4hSD6B2fluDw/uNhg8F6WrFqXmkPrLyjoECTdqydlqupXr1Cdz6?=
 =?us-ascii?Q?oo8w9wYbrxanulpFH5lSOtXG8bKqi6bkqcNTB+60IgLmUz3n858/6ee8pk1k?=
 =?us-ascii?Q?kq8gZIJQ604msFxgT20lp1yo3bEjhH6HLdrVprWL3g4LwfVaRYDsG94Nu9nk?=
 =?us-ascii?Q?mruY2s6JyErSHyoI0IB0DoR7y56rjv/myWa1yxlwg1K3XNw093vsqlmNNOBd?=
 =?us-ascii?Q?rDtXds3ivAG/yTYxRhSlusDqH3iB7piDpYoCgRt1JZKuDOYvOR7nVCRmpGx5?=
 =?us-ascii?Q?5ToyGyMLMOc0w6xqWIz7aAI9we25j5NAO4bGh2f3syqh4W3/E+yaf7EJwXlQ?=
 =?us-ascii?Q?d5xF/PUfzCy2ihYLytshl/dQ/13SCKmxARgV8UmUQANUwe0dK980uJMPSnaU?=
 =?us-ascii?Q?fNhWA91kRlfqjAZVc9uMEW7GThjxifTPgcTZU+EoTohQEYVWdc2V9WarmfS0?=
 =?us-ascii?Q?Mr47+dfkqs2dcjLetC3uQsret4dfbJn1HDPUASYuyTJMLaQF7f+ut0tj1/8M?=
 =?us-ascii?Q?czcv1C2fKP7l6aOBPW9o4nAmxYoR7cQ/IoJU7jUGLTGN+EgL8GFeZ0pQ59UZ?=
 =?us-ascii?Q?hTZY0uKoz2sa6bNn8iICdfI3SxuxBJr8XoeAQU0Ttr37fWouksytocxOZ6m1?=
 =?us-ascii?Q?hgh9Bm/mX8otjYdW5keQBK6bLq3PMkOLwDN3iHmIK7+k6pNY4MEWcJLCp3HZ?=
 =?us-ascii?Q?kG2YhVW6rQ63BQ323vW1orKsdEp6zfGfd71JZ4o6XP5EBEOKIXV3qJVHvt+0?=
 =?us-ascii?Q?WjicrHQfxEgOA+KWY3oqrlGhSEs1OD1COuo7tu8Q8c5RO/3MpsvH2vaASiy4?=
 =?us-ascii?Q?alMP150FS6JOztadL1zuxUNKROz+X8clDV9YX7eZF0H6byYlDaQYeJ5NuKBR?=
 =?us-ascii?Q?VTFz5wvWIu2aOJc23YDUWKXCogQPKiCFuBNQHm9pYShK8ykylmecXNkcXvQy?=
 =?us-ascii?Q?QZaFkqc6NPFt2SlbDuQQ4lEtEKVgLO0eGwefBnQKngzpWt6pKdJwyXLkH0M1?=
 =?us-ascii?Q?cR1vXZOcLf0sOEVtAucZqCj4VQujRSf9BLvYaYEzYGAVFn2DSkmdeMaVbDo5?=
 =?us-ascii?Q?457hcL/ufQD067alrN3fb/SxcJQUwSMvPbh1YsrdctQQLYYtb7NR/Dj0RIlO?=
 =?us-ascii?Q?3HiuOG//8nrJk4YC7uikYYVxtbfw11JMeV4LC/8eaJOT7UougNbcr9QD1DER?=
 =?us-ascii?Q?Xslxk4bKm8NlhDkm9fAgURn/rV2PqfC2+0nHottT2NmxkU4jHPliPz5WOf3r?=
 =?us-ascii?Q?6SzqTQq7MOeyDedLpsHyOX4PGYz5MbOMsfUC+8JJGsKEVPWzAgi5xRvhEyn8?=
 =?us-ascii?Q?T61htmFXfAf2t89delpPI5J2pQ8qFRlpRW3QOOPVPJu9d0D+gOAe+5062qam?=
 =?us-ascii?Q?8+MnnWbIL/VqnWOzBWPh0cChBkyMLFbrYkL2nR0UqxkRfBGKzFQZIn/a6KtQ?=
 =?us-ascii?Q?ecnhvhhMZwmgb18j+DAb1VFKqcQXs/Mb8pBbmI4OXEEop0OTJDQTFSI7tnHz?=
 =?us-ascii?Q?NfkysJdJ3a+L1Fue3cBefdsOThS+d+OuDu9oHCEnEevYZcsljQKr0NPv4kyB?=
 =?us-ascii?Q?YCQqouCcQ3drMJ93oACw5yFqchJdKC2SR3CVbxQT?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68173172-295e-4cbe-36ae-08dab8f1f8a3
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 14:37:42.6464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qUA4Uh/pDdxgc+4W0JJx4OgFRVRppD4AmMtxdXEasp5b4E4Gx6JDp9N+shfQbtEdJKmWDmIwKVc4GhWlLUEAFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5099
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Under the current logic, after the fsck flag is set,
the discard thread will still run periodically.

So stop the discard thread from running to avoid
energy consumption after the fsck flag is set.

Fixes: d618477473eb ("f2fs: stop issue discard if something wrong with f2fs")
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
v2:
- commit msg changes.
 fs/f2fs/segment.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 7786351de429..b3600bcadfc7 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1716,8 +1716,8 @@ static int issue_discard_thread(void *data)
 		if (kthread_should_stop())
 			return 0;
 		if (is_sbi_flag_set(sbi, SBI_NEED_FSCK)) {
-			wait_ms = dpolicy.max_interval;
-			continue;
+			dcc->f2fs_issue_discard = NULL;
+			return 0;
 		}
 		if (!atomic_read(&dcc->discard_cmd_cnt))
 			continue;
-- 
2.25.1