Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b39809c0-69d1-1647-a61f-737e66e021f2@amd.com>
Date:   Fri, 28 Oct 2022 09:46:34 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 3/5] cxl/pci: Discover and cache pointer to RCD dport's
 CXL RAS registers
Content-Language: en-US
To:     Ariel.Sibley@microchip.com, alison.schofield@intel.com,
        vishal.l.verma@intel.com, dave.jiang@intel.com,
        ira.weiny@intel.com, bwidawsk@kernel.org, dan.j.williams@intel.com
Cc:     linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
        bhelgaas@google.com, rafael@kernel.org, lenb@kernel.org,
        Jonathan.Cameron@huawei.com, dave@stgolabs.net, rrichter@amd.com
References: <20221021185615.605233-1-terry.bowman@amd.com>
 <20221021185615.605233-4-terry.bowman@amd.com>
 <MN2PR11MB3645BDC3B58C198BDB9B7B0888329@MN2PR11MB3645.namprd11.prod.outlook.com>
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <MN2PR11MB3645BDC3B58C198BDB9B7B0888329@MN2PR11MB3645.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGVnM3oxdFZXTkgvRDY3cFR6aG8zNVJiWXp0UjAwYlhQclZsRnJPb01RZVNR?=
 =?utf-8?B?N05TcmNaZTBHcFhNZkVyY0o0NCtWRncwSFFkM254dC9DMjNHUFpScVM0UW5V?=
 =?utf-8?B?dE10cC9nbVBzbFBrL2FZSWh2Z3pvWjE4aWtGTTJjYmV0dW9PTTNDR1NSQnlD?=
 =?utf-8?B?M3hhd0t5UFl6N1JvUlRlVWZqMk1YdjhXRjJ1T3JDYjdQWjVkaStRVllFODJ4?=
 =?utf-8?B?RXc4OXcyUnY5Nk5CcU41ek5PUHRNY2VWM2JOTTUxdEtVdTVsMHRJUFhYSXJY?=
 =?utf-8?B?S05tVEduNXRuMlZyekRHeGRrR09UZmE4WVFLcjdVcGJyNmtFRlFSN01JT2Vt?=
 =?utf-8?B?RFBnVVdpT0FIaTRPdE40OURTR1ZyWmsxUHJWT1Q2elhuNWc3OFJwUHJ1TmhH?=
 =?utf-8?B?WnoyMy9xNXN2eHY5RlBJR0pCRXgzME52Y0ZrV0N6cjRCcnlEQUVKZ0NGL3Z6?=
 =?utf-8?B?aDBRWnB1Uk55VHFMdjBYTDFVWWhrMCtQbkJLa2xvTStoZ3MwMUxIOWZDUFNU?=
 =?utf-8?B?Uit1dG5rcHBjaEVCRy9FU2ZsQWFkM0ZhQVhDci9MK0c4TlBmbmZBdG1aVFEr?=
 =?utf-8?B?US9DZjJEaUgzMnF6bDBTRmV5MDdkaDF1a0ZEb2I2WTBtREhsK1FGWFVLZ1Bu?=
 =?utf-8?B?dUZsYjFadDFjb2srR2Z4bzBESXMxdDBTNjJSRE5id3FMSWdsZnJwQlBnb2tG?=
 =?utf-8?B?S0psYjBVU0gyTzcwanUzaEVncG9EVXFiMkRtRGJxc3BNQk9JT0VJbUFtR2xw?=
 =?utf-8?B?aDF3T01vZkxGcHlnRzJnSzJHUEgvejVBUzMrVXhGODZCN2Zsa1JQODJESVhi?=
 =?utf-8?B?bU9XVzUvSVMyUlQ5SHhOYWh3Q0RML3VoL0ZNQXZkRmxpVmc2RU9MSWpPV2ZW?=
 =?utf-8?B?anh0cTBTS3E3Ui84RkxtYzhHRGREOU9JL0JwVFdJTENBQWxIQUZFb0R3WlJq?=
 =?utf-8?B?V3p5SkFWbHZTYmhVWUxpMzhDekZnNHo2S3VmMEgyQzYzaEhiTFB0eUtSZmV0?=
 =?utf-8?B?TmFZaVQrR2JZT1ZkcW5HUjlpYXRpeTJtdzBtd3BZci9zaERjbzROVCs2a0Zv?=
 =?utf-8?B?YUp5QVVQZVFjaVFYMENqWlZxUTJBRmd1aG5MNkl5M0ZPOUhHUWd3cjNoaVJm?=
 =?utf-8?B?aWZQdVpJT2RhWDdYTDNLMGc1NlgrRGhFYjFUUWQzQzVGSlB1Q2ZUZ1c1dFMy?=
 =?utf-8?B?dEJtcThEb1UydHRiTGtJQmdoVFdvKzdYdmptZWQyTXdqc3UwNEV6LzdnUStC?=
 =?utf-8?B?YXBOU2dyTnFtVWRDRHZzUC94ZUlGaXBDc0NwTXcxdnFtd3ExWXJGaXp3VXEv?=
 =?utf-8?B?UTVOcUVtbWhkcVB4Wm45QnFIblNycEJQZUVLNnA5VTBFRVNZd05EbzRMSUNS?=
 =?utf-8?B?dVZMbGdvN3dOdWVBdUlZWEVmR0p0SjFEZDNXWVpYZzhMTDFhdzd3S1d3RTFr?=
 =?utf-8?B?d1JsTUhOVkNDZEVXQWpYb2RySFdmVkFGRWI0dlNLaDBJcmJCVVVOR3RMMUk4?=
 =?utf-8?B?alRNb01JeFN1RGtLSjF0Q0kyamJiTDBmenNEZVllMEpzRmVtYll6WmVpeHpL?=
 =?utf-8?B?c2tiODVDWTMzUU9HTDZVRU5rc0poUEo5VW5RREYraGxBa0Vob0hKcFltLzV6?=
 =?utf-8?B?SXJZQVJLdFdza2FkQllXMEdXYzFJMmQvU0pjd2YybElBejd6NDhRaXpXYlRl?=
 =?utf-8?B?YXo3S0FjQ2tzcnhFVFRQMGF1NE1TNmZpYXF4VW5MR1pRTlZCWmFPYmNuVlNR?=
 =?utf-8?B?VFZ5MGl5a3JBZ3NwWW5pbk1lOUNqdUJ5Z2VBYS9LWU5uWEY5M3FiWU5DU251?=
 =?utf-8?B?dlpJK291MVNvK1RhN1FjWjViRWFOYU9XV1czUzNnWXJMRHo0a1F1SXZvTDZY?=
 =?utf-8?B?eVFyblIxcjkyZ25ORnIzOVRQbldzQURpRUVKZmtxRXpMeFhIbUo0N1ZwZ0I3?=
 =?utf-8?B?Y0NiZEdrTlNCZ0dGdXBJMUtCOVR5b2h0dGZteVpFL2c1dlZVSEw3aEdEaml1?=
 =?utf-8?B?WGpTR2F0RmY1L3o2ZHNKTWlocVo1Ym95ZVdjU2FuTGVBOTdkMENBUGE0aWsy?=
 =?utf-8?B?RnphaGFkam44YWJrbm91R1NwdW9vbUJvcVo4RGRRVWY2RklqeDdnSUdmUVpi?=
 =?utf-8?B?bldYMGIzUWxaOFdSamVBbm5pVzA2Z3pDYkJKalpuRFVqOGVkZHpsbUNxUDdy?=
 =?utf-8?Q?SFuD+oxxSEsmmrsrX8DUheXcNcMx3PfQbko+IKoS8kIM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56cfc57c-f4c7-418d-4054-08dab8f33714
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 14:46:37.1045
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WZBHDekuRHq9P1SSsMWxL3AvDAoQDEhbxc2k6iNa9h7bVF1eF0H1iqKWJ4mv7Titf312CbFoFKvE4nhJSHJGMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4441
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ariel,


On 10/28/22 07:53, Ariel.Sibley@microchip.com wrote:
>> -----Original Message-----
>> From: Terry Bowman <terry.bowman@amd.com>
>> Sent: Friday, October 21, 2022 3:56 PM
>> To: alison.schofield@intel.com; vishal.l.verma@intel.com; dave.jiang@intel.com; ira.weiny@intel.com;
>> bwidawsk@kernel.org; dan.j.williams@intel.com
>> Cc: terry.bowman@amd.com; linux-cxl@vger.kernel.org; linux-kernel@vger.kernel.org; bhelgaas@google.com;
>> rafael@kernel.org; lenb@kernel.org; Jonathan.Cameron@huawei.com; dave@stgolabs.net; rrichter@amd.com
>> Subject: [PATCH 3/5] cxl/pci: Discover and cache pointer to RCD dport's CXL RAS registers
>>
>> CXL RAS information resides in a RAS capability structure located in
>> CXL.cache and CXL.mem registers.[1] The RAS capability provides CXL
>> specific error information that can be helpful in debugging. This
>> information is not currently logged but needs to be logged during PCIe AER
>> error handling.
>>
>> Update the CXL driver to find and cache a pointer to the CXL RAS
>> capability. The RAS registers resides in the downport's component register
>> block. Note:RAS registers are not in the upport. The component registers
>> can be found by first using the RCRB to goto the downport. Next, the
>> downport's 64-bit BAR[0] will point to the component register block.
> 
> I realize this patch is for dport only, but regarding "Note:RAS registers
> are not in the upport.", the upstream port also has RAS registers.
> 

Correct. Thanks for pointing this out.

> Per CXL 3.0 Section 12.2.1.2 RCD Upstream Port-detected Errors:
> "1. If a CXL.cache or CXL.mem logic block in UPZ detects a protocol or link
> error, the block shall log the error in the CXL RAS Capability (see Section
> 8.2.4.16)."