Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 17:36:41 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Deepak R Varma <drv@mailo.com>
Cc:     outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: Use flexible-array for one /
 zero-length arrays
Message-ID: <Y1vo+TjS/mWyT7Zc@kadam>
References: <Y1vNNSSWK1EkcohT@ubunlion>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y1vNNSSWK1EkcohT@ubunlion>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EBUZSanIMSwDpmW8+EWfab2F0MusBThL9qtDuxXrRAWMmcI0aSwoIATy2DGk?=
 =?us-ascii?Q?EqMzX7+cO/kbZdrStuCyAGJGJbqyEYw5RzzAhKLn9/tjbOb9A6LXIObA/+q0?=
 =?us-ascii?Q?RKn5gBK/dRVC2tDCa4epnw9fjSiHtoc7eIxzfgbnFNTR4KExrnHFy0CQndwD?=
 =?us-ascii?Q?2KWhc9nXG96FOQN6If8zI1mYlnoZ+C0SAL0KEMH7qFD2KPHEHX+dGk2QzO62?=
 =?us-ascii?Q?8iaAX8ldPiQSvLZLFwgfldY2JuQY/xOfm6m/SFlN3lfEYzMhPpOJdyecdWm8?=
 =?us-ascii?Q?fjNGlBDkudOIHsIsWX/rFj2wXXx1wmMzAv6weKr4nfy8wKWezWFIsXgejshj?=
 =?us-ascii?Q?6RuqtFF2KeLCMzgjQmThVey7B4JAlSc5VkLJ1CllbKrNCbTe9XGdM78emtrp?=
 =?us-ascii?Q?TEub9O2zCZwOCQ5SqAEV5nl+BRvqYG8rAIM+2AYYGodEBSUdLajFf7A1McZS?=
 =?us-ascii?Q?e+JPJ5yU6yBxcioOYQcb3Xk0vD2+Pku3GgdJPSpMBMCx81Bp8hIDY/MB5MLW?=
 =?us-ascii?Q?OH1yaA+5598OrlBC260nUWyyS2O7EfUQirmOYU2JclLa2UtI9VjHHCHz2VJ7?=
 =?us-ascii?Q?F+EOhK3jqDTwfu2ilGWXl3lxpiThgglEz1y7KbigQqw0m1Q5WDATj8EOTnHT?=
 =?us-ascii?Q?jwxCdPn3Z0WJgl/X852SjvE2rGCEP2Y7pXoOCNMyoXcILhgc8G4RZY0LIF1P?=
 =?us-ascii?Q?KvdN/Q+PJKXD32xvVFHN4F6dKbd+R0BHWZfOUtQ7mRxexgxDZsAHAWV2WiWB?=
 =?us-ascii?Q?xWxXrgo6CGcnNmaeICfPZp8wXLIKBMgstMwlih9CinMO2PP3M9JriHfH75VL?=
 =?us-ascii?Q?cVCIr0VvAqwykx5PPgLVPJhB0bLC04crj90HSOvYXV2LViHBKQBCO+a9wkGJ?=
 =?us-ascii?Q?jKxaVBLR38czivSmj0rBtzlsXNirNfvAt57mVO+VnImjTMgWdWWB8WaxPJK0?=
 =?us-ascii?Q?ckJcQNaHnP4CJ5JEVXec59WDfW8qka5eJ37YF8TtC6rIJkdp9wDam1kbsK6D?=
 =?us-ascii?Q?skL9AiSgcAODvkKf3UWx6TLi5+asNKY3hVO14+noH+cSYPlUY04mpPW3Dl4U?=
 =?us-ascii?Q?6bZ3j5PSuabieHRs31/r1GgmkXNVsr1l3AMREDCtbQxzY94Zhc8txCakxHte?=
 =?us-ascii?Q?cgVnKW3VmMQtaX/SqTR1mFjlo1Ma7YK4OJ5x3jkCk0J+iHhDfExvu6VPoi9T?=
 =?us-ascii?Q?08JDLCkL0KGwsCmVJu7hypRlt9AG90D+CrK+xiUKWEJ7BwtGnRPg1ZcXgChP?=
 =?us-ascii?Q?kB+/NBA+eaxmnaamgBe7ZGXKpPUjv2dcEwtX9KbWLHYlGnWSFATdP2QFEGgy?=
 =?us-ascii?Q?MamcmL8/7J52pC4vGvXoa1a2eIRgDhToy8pdtGs1Pswx/dnmBZ9aDa7zSUE2?=
 =?us-ascii?Q?XLkndlreGEdZLM6DzXG7f4ymvtqTnUKz6efzyjoRz7hoG7UQdNjjmqdVfDW8?=
 =?us-ascii?Q?e4ZjuyuepYqNxueIP9/N02Zm9JPUzJpnr7Nedk94Utmi8s2xDeSSU9DBFqV8?=
 =?us-ascii?Q?lSkqPRFzNsGFyOnV3w75fuZlYRC28XsIioMWtslfuVVsmAlej5RmOv1t7yrJ?=
 =?us-ascii?Q?xbx+hE5kR4TjtiMB78T9/6zEAOyQJU/gLCU0tpRbifOkzrphhmdHQ86eOA0x?=
 =?us-ascii?Q?MA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45d19fbc-f3e9-4cf8-343b-08dab8f1dae7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 14:36:53.0716
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wqaP5eAIQzpzQggkeUvCooWZ/r8GGOYkpc77oKy7zQV3OJ3UbXMMi6UVHcVkwHSxoYaiGm29XwWIBYAbDAF53aUYrzHgw8zrkdNoWBn5ub4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4433
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-28_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 suspectscore=0 mlxscore=0 spamscore=0 phishscore=0 malwarescore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210280090
X-Proofpoint-ORIG-GUID: pHHjLXnquOkTfvBrH4NPD6LY99t5ZJhC
X-Proofpoint-GUID: pHHjLXnquOkTfvBrH4NPD6LY99t5ZJhC
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 28, 2022 at 06:08:13PM +0530, Deepak R Varma wrote:
> Flexible-array member should be used instead of one or zero member to
> meet the need for having a dynamically sized trailing elements in a
> structure. Refer to links [1] and [2] for detailed guidance on this
> suggestion.
> 
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> 
> Issue identified using coccicheck.
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
>  drivers/staging/wlan-ng/p80211mgmt.h  | 8 ++++----
>  drivers/staging/wlan-ng/p80211types.h | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h
> index 1ef30d3f3159..d6fe52de2c8f 100644
> --- a/drivers/staging/wlan-ng/p80211mgmt.h
> +++ b/drivers/staging/wlan-ng/p80211mgmt.h
> @@ -229,14 +229,14 @@ struct wlan_ie {
>  struct wlan_ie_ssid {
>  	u8 eid;
>  	u8 len;
> -	u8 ssid[1];		/* may be zero, ptrs may overlap */
> +	u8 ssid[];		/* may be zero, ptrs may overlap */
>  } __packed;

When you're writing this change look at where struct wlan_ie_ssid is
used.  It's included in five different structs:

	struct wlan_ie_ssid *ssid;

But none of those *ssid pointers are used.  So instead of doing this
just delete the wlan_ie_ssid struct and delete every reference to it.
Send that as a patch by itself and then repeat that process for the next
struct.

regards,
dan carpenter