Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 17:48:11 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Deepak R Varma <drv@mailo.com>
Cc:     outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: Use flexible-array for one /
 zero-length arrays
Message-ID: <Y1vrq5tP3XslI5Go@kadam>
References: <Y1vNNSSWK1EkcohT@ubunlion>
 <Y1vo+TjS/mWyT7Zc@kadam>
 <Y1vq5QdBn1oQUqij@ubunlion>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y1vq5QdBn1oQUqij@ubunlion>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UlpB+mcBqVt/hT4yWvhAhfanNbG7px2iJrN6lqm3aHudhL3BZrB9mzXKa6m2?=
 =?us-ascii?Q?VDm387kYNKtIS4XNqgFoLsCRX9AYKs4hnb3xev03l49zrK6DXjQf46AXlb/0?=
 =?us-ascii?Q?WpqcjNZMQvkXcBxFnEebRvDARf00Pxuh3tmTq1Zf4ldv1yC+uXktVSgD2HCU?=
 =?us-ascii?Q?UvloOmYpYJq/8jfvBNY7v0RaqJ7Dz+kTsRynIPMSweg7eg7nfJ7UpmZds5v7?=
 =?us-ascii?Q?wdZXMkPxs7esiKn6fGHWXNNPiRU4uuUC2RVTNcMCIaRNfxAyBU8gkCeFL+tO?=
 =?us-ascii?Q?zF4KrSvMHRFUO/LLTTfP2HUZTZzgcz2/ZtPZP0mSmk4LtsZZVOKB/2y2eeRe?=
 =?us-ascii?Q?7gHgmI1Lza/6dHo0WddUGMLr+UlPR09Ac8O3joCEjN2+zhdqZuQ/QBThaJsV?=
 =?us-ascii?Q?+7YanB24oyyAgzBv2I8EWqTQ1Ed3sp9NGz64hEgq/18zeVcNneZB5JgcLeYB?=
 =?us-ascii?Q?RRJ0hNMDEgAEye7vsst1HjUIcdQcWYcfUInNMlaxFtDIucUuIr/K9DVEwshs?=
 =?us-ascii?Q?IAOQoh+3MugSzBWptR+nEAWsQg0XrP0wnqYYJcqGyX4xH9eexwa/bVM3rX6t?=
 =?us-ascii?Q?/MZ714f9/B9tCMw2qXUIe5qDzBdQnD4LA2mAN64SFL0VJFj2UD2RaKyzb3wA?=
 =?us-ascii?Q?Mo24Lmns5/rIbOorXmW6rfyd/ogB1n3UvZoeNFJ909KCCho91mG/pxdIKyc2?=
 =?us-ascii?Q?EmjhyBj/XnO2eRNQReKymQ+xaq8h+GO3XYS2EG/ADt2/oN0DbnqYZ1e+3Xqg?=
 =?us-ascii?Q?B+VYOlbw1xkWq3B1EFjzHy7sABzTPini/cAv/4ouNJJv/w5J222Vr41OUZk3?=
 =?us-ascii?Q?EacR/vpTyWW6tbwfxsCnieBwEPNr1AGEjO5viFKDCXcQHCoiQNOX6CTu+RLh?=
 =?us-ascii?Q?JSCMtJW9QxtQhr+yo+0g5lQ1tDRG/eCaxBdzK/dg4Qse7WrPO3f0/MzR6hwN?=
 =?us-ascii?Q?MIQuxbXf8ukXPTzyWmKP46UhJW+44/PLEA/zpFqaN1XoVwgP/Y/eDnhxUZdv?=
 =?us-ascii?Q?zCCVoX3CTXkSVXxR42nQZtPQoPeXa3/Tcw6UwdWVfLZIxKzQCOnkeXDpRGHc?=
 =?us-ascii?Q?j6mv+0tx+/112fCCD83CoWfKH9hIpoO2mYuj+DVKwoqG4bJ+4bq8eL3GR8i3?=
 =?us-ascii?Q?ZYtGB+RlGNvbKhQ/7p+b5UTpQ2Mrenv5sBEWm26c3ZyP30FMESl3zbWNM42t?=
 =?us-ascii?Q?Ct78oM+UzM/nL5AS4rSsnFEXo/njEl1Wp8JTwhJfbd03t5s2njvOB9Xg5gB3?=
 =?us-ascii?Q?ntaqkpEJyuvWj12HQutXM+w+HgM1vUSiBwIJyvTx/PumJwNGljya2P7XY2Kr?=
 =?us-ascii?Q?xMPZkVOVHrGc8WPgizM5iwulwWqGtbX+iO1rkzKPioE4ddtY61D+x09oCmEv?=
 =?us-ascii?Q?lRKpDt43Q0lrv7dfjsHPmWlqGd5AMBCDwptu/NDPUVZv9Q+/T2hRUI9mV9gM?=
 =?us-ascii?Q?Qs0/4zksxNEzszSGhlBHegchTr98xIv3KwGfhFbtOIeB8jXdAViquvCz0EV2?=
 =?us-ascii?Q?NwFCCnqU/JNBCWZfZzoIOlDUy1mA8rmbMbI5nOye5u4yaaELTXa6RpvINqMn?=
 =?us-ascii?Q?xhIIYm24YXr6wfGu1SNrzMx0Wp2Z0c/GED6vsneFrJdy0Jpq6nEUTeSWUhkg?=
 =?us-ascii?Q?5w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e65c496e-2f3e-4f9c-dd70-08dab8f376c8
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 14:48:23.7660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2Iydol7TlHMFKhE/22TVW8LhZ7Yt6M/j0fsaAHnB3R8KrzQmGLkm9ZI0kntFDTCN57/OwlxLIMDlRYI/DI3XdiMj0mw+1l7CYZcePwhDTlo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR10MB6426
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-28_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=734 phishscore=0
 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210280092
X-Proofpoint-GUID: VuUVfJDO9gbvzqIvQQDqEOxuK1_80Pxv
X-Proofpoint-ORIG-GUID: VuUVfJDO9gbvzqIvQQDqEOxuK1_80Pxv
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 28, 2022 at 08:14:53PM +0530, Deepak R Varma wrote:
> Also, there are a few function declarations that I do not think are used in the
> code anywhere.
>    File: drivers/staging/wlan-ng/p80211mgmt.h
>    Line number : 500 through 519
> 
> Can you please comment if it is safe to remove these functions and include this
> clean-up as well in the proposed patch?

Always feel free to delete code that is not used.

(But send the patch tomorrow and as part of a patchset).

regards,
dan carpenter