Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 18:12:22 +0200
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
To:     Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc:     tytso@mit.edu, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, ardb@kernel.org,
        andre.przywara@arm.com
Subject: Re: [PATCH] random: Use arch_get_random*_early() in random_init()
Message-ID: <Y1v/ZkT4nOrKI2Y9@zx2c4.com>
References: <20221028160041.753052-1-jean-philippe@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221028160041.753052-1-jean-philippe@linaro.org>
Precedence: bulk

On Fri, Oct 28, 2022 at 05:00:42PM +0100, Jean-Philippe Brucker wrote:
> While reworking the archrandom handling, commit d349ab99eec7 ("random:
> handle archrandom with multiple longs") switched to the non-early
> archrandom helpers in random_init(), which broke initialization of the
> entropy pool from the arm64 random generator.
> 
> Indeed at that point the arm64 CPU features, which verify that all CPUs
> have compatible capabilities, are not finalized so arch_get_random_seed_longs()
> is unsuccessful. Instead random_init() should use the _early functions,
> which check only the boot CPU on arm64. On other architectures the
> _early functions directly call the normal ones.
> 
> Fixes: d349ab99eec7 ("random: handle archrandom with multiple longs")
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

Thank you for catching this. I'll get this queued up for the next rc.

Jason