Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-a848b9af-2c0e-41fb-9073-97a7d05011c8-1666975323664@3c-app-gmx-bs17>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Jianjun Wang <jianjun.wang@mediatek.com>
Cc:     Frank Wunderlich <linux@fw-web.de>,
        linux-mediatek@lists.infradead.org,
        Ryder Lee <ryder.lee@mediatek.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh@kernel.org>
Subject: Aw: Re: [PATCH v2 1/2] dt-bindings: PCI: mediatek-gen3: add SoC
 based clock config
Content-Type: text/plain; charset=UTF-8
Date:   Fri, 28 Oct 2022 18:42:03 +0200
Importance: normal
Sensitivity: Normal
In-Reply-To: <61c0b62af62ddd0e98378159db2b7d94022c9bf5.camel@mediatek.com>
References: <20221025072837.16591-1-linux@fw-web.de>
 <20221025072837.16591-2-linux@fw-web.de>
 <61c0b62af62ddd0e98378159db2b7d94022c9bf5.camel@mediatek.com>
UI-OutboundReport: notjunk:1;M01:P0:FSSZZCPNFhs=;atXnM023B9CPS6D/dovlpObQPjn
 S5W0jCWtyn2g7hKo9n2ulhpfd3LdPphNES2mhXsdDti9xwz/kjiIHMqlY3FPccDTLlLCJF/Kb
 81tcuHi29/qFnJ0x97hKi8lYejF/q9Wze8ELBKq1BAp0tRjjeu1yiDTH8wVtqbuWNVfgOb21X
 ROKKo/q9T4M/lCJSXEltLiFYm28YCv9UX7QIh4VKn03q/+Vq/D8GYQqjVtgjokr4qMo49wwGw
 tsycnNcYClyM1wr9xaG7Whf9VOY3IDM4F6W4rJeAbLIR1T5iZTg53zDTZKp37klIwra0VaFaB
 H6aQRW490aqoGR63/+qiKxLNCw4hP+HSCvdO4/63Vi/M84m2UeFnznlDQTO+lZidWyPIAEjc0
 qHY6Cdvt5DmQyDQQqYSn4VB70S5DsIAtuttVUmNaH5vxDDxTVl6auZ8DzPqiRkiGcJFAZDA+x
 wgpQThlmFdg7nuMydrLhMdcvyGDala7rnFlbJjHeiGvm1LdFHMZX+V3N1+6mI+q+azXKFJEXp
 43qBxF4N9bCrOPstFmDZPAZT85E2F+hQbfx3c7o7h4NLS9/rM1cyZ4KB/pgSIw7Rkws086k6k
 Sh7WXL1DCuctnxxrGiQ+4o/+SpL+m1bPKxPfz7M66fr/xoDxWyuOnAVmSkkKeLxwo4fdM56X+
 H2lK/8OWEXKvUp5G3a3ecSUJ8ZFolfGcWGKB1YZJJJQAXaOBgHbJRlNSlmSADZ6Ab6iixJG5k
 2XcfgC7Ye1o/U1O3wzIJILRuyF0nvCP2biOWxPWQYONEGEf/uCyrLYWDC+e3CmOAUGxS9zTHm
 L5Mb6QqpSADy5V9JjQR6QehA==
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi
> Gesendet: Freitag, 28. Oktober 2022 um 11:24 Uhr
> Von: "Jianjun Wang" <jianjun.wang@mediatek.com>
> An: "Frank Wunderlich" <linux@fw-web.de>, linux-mediatek@lists.infradead=
.org
> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Ryder Lee" <ryder.lee=
@mediatek.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Rob Herring" <robh=
+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>=
, "Matthias Brugger" <matthias.bgg@gmail.com>, linux-pci@vger.kernel.org, =
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel=
@lists.infradead.org, "Rob Herring" <robh@kernel.org>
> Betreff: Re: [PATCH v2 1/2] dt-bindings: PCI: mediatek-gen3: add SoC bas=
ed clock config
>
> Hi Frank,
>
> After apply this patch, we found some dtbs_check error with the
> following patch which adds the PCIe node for MT8195:
>
> https://lore.kernel.org/linux-pci/20221020111925.30002-3-tinghan.shen@me=
diatek.com/
>
> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb: pcie@112f0000
> : clock-names:        5: 'top_133m' was expected
>     From schema: Documentation/devicetree/bindings/pci/mediatek-pcie-
> gen3.yaml
> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb: pcie@112f8000
> : clock-names:        5: 'top_133m' was expected
>     From schema: Documentation/devicetree/bindings/pci/mediatek-pcie-
> gen3.yaml
>
> Did you get the same error when adding the PCIe node for MT7986?

i'm sure i had tested the yaml and did not get any error, but on my retest=
 i get same error for mt7986 too...

maybe the right way is to remove the contains in the mediatek,mt8192-pcie =
if condition (to match only if this condition is no fallback),
then it is clean for me. Can you test it with your patches?

allOf:
  - $ref: /schemas/pci/pci-bus.yaml#
  - if:
      properties:
        compatible:
          #contains:
          const: mediatek,mt8192-pcie
    then:
      properties:
        clock-names:
          items:
            - const: pl_250m
            - const: tl_26m
            - const: tl_96m
            - const: tl_32k
            - const: peri_26m
            - const: top_133m


regards Frank

regards Frank