Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Michael Walle <michael@walle.cc>,
        "tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        "p.yadav@ti.com" <p.yadav@ti.com>,
        "richard@nod.at" <richard@nod.at>,
        "vigneshr@ti.com" <vigneshr@ti.com>
Subject: RE: [PATCH 5/6] mtd: spi-nor: add generic flash driver
Thread-Topic: [PATCH 5/6] mtd: spi-nor: add generic flash driver
Thread-Index: AQHYnOb6STy+XODYIEqdWdLkpni6C62IlFOggJwexDA=
Date:   Fri, 28 Oct 2022 18:00:05 +0000
Message-ID: <OS0PR01MB59224F74DF4E981D536271A886329@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20220513133520.3945820-6-michael@walle.cc>
 <202205132220.uRTFaqNA-lkp@intel.com> (raw)
 <e6b22ad3b427770625aa56a4fe700e5c@walle.cc>
 <OS0PR01MB5922F173C180E49273BEECB186919@OS0PR01MB5922.jpnprd01.prod.outlook.com>
In-Reply-To: <OS0PR01MB5922F173C180E49273BEECB186919@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9NU7/q47b7LLfVOx8adLJ8c8mno2KmTGT0U2EKyeoYQgbWfplwMD9cM52ley?=
 =?us-ascii?Q?dzkfQ5nKkyDfEZeCCrVdtqmOeXo2RUrMxhbeEt6beoapN4zQEojcsGvmpO6Y?=
 =?us-ascii?Q?ZBCfrDXv/tqcmN5zhbUDEx+IatH+MuHJtANDcoNxe5MI8/0CvTD8Ga3LMcjM?=
 =?us-ascii?Q?ARK0zWZOsVr9gkOiL0KOJbI9tLwi5u8nin4umzn5J5ckaX2RBGZsIXqCseWa?=
 =?us-ascii?Q?PpBJoOQAv5kqb/8MDqbpLKh7Tj/Ily7WVuGK89fAb860nGc3KBu7fggIvkKH?=
 =?us-ascii?Q?tXM1ZYfa+K9LR/nC4cLCyhdAFlyoSpJtR5pXlfYhgrl5ocT6dJ+PXV0YxeyE?=
 =?us-ascii?Q?tMJw48ls7kzAAVM829S+HpW+sBrbKEgF/57Efv0ilz1qap7qyG8nyH2zQ9q7?=
 =?us-ascii?Q?8z15+t/jv/8BjpmC4jQFj/LC98FofgJ8MaMtHei99tW1SMfDQrgZ8D3wNmTy?=
 =?us-ascii?Q?5GljSmtzeyHP11qk56LGcTpnkCnEIP4PvWf/I+CG9Ajg/bO7/HLKUhS4IJom?=
 =?us-ascii?Q?Q4LVD2VrsdTzdO2YfAnPGL0MYnN8lAzrPkhFb47UKXH22loCWp2nraIyDLPf?=
 =?us-ascii?Q?66HQ1SL6/lwGhEOFeZGiVeWbx/f5LOjTXD+OMgFlq+UhaKHNPaeTo83/9TeO?=
 =?us-ascii?Q?q3yKy0HilMX2LLkAmtn1794gRNrTnjpVPywAnTwV0aUPn1wz2IsnmdFQibMg?=
 =?us-ascii?Q?MGogf5vml9hLbax9qdYv2XCEjdxd7yXwsGgCVxIdfo9tfF1QdgDW9S6dXYTI?=
 =?us-ascii?Q?NwzuTXIaNTPaF77ypedo71iVwcdzv2n9a9tUDEDJG62nxBq9mUzyKsVxuE1J?=
 =?us-ascii?Q?T71E/dEwKCOGvBkmzr6ArxDgl69f7LFuQ+Nqs2UiJho85NwcIa9AJbqxn5qA?=
 =?us-ascii?Q?Z8XyfUeqs55ghYStyfsvDmBz2ti4VTWp4i5oMMUuwJzxxa5my8w4XGYSqboM?=
 =?us-ascii?Q?8Wqx/oBSNstOWhuk8Kk9+T93ED/6n9AtkKn1D0GJMgQt3zRcyCM7T8CKk/s2?=
 =?us-ascii?Q?+CSF8hQYqIhMXqlRlbG9Bjm24HxYGa9Mb4/YKwyTJ5xka87ksUF0rUfeoaHx?=
 =?us-ascii?Q?eLAV3Z6xPEixFQH8+u+82iyqrEFaGZQ2TfEZLAfpt7zPUva9l3UDWq36wbTc?=
 =?us-ascii?Q?qulzIU/99sYwp5US6tYz1HfJW7JZMZgVuM9KqAzDFl8GZGoNuis7X+UsCTpc?=
 =?us-ascii?Q?2LsmZJt6sJF2eZ1SC4Y+UeZdQOpadsUWT6nRmVig1rCgW8X30+nLEmUZuCNN?=
 =?us-ascii?Q?unTkYJt8N3HJaGzqgKAe5oKMhRrXXAXYiW6h9Ca33S2IoUm4AlvPvLY9HAWm?=
 =?us-ascii?Q?ORZNnv1hsP6/dQO5as6FjQiHz5bsArlj9ihGhkyAlEC+yvH8jdR5igprbONg?=
 =?us-ascii?Q?a3Sf7PbxsBuybYWp9KcU3fNiX9n4kOfLDYmeDNBdxjvFqYkP78ZEsGnMbBVx?=
 =?us-ascii?Q?BYDHXK6gX/oLm8AR3wpQSGHpFe0BMOcPmmsIX0c6z9sFjjT/n2C99JzuR8C1?=
 =?us-ascii?Q?OuJ3kWt6EzF+0+PXXIo2r1nVUtwR8yLCMGXHNo+HPXSDJCu9FoBWJ9/bGsy3?=
 =?us-ascii?Q?fXLrzJbIpGjrCfex64NveDb4Rchu9jLYpgpRYTLfyXnVbes+4N1DOSFOJCI7?=
 =?us-ascii?Q?AQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26594562-f476-44f3-73f6-08dab90e3e93
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 18:00:05.6409
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: t0VCvP4MEosF1O4TVZeqQeUgiCr460DeOO4eOGjnHEKWTON3tNLuCy6tqwnAj21V+/dZ93rtwALQkxjfIT+wOiZPE3wtfbXmZNlShYT417w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB8755
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi All,

Any update on [1]?. As per [2], we need to use generic flash driver as our =
flash chip
supports sfdp. Anything to be improved on [1]?? Please let us know.

[1] https://lore.kernel.org/lkml/20220810220654.1297699-1-michael@walle.cc/=
T/#m3ce890b65360f9fbe17b813d692f848b5c6d78e7
[2] https://patchwork.kernel.org/project/linux-renesas-soc/patch/2022071510=
5716.2415068-3-biju.das.jz@bp.renesas.com/

Cheers,
Biju

> Subject: RE: [PATCH 5/6] mtd: spi-nor: add generic flash driver
>=20
> Hi Michael Walle,
>=20
> > Subject: Re: [PATCH 5/6] mtd: spi-nor: add generic flash driver
> >
> > Hi,
> >
> > >> +
> > >> +	/* Fallback to a generic flash described only by its SFDP
> data. */
> > >> +	if (!info) {
> > >> +		ret =3D spi_nor_check_sfdp_signature(nor);
> > >> +		if (!ret)
> > >> +			info =3D &spi_nor_generic_flash;
> > >> +	}
> > >
> > > May be this can be combined as
> > >
> > >  	if (!info && (!spi_nor_check_sfdp_signature(nor)))
> > > 		info =3D &spi_nor_generic_flash;
> >
> > While this is the behavior, I don't like (1) calling functions in
> the
> > condition and (2) rely on the && and || semantics, i.e.
> > to just call the second part if the first is true/false.
>=20
> OK fine. I recently got a review comment from mainline for optimizing
> the number of lines. That is the reason for suggestion.
>=20
> Cheers,
> biju