Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 14:44:54 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     Bob Pearson <rpearsonhpe@gmail.com>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        Zhu Yanjun <zyjzyj2000@gmail.com>, yangx.jy@fujitsu.com,
        y-goto@fujitsu.com, mbloch@nvidia.com, liangwenpeng@huawei.com,
        tom@talpey.com, tomasz.gromadzki@intel.com,
        dan.j.williams@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [for-next PATCH v5 03/11] RDMA: Extend RDMA kernel verbs ABI to
 support flush
Message-ID: <Y1wVFm2SVQ/ZLUpU@nvidia.com>
References: <20220927055337.22630-1-lizhijian@fujitsu.com>
 <20220927055337.22630-4-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220927055337.22630-4-lizhijian@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rY5PSlvJDQSHYYimPfGIcuArGWGCryDu9OX6yMfnbFrmnsDIcjkGbPuPSapj?=
 =?us-ascii?Q?aKBwWkuR5VBiGyciX4h3NBcQzNaeJT7WweMWAOuJj2QKoneBa/3TX4eyjkps?=
 =?us-ascii?Q?QG/94fEPKJCTBi/XzTbJIIBMSj0tUIqIaZLAnXIK92dUZd1LeZ7KWQIhOg0l?=
 =?us-ascii?Q?2nh57aTBfmYjFK6EAI63Fi5CaFzXGj+PAXF/OWZvWlr736ZAIZCPHoeSb298?=
 =?us-ascii?Q?CvGkmO0ku+yDDOWk/d5iTKr5uU2QUTPkvPfm3edDnVs6pfqViC4wC1nQpmJ9?=
 =?us-ascii?Q?qvYc1ixLgBjifO4ZvQOW5kRt3GpaZSu/eaV+qVY3+hQefErUS80URhcFU93e?=
 =?us-ascii?Q?jdI2XrcOcnJ7j9dV3aq6hMCxi7ml8hZJPLy8GZiEiCSF8C+L0wHx/+t0iENt?=
 =?us-ascii?Q?Am6wkW6xxLIdYJfholEWSw1Nb7IPWcJdRXwby3C9VpPR6B2wuHc1IC39kxcG?=
 =?us-ascii?Q?CSORxP0DH0gyxyCFC8YtMikF2QnFL0wL+xx4MlUU/2EQ5qGAdvW/kPTUdEym?=
 =?us-ascii?Q?YmSQaSYuUGkVtFgkNUbUJLGk4INiM9aEnFUhmPu8wTtHvbJi052Rfb+pIoTv?=
 =?us-ascii?Q?bgtuY54/CmStKPP4XWvARBNBQ3wC2tzQ+SDlReAcDJ07CdMt6HD9YJ9/ZwbC?=
 =?us-ascii?Q?/MsegkB3Ot+chIDRckRYuxcd38lY5O/5ZJJD+QrGbnO4FgUVjiggrpF/OakN?=
 =?us-ascii?Q?ffE/uEAiWL2vEUx5UZhyXHnSfqgsP9f00Frc3jeecA13qGsobYN/P4M7kA+/?=
 =?us-ascii?Q?D2MNvRusLAl2YGKXVU0B4YsEKa6u1qzhyn7BtCFWvibz183t9KJ9gvA1rY9r?=
 =?us-ascii?Q?g23bXF3wEF9L4JpqQjKRTk42/57pDPK0BA7ScwPfE96MK39CfcaTOfsSAy2T?=
 =?us-ascii?Q?E6PVSiLRZcBSdw6GcAi8LZVqU9XrrKR24IQM4xMvNWMaTDR7sGmtpcY3Qbt9?=
 =?us-ascii?Q?b9ZaztQl4ZpoM+emG5MB9qJblkMB/zs2me9N6RWuoTR7Pl4l9Wr188vg4O7o?=
 =?us-ascii?Q?5vF5ytXvJQPKSykE5YOFpYET55U7IQWgvhmWeqj1KSCWkwX0DIZNpasxLGKx?=
 =?us-ascii?Q?Ghg1WwXdMwM75uXiEpIUGz1U0O+hOkdd0ISXE+2xAsG/C6w8QvtJN23dKq2u?=
 =?us-ascii?Q?5K5+NffYL44BJDNAqVG6uoQhC37KV58av+N3z32p9p+XAPf9LBr8Jm4Ix7On?=
 =?us-ascii?Q?uPrDDdg6zp8Kepu41l8PfvyjSlaCCh/KzgVAPQvsN1gB8O+W3uikSkCQalbj?=
 =?us-ascii?Q?Z0GZ3dn/hKRc8JOLk6+NCmCSPiTb8pRDdnHRzWxIQeODkyCjVshmiOzITFhN?=
 =?us-ascii?Q?v9AQnx8sSbpjk5V1EK5/WSWvz4eNNr5mxzwNmdgsNPh+RYh0/Lx4VhICq78Y?=
 =?us-ascii?Q?r3fsv/StBgNzafUU1cDgRAa5WLVrHl6U0zIh7MTnLy3LQP5s0/QYlB+fQOKR?=
 =?us-ascii?Q?N+9op/idTxw6jndjxSrBHMmnaMr0tmnXiwj7wqEJmrBLflCB0Wzj4TzLRqJ1?=
 =?us-ascii?Q?6Aqi+HM5QZXlinsoodLWl/6qKxxAOmV0knvo1DRhVqSmarUPCM54vx/d1xOd?=
 =?us-ascii?Q?+47YgZR+nlzsfAXELEY=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 887fd9e0-2a20-4072-3c3e-08dab90c2044
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 17:44:55.9841
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DPDxQ6l/WhcDE0nsgjxG05whqwLZ/365szAbhO7K8TBsbMQaOsSSRCXfAg2KOl+2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4370
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 27, 2022 at 01:53:29PM +0800, Li Zhijian wrote:
> @@ -4321,6 +4330,8 @@ int ib_dealloc_xrcd_user(struct ib_xrcd *xrcd, struct ib_udata *udata);
>  static inline int ib_check_mr_access(struct ib_device *ib_dev,
>  				     unsigned int flags)
>  {
> +	u64 device_cap = ib_dev->attrs.device_cap_flags;
> +
>  	/*
>  	 * Local write permission is required if remote write or
>  	 * remote atomic permission is also requested.
> @@ -4335,6 +4346,13 @@ static inline int ib_check_mr_access(struct ib_device *ib_dev,
>  	if (flags & IB_ACCESS_ON_DEMAND &&
>  	    !(ib_dev->attrs.kernel_cap_flags & IBK_ON_DEMAND_PAGING))
>  		return -EINVAL;
> +
> +	if ((flags & IB_ACCESS_FLUSH_GLOBAL &&
> +	    !(device_cap & IB_DEVICE_FLUSH_GLOBAL)) ||
> +	    (flags & IB_ACCESS_FLUSH_PERSISTENT &&
> +	    !(device_cap & IB_DEVICE_FLUSH_PERSISTENT)))
> +		return -EINVAL;

This should be -EOPNOTSUPP as the above is changed to in for-next

Jason