Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221020115513.93809-1-ulf.hansson@linaro.org>
 <CAJZ5v0iPaP60OxzS4RQv8-JO1-cuv=JAW8zHwjCbyVXgLDa-RA@mail.gmail.com> <CAPDyKFpo_JhpGRZwJExMxPoit7yzp_LByfUEbkkLZxgUdNGRFw@mail.gmail.com>
In-Reply-To: <CAPDyKFpo_JhpGRZwJExMxPoit7yzp_LByfUEbkkLZxgUdNGRFw@mail.gmail.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 28 Oct 2022 20:09:15 +0200
Message-ID: <CAJZ5v0iQmOZAV_zXq=GkDsf3yc=LMhnfdTc3sozfC4w+APeEPw@mail.gmail.com>
Subject: Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-pm@vger.kernel.org,
        Johan Hovold <johan@kernel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 25, 2022 at 3:18 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Tue, 25 Oct 2022 at 15:16, Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > >
> > > It's useful to understand whether we are using OS-initiated (OSI) mode or
> > > Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> > > Therefore, let's extend the print in the log after a successful probe with
> > > this information.
> > >
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > ---
> > >  drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> > > index 821984947ed9..c80cf9ddabd8 100644
> > > --- a/drivers/cpuidle/cpuidle-psci-domain.c
> > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> > > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> > >         if (ret)
> > >                 goto remove_pd;
> > >
> > > -       pr_info("Initialized CPU PM domain topology\n");
> > > +       pr_info("Initialized CPU PM domain topology using %s mode\n",
> > > +               use_osi ? "OSI" : "PC");
> > >         return 0;
> > >
> > >  put_node:
> > > --
> >
> > Am I expected to pick up this one?
>
> Yes, please!

Done, thanks!