Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 14:45:45 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     Bob Pearson <rpearsonhpe@gmail.com>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        Zhu Yanjun <zyjzyj2000@gmail.com>, yangx.jy@fujitsu.com,
        y-goto@fujitsu.com, mbloch@nvidia.com, liangwenpeng@huawei.com,
        tom@talpey.com, tomasz.gromadzki@intel.com,
        dan.j.williams@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [for-next PATCH v5 01/11] RDMA/rxe: make sure requested access
 is a subset of {mr,mw}->access
Message-ID: <Y1wVSSnV1nYRyiho@nvidia.com>
References: <20220927055337.22630-1-lizhijian@fujitsu.com>
 <20220927055337.22630-2-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220927055337.22630-2-lizhijian@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9MNeFFmp90r8tEYKXskzW9raB85oVges2ybczbGxm4BJVT4/dshLqr5xpsMP?=
 =?us-ascii?Q?EP93W1eJr/mSJkoQSGK5Rf2doRRZVVHyDfMPCjnPPfbNosdEax/72oJKvZH6?=
 =?us-ascii?Q?PeNEzJKW5rPZN+2sRhLJnJ7mPszLNaOBAFiLLSoiHeyQpdWblMZEOovSc7fU?=
 =?us-ascii?Q?GVuOBQeiWR1QuRIAFrxCf3QqIxZVwNTHavmEGUg32saerGiktnhV83ENEilC?=
 =?us-ascii?Q?NMdgHl++CeKKgyPlvqTFFWOh1nNgzk4Qw96zMqRDkUBKvZJACiuDzo/L+Qu5?=
 =?us-ascii?Q?ls2vdWtNf8NUr26/4vKVapkGr/8ZjsZetX7D2fupLcpbZq9OdbkmPh1pEAhJ?=
 =?us-ascii?Q?K7jEw2PSVYhBUoJl1LuC0/oILoYplJdXugVjJ4Tb+kgsqIsQ9nmHxMiv/vZk?=
 =?us-ascii?Q?bEDVLmiGYyShXEnMrYaTWSLs61dAJ7ZehbkaULsJp2Aw701xdUDN6SBvskSn?=
 =?us-ascii?Q?pt+cka6ZamZYrFNGMmg+lzNE4gu94bP8eMwDki//AowlRHHbuULdG1zArj7+?=
 =?us-ascii?Q?mB/NeekWaIpsb78EqYcM6+Og0bAexWVIhpf/BMsHOUnnbOSs/UOibCPqiNw2?=
 =?us-ascii?Q?GiHA1EB5yVrMCrmso2J9PLcy2kBaVPna3CeLzu8LlIYwS2IniKXUk3YaHCvL?=
 =?us-ascii?Q?iys9DTkXAunQ7j07QHoGuo4OYhWSavV7vu48cZB0J/Yvx6HYZuAl/Uf5qZVH?=
 =?us-ascii?Q?OcMTQ9IRLYYFcOdMOyt2ocZucuud3QTdMxGP8be/gL6PgQyTWylOYkqlOXtl?=
 =?us-ascii?Q?X0cMNap3V+lbLEUByDsqBf+Nn4UOrE/g8NQKale2EdXUD/z2E3eTfj5lfGhS?=
 =?us-ascii?Q?YaW/EfSwyzQOofNC11H4M5DmYgq7Yx3nh0y+Bhped9CaQZhZlBv57Wz+MCH1?=
 =?us-ascii?Q?xVrNkx/sm2wxOgm5m3K7oI3kBjAOm4on0Z6eFqbpQCoDncBKt+AWXYhAg7bC?=
 =?us-ascii?Q?gAWAxRbkEl9BgZmKCP+7bE5JEW6mErGPIGiyPb5dzEeE2mipTTocKYIqr9fH?=
 =?us-ascii?Q?BGomuqT4lRO9gmpt7Qmy/7HHGiqYFoX0xtKuNpx/Yee/5Bp5NHiAMLM41HxO?=
 =?us-ascii?Q?3Hjvanil6nOxHnFN7E9aJrAtl9Fj03JwNj2AX6LbHKDt3HYC8MHaTBSEseHw?=
 =?us-ascii?Q?dznWzuOuVlK1a0pahjdVgd8EbZ4VH7fR5Tr+9xGLXSnIP89SKKMGby7ZAnD6?=
 =?us-ascii?Q?+C9/MhqNYr/T5UwrGiZY0Lukg1OXmQwPSei3fzcMoGjvcW6+hJzhSOstJHyB?=
 =?us-ascii?Q?FOjSzr+IKUsfvwv8L4hylC4NwHgOhzVuJ/W5cVAKS8sE4WoqcrFdLpENdroX?=
 =?us-ascii?Q?pXu8mcH9J0CMWA49y8ZqGu+YfoskxDaN+6rgrklIdSQzvB58P7hgv0CdVRql?=
 =?us-ascii?Q?P8MESk1WzxBEYCIu3TSWMHq+MLi3kQsZMV2B714YyuKKSPWVpEbxcp/sJw+v?=
 =?us-ascii?Q?XSJ2lC4TEFIoyQFpX0WKht4760ZccFTOkTw8cnShPrSlrnu4rbMlxZjkXFaQ?=
 =?us-ascii?Q?KD+zNF9lz4fkRCzdP2/NdGZ+Z5WCECzJYII/KrHGCxf2u0S6NZLhUfQTrEEv?=
 =?us-ascii?Q?aZVnFEZ4loeAa0Sl2UE=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 883dd16f-050e-403c-dbfb-08dab90c3e8e
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 17:45:46.7892
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1fYxB7nI6clEn++VeSWQq5qVIIazsDxgnfM3x/dWzLsTjmg4cFbVEizwfnXYlumr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4370
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 27, 2022 at 01:53:27PM +0800, Li Zhijian wrote:
> We should reject the requests with access flags that is not registered
> by MR/MW. For example, lookup_mr() should return NULL when requested access
> is 0x03 and mr->access is 0x01.
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_mr.c | 2 +-
>  drivers/infiniband/sw/rxe/rxe_mw.c | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)

I'm going to apply this little bug fix to for-next

Thanks,
Jason