Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2856044rwi; Fri, 28 Oct 2022 12:11:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM57mKqB+xiQqbPNJsyVRIDMDK7p14vLrgDyvc0VOB5k+jDd3a4yjthLfQsicdTk1ZbJI0IO X-Received: by 2002:a17:90b:1c02:b0:213:17f1:50a7 with SMTP id oc2-20020a17090b1c0200b0021317f150a7mr773264pjb.138.1666984266578; Fri, 28 Oct 2022 12:11:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666984266; cv=none; d=google.com; s=arc-20160816; b=YjZjE1zCO5z152nVqr3kBwjUgc4NigntEbC3tSdWZ+g3MJXcJux22ADsZGfSfgLioY 13Bnn3hxXzTroNMKxYBn9JUq7IAEJr78ghT80Y+/UkcpYbC8P/QAsTyhIRX15BE9FJHr rwGamPd/0gXvdpKw9G/N3xTnMjsNcH9S01AlnhaUAt7Q73WVMkWK5rMN963hrARU02Ve fnUmSgLUQ7FUp5R9j6hZO6hKaZwO+kO13/+vq90pTq57GRsv3poE2cAuKbhQEq1bz1Mk PXuHx7ywl3oG2Z/plaXoWX0zlRXoNRsmj0meBTktClihwv9nHFoPiNI8+ViguMwyeY/X FvHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/EIB0lD91u5m+75yE4pCABtLPo/3hXJozv3DCGaJfOc=; b=fkq+JVl7scNXY+cwX3uPMsuTu8ppGKNWWd05+T6h5rYm83mwVfptWaf3dQljpMqpgx E72uLI/3WRwiqkVravZKXEa5MijOOQTdLC6wYd0wDGM14yexGgSNeU24iyjHN90jcSKa KZ/ax+Sv+mxtJGYM2nwq5tLKv3GPugiDdJLsPZLh2hHIC5CT1UBxJEUJSaC2JYkFQKV0 wBq9Noo8wScV7Ga/+tTIJIgiJm1px7rSSN9CBygJL8FNj16zzNbbeMwEd5xVAfiPUHLi PF73lNjjUNShVKFqYzxUsYD1G6VrXpan0tzbGxDaTCnLquM4HKNP730zwXGqgKunhG0d Be1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H7TzOea8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a6-20020a170902710600b0017f7fffb591si5472768pll.374.2022.10.28.12.10.53; Fri, 28 Oct 2022 12:11:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H7TzOea8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230211AbiJ1SoT (ORCPT + 99 others); Fri, 28 Oct 2022 14:44:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230151AbiJ1SoS (ORCPT ); Fri, 28 Oct 2022 14:44:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9AF8244730; Fri, 28 Oct 2022 11:44:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5FAD26226B; Fri, 28 Oct 2022 18:44:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FA66C433C1; Fri, 28 Oct 2022 18:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666982656; bh=B3JwPgDF3f7ACG62Nwjw0J32bbbGD43RnJnEc3pRdBw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H7TzOea8j+chWb+NPhAXFXMuJIUbfoQGA5xIXvtR9de/3ZjdyeuVcSWkS6tDwYYY3 qRupdmLzuYflNbmmJPaOI21mmOkrem0z3Bw03MwWu+ZAFoYs0wluwuziFAfxw1m0pd HD4ZanIHx5uA6xKdRrs3S2FKADSBE9aPvYVW3XGJ/qQJfNVraEZ0ODTClQkLxwkvQW uszkcj86aDAjZgZdiqQY+MtT9GFSG26nl7eu/w6+0dc+sphAOsA05Z666nkZNzVLNd xCP/5Moti05BLYAjVnaG5JYKbRQpc4Gsu5GRFZkMEFwHLfHx/+AGfS9eoc/r3KqnpL ZdANUAnkZiTpQ== Date: Fri, 28 Oct 2022 19:44:10 +0100 From: Mark Brown To: Ajye Huang Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Liam Girdwood , Krzysztof Kozlowski , Rob Herring , linux-mediatek@lists.infradead.org, "chunxu . li" , Takashi Iwai , Jaroslav Kysela , Jiaxin Yu , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?N=EDcolas_F_=2E_R_=2E_A_=2E?= Prado , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2 1/2] ASoC: mediatek: dt-bindings: modify machine bindings for two MICs case Message-ID: References: <20221028172215.1471235-1-ajye_huang@compal.corp-partner.google.com> <20221028172215.1471235-2-ajye_huang@compal.corp-partner.google.com> <628ac98c-0755-e6f6-e010-f1e772c4b71a@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="I1UEIiYQUOnwfuPx" Content-Disposition: inline In-Reply-To: X-Cookie: The time is right to make new friends. X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --I1UEIiYQUOnwfuPx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Oct 29, 2022 at 02:26:30AM +0800, Ajye Huang wrote: > On Sat, Oct 29, 2022 at 1:58 AM Krzysztof Kozlowski > > Switching how? Enabling? What is the meaning of each GPIO pin value? > I think I should add more like an example, > description: dmic-gpios optional prop for switching between two DMICs. > Ex, the GPIO can control a MUX HW component to > select dmic clk and data form a Front or Rear dmic. > Do you agree with that or have other suggestions? If do, I will send > the v3 patch for you to check, thanks There was my thing about putting the names in DT too. --I1UEIiYQUOnwfuPx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNcIvkACgkQJNaLcl1U h9Cpkgf/fVls3aPRMwD1mG2Hu2WQAUaJSm7fMJ++/Hu2yFAAiM+ywsOOetAk/VoZ A5aHmyM3TF/3vuWQ+WPMUsbB/EHGCpM6hAyc277lPmd16RIza/jFt9jah3yg0Zfq i5iEny8ZHHp0ADd0i9JCmKd9I2AFxcALnq8xKWWCZkJ9YNm/BkkXegfxx8mBa4DM f+cGJEHyVaoHCmB1qb4okE4ZK/JUEcrJmTaC7YmggqSwS5T7bzxjy2WmCUMKakst 4cqXghPz6QglCvL4VEuFDJ4AMCKXhzDQJEJer17YeYZYnGE7Aw0w0ovTyTueQdKQ rOPijK+3ijD8mH2K/+WvelcMadIzmQ== =fA2V -----END PGP SIGNATURE----- --I1UEIiYQUOnwfuPx--