Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2972721rwi; Fri, 28 Oct 2022 13:57:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7rwU7HJh9Mq+iO+bPwyHiUtPFVUglXByPeUGbeEbFWrzsrIOFZQZ5HB+Om5XJl0nAe2vHV X-Received: by 2002:a17:90b:4c52:b0:20d:489b:5607 with SMTP id np18-20020a17090b4c5200b0020d489b5607mr1229392pjb.40.1666990628546; Fri, 28 Oct 2022 13:57:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666990628; cv=none; d=google.com; s=arc-20160816; b=NWJvI04u4P9sO69uFH3SLPJiO0ddMfSC7plMPj4KL7jhR/MDE1nCSyGHNEGLT11W3o xBs2tAEFlK1ZcMJQkZVr+DmazjpGCS4UjuPVZA2z+gHKMW+BrD3QGUxVS8wQjLhy5Jaf 2nP96qWgDdqwvbDpuWzHft76W+Z0+ZDHq567fQqWfFlfnpUkPPP5cF65LwZ+uUNOaftu XZcKeX8LO8z87ezHvrrmIWjurIDjWZ3SL2OlT31YBAVCzpbds0KmoJW9393JdP7RDSWF pdaRfZhPslgneEktQfphxwbdTamg4ZvsjmWtpA6YWzNg39BAhNYTt3zUZTL0YVYMryYh ODJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wV+E+/SMNeV699Rje9XOtWwOh+RoW8MB13Rtk2kIH54=; b=Uv8x+Ostj8XzS0YqeV+yw4yNhgv029b28NQ0cBJ9Cc2Rd4+mfPG1UZqme86BLYx1xb NZ3Acr3EMdqYBNR/YfcT9yT+1eAiCPYzgTng1vVaiZTLqPRPa8X+bFWD7CKqqIu3vqE/ w6Wbob3J0aIoXltJPDzhtYbsr2VCj0nao3EoLV/EaCVu5ik9TY2VLAlQL3ylWM3JUqX1 AkgqP+9PmC7E74K2M2PLgj1PVpE37UWecLz9HTAyXrtje98C1pXgYnSTmyN8OFuhCh8r iBUuz0WgfbtmLqvt3yY0s5RJ1tIYnYthKitXUo6ZwLFObPEST+56gdxK3s2GD7Dpx5ve bPCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Zgd42Z5S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l2-20020a170903244200b0017f580f64afsi7745680pls.184.2022.10.28.13.56.57; Fri, 28 Oct 2022 13:57:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Zgd42Z5S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229842AbiJ1Uay (ORCPT + 99 others); Fri, 28 Oct 2022 16:30:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbiJ1Uav (ORCPT ); Fri, 28 Oct 2022 16:30:51 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78AA095AED for ; Fri, 28 Oct 2022 13:30:48 -0700 (PDT) Received: from zn.tnic (p200300ea9733e7ce329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7ce:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 758D11EC06D8; Fri, 28 Oct 2022 22:30:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1666989047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wV+E+/SMNeV699Rje9XOtWwOh+RoW8MB13Rtk2kIH54=; b=Zgd42Z5SFTE8Xc3j3xc1VSLfYMBJFZVxHZyh6fjY141Qi+2badS1kc1kDjx2+dxSbyqIRK dcu+8tgMur56gLjZL1CFgFjliSpNQn6T0MLV2JsrpxAhn/1OVcXtElWXfTcn+cHOFE2mFr X7eDXclf2JgXUf9AC3BZRYyu1Kw+mig= Date: Fri, 28 Oct 2022 22:30:33 +0200 From: Borislav Petkov To: Eric DeVolder Cc: Baoquan He , david@redhat.com, Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, sourabhjain@linux.ibm.com, linux-mm@kvack.org Subject: Re: [PATCH v12 7/7] x86/crash: Add x86 crash hotplug support Message-ID: References: <53aed03e-2eed-09b1-9532-fe4e497ea47d@oracle.com> <35c98ca6-10f8-b248-78c5-99fce7e66c65@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 28, 2022 at 02:26:58PM -0500, Eric DeVolder wrote: > config CRASH_MAX_MEMORY_RANGES > depends on CRASH_DUMP && KEXEC_FILE && MEMORY_HOTPLUG > int > default 8192 > help > For the kexec_file_load path, specify the maximum number of > memory regions, eg. as represented by the 'System RAM' entries > in /proc/iomem, that the elfcorehdr buffer/segment can accommodate. > This value is combined with NR_CPUS and multiplied by Elf64_Phdr > size to determine the final buffer size. No, do this: config CRASH_MEMORY_HOTPLUG_SUPPORT depends on CRASH_DUMP && KEXEC_FILE && MEMORY_HOTPLUG help Help text explaining what this feature is this thing will simply get enabled when the user enables MEMORY_HOTPLUG and CRASH_DUMP. and then you do in the code: /* * A comment explaining how the 8192 value has been selected. */ #define CRASH_MAX_MEMORY_RANGES 8192 Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette