Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b69e7350-b4ec-a575-ee46-15198b9fea73@acm.org>
Date:   Fri, 28 Oct 2022 14:41:31 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] iomap: directly use logical block size
Content-Language: en-US
To:     Keith Busch <kbusch@meta.com>, linux-fsdevel@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, hch@lst.de, djwong@kernel.org,
        Keith Busch <kbusch@kernel.org>
References: <20221026165133.2563946-1-kbusch@meta.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20221026165133.2563946-1-kbusch@meta.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/26/22 09:51, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.
> 
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
>   fs/iomap/direct-io.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index 4eb559a16c9e..503b97e5a115 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -240,7 +240,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
>   {
>   	const struct iomap *iomap = &iter->iomap;
>   	struct inode *inode = iter->inode;
> -	unsigned int blkbits = blksize_bits(bdev_logical_block_size(iomap->bdev));
> +	unsigned int blksz = bdev_logical_block_size(iomap->bdev);
>   	unsigned int fs_block_size = i_blocksize(inode), pad;
>   	loff_t length = iomap_length(iter);
>   	loff_t pos = iter->pos;
> @@ -252,7 +252,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
>   	size_t copied = 0;
>   	size_t orig_count;
>   
> -	if ((pos | length) & ((1 << blkbits) - 1) ||
> +	if ((pos | length) & (blksz - 1) ||
>   	    !bdev_iter_is_aligned(iomap->bdev, dio->submit.iter))
>   		return -EINVAL;

Reviewed-by: Bart Van Assche <bvanassche@acm.org>