Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <43f16833-add1-80c3-3bf8-5a6a05e75be6@oracle.com>
Date:   Fri, 28 Oct 2022 16:22:54 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v12 7/7] x86/crash: Add x86 crash hotplug support
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     Baoquan He <bhe@redhat.com>, david@redhat.com,
        Oscar Salvador <osalvador@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com,
        nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org,
        sourabhjain@linux.ibm.com, linux-mm@kvack.org
References: <53aed03e-2eed-09b1-9532-fe4e497ea47d@oracle.com>
 <Y0cmaPTKQuWtwIRh@zn.tnic> <Y0d+mFivS+88+Chr@MiWiFi-R3L-srv>
 <Y1e7Hw0PRDI9NxU9@zn.tnic> <Y1lIoTBNvHrKX5K9@MiWiFi-R3L-srv>
 <35c98ca6-10f8-b248-78c5-99fce7e66c65@oracle.com> <Y1uspLb7fLdtnQq+@zn.tnic>
 <d91f8728-6a63-415d-577c-bd76e69ec7f6@oracle.com> <Y1wL+ZrvD5gTZaKN@zn.tnic>
 <ca43bd5f-8a74-9412-3d4b-52c7d5e54978@oracle.com> <Y1w76RwZUKUvsS7A@zn.tnic>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <Y1w76RwZUKUvsS7A@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFZ6SFRWcVRhMHhPK2txeGhaZUVlbGJ0SEdaTXlXcFQ1ODhUa2o5RUpxdFd1?=
 =?utf-8?B?bHRYOHNUOGtwZHVYZit2dWpBS3JROHhUY1NUc21JMGhMLzlDeUhUQXh6eXJp?=
 =?utf-8?B?ZWtXbHVCOXpZOEVmdm5jM2tMVDZ3bkxiTHQvMnp5TktNWWNlVjZzQ25EeGJU?=
 =?utf-8?B?NzVwQ1lobThQekxnYzdHd2w5SlFrc08zcDhQYjhBMWVzanBVNWJGdkkvNUR5?=
 =?utf-8?B?Q25ubFc2Y2lyRXlrdjhXRHIwWlJENm1LVGVtc3VYclJZZGp3eFF6MDZKQm9z?=
 =?utf-8?B?MnVJa1AzK1llTlNtaVhOUVBvTjlkbzdUT2w2ZUZPN3h5ZDd2eWRhcjZnaHlx?=
 =?utf-8?B?cjlOaG9yQU1Hakp6U1JVaXNGRUZXWnRoSWhqSnFHY1FRYjdUYnZKUHliamdG?=
 =?utf-8?B?MDVJRENvWnZCUzNVSXBMN1JmaVVsU0ZSbWpENTJDNVduR3JtM0REbHBzOW9Y?=
 =?utf-8?B?Nk5CRmdtZzB5V0NrWjdQVjdaQVRMVk9NaGlHRHlNY2QyenE4TiszQVhoTTBo?=
 =?utf-8?B?WU1CVFI2UUh6dkc5Q3dGd0JFUWdFMUJLUVhCekVCdjhPNVhFMTVNaEFlRDlH?=
 =?utf-8?B?Z0w1ZDV1L1cweXZRTFhGM2NJLzIrQVB5OVRRTW1lb3pEWW81SmJXTGs4MURx?=
 =?utf-8?B?eWw0bHhTbFBWMjZCZUg5YTFlampxY1N4RTFQRGdxWDRoQk5JbFdqSzZ4dWph?=
 =?utf-8?B?NmxGU3NmLzlmU3pwdmxlNThtU2JiMEFNdmovM1pqYXhvSGtjbkRDdnZPSTFk?=
 =?utf-8?B?UTlDR3BYbFlIZDl4ckZJTytqd0ZtditZWEdVSmRXd3FYdlU0NS9aU3FwREMv?=
 =?utf-8?B?STg2VXMwWnBhRG9wNDFIODJOT1BZMFh3RHVuWkNFUG1aeEV4TVlTWXNsejVx?=
 =?utf-8?B?R2xpeC9DS3VnaDA1V0NzckplVlcwa3R0cTZiWjc1bGdxamJWUGZkNVpNZ0pv?=
 =?utf-8?B?ZWFmUnNFdi9VUSs1L1F1Y1l4aVZjSHFrN3NXOUYxd054dmloYkZGamE2a2J2?=
 =?utf-8?B?L1Jvd3o4NUtlOHgwdjNGTXlvck5mdWtCTHdQdzN5YmwzZmhLZmdOUVgwMnN0?=
 =?utf-8?B?NDZJZkJQYk80WXlsaWY1cGNiMzFwUkk2M09UdXZJbWIvY09td3Jia2p4TkVJ?=
 =?utf-8?B?NnA5NlV5VDM2NHlYc1hqdTFaWUtINnI1czFWd2RGR0pOdmJBRUFyREVwZXJq?=
 =?utf-8?B?T3RSeEp5RlNEL1Z6UUFOd2FiR0hrMEg4UXpyUGpLM2lwenN1OXdiQm54Wmlv?=
 =?utf-8?B?alZBTy9iemFQdEpnRm5ubWRCMGtFeHlqRTZ3YnZub085a1hITmpDaE9uT2JY?=
 =?utf-8?B?cjdQWDZBcEZ1RTFPZTlBeHUyR1N5MU51cHdaS1JhNDh4N3NKWnYyVzVhVG5x?=
 =?utf-8?B?OXZIRXo0MGVvTmQrZkViUTJKcDdlQVViMHhZd2ZINnhlOWQ5bkZxWkdkR0ZD?=
 =?utf-8?B?cmZUQnEzMStiODY1UG90ZDFwZUpEU3IyRm41VFRKOE4zRU1mencxVDZJT1NH?=
 =?utf-8?B?QVlMTldLeWJ2L3l0SDFQbGJsSFBHUk5VTDVRZjVFQVlMN0txVUFzeTJjVFB0?=
 =?utf-8?B?YlViQ3hTTXI2NUdxNzFJbklTQjRpODNjMUIvd0huRjdQN0JuRTJ1ZEtyTDBW?=
 =?utf-8?B?YThORElUdmszRGRqNHcrQUo2YXZqanlDaEFtRE96YWJ4enh1by9rRUU4VkVL?=
 =?utf-8?B?dUlZWWdTT3JUa3pVdWdKMmZmRktoSHpPMlluMXRobWUwcU56Q0pRdUNyVVlK?=
 =?utf-8?B?b3Z5Z2N3dVRQcUJGMEZOQTF5T0ZtMHovM0poKzdYcGRiK3pPUWcyR2lkSVZz?=
 =?utf-8?B?UkM2bmtNQ210VTFmZUFlTWZsV2pCSytjQWp0ODQ5RFAxNE5NT0ZIdVg3Mk5I?=
 =?utf-8?B?dm9EY2xGT0hBeFo4aExrbng1cENQQXpoNk9vcjlNbklIM3hqaFlLaUlRQ3lF?=
 =?utf-8?B?dXVaZmFVd1hkbXdwQlZOaERJVHlJSmU4NE1rdHRYNDNmeXQ4ZG1DallVY3oy?=
 =?utf-8?B?Yk92V0YrdTFoZnR6cEVSWThFQ3E5WWMvWjdTME50S0JYTjhiN1ZTcTlTT1VM?=
 =?utf-8?B?UTd4ek1KU29KS2wzWUlpQzRoNE1EQTdCZldKRHRhcEFEaFhKWmRDengyVURT?=
 =?utf-8?B?TjZCeUVOTStKVW1qSWdFeGlIejM0MTdPV0tmZjNDVG1RK3FKT3hMdmxTQ09C?=
 =?utf-8?Q?Rflk3+U/6srbKTxryqnx4Eo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a13515b-a1df-4b1c-63fb-08dab92a96a0
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 21:22:59.5391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cLHjwK4Nnhtfl2OEAS9aqL7Xp94GZWdbIuQjITx4odopeL72+YPK9miuBRSgO/qCvrlMIx52rOLXmqK/XvfmMG1Q9ZjT9PdWSq7fc89ZGWY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4832
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-28_10,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210280135
X-Proofpoint-GUID: mewFo1YGaIg96syJkZ4rSAWYV_bkOB7J
X-Proofpoint-ORIG-GUID: mewFo1YGaIg96syJkZ4rSAWYV_bkOB7J
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/28/22 15:30, Borislav Petkov wrote:
> On Fri, Oct 28, 2022 at 02:26:58PM -0500, Eric DeVolder wrote:
>> config CRASH_MAX_MEMORY_RANGES
>>      depends on CRASH_DUMP && KEXEC_FILE && MEMORY_HOTPLUG
>>      int
>>      default 8192
>>      help
>>        For the kexec_file_load path, specify the maximum number of
>>        memory regions, eg. as represented by the 'System RAM' entries
>>        in /proc/iomem, that the elfcorehdr buffer/segment can accommodate.
>>        This value is combined with NR_CPUS and multiplied by Elf64_Phdr
>>        size to determine the final buffer size.
> 
> No, do this:
> 
> config CRASH_MEMORY_HOTPLUG_SUPPORT
>      depends on CRASH_DUMP && KEXEC_FILE && MEMORY_HOTPLUG
>      help
>        Help text explaining what this feature is
> 
> this thing will simply get enabled when the user enables MEMORY_HOTPLUG
> and CRASH_DUMP.
> 
> and then you do in the code:
> 
> /*
>   * A comment explaining how the 8192 value has been selected.
>   */
> #define CRASH_MAX_MEMORY_RANGES	8192
> 
> Thx.
> 

How is this comment?

/*
  * For the kexec_file_load() syscall path, specify the maximum number of
  * memory regions that the elfcorehdr buffer/segment can accommodate.
  * These regions are obtained via walk_system_ram_res(); eg. the
  * 'System RAM' entries in /proc/iomem.
  * This value is combined with NR_CPUS and multiplied by sizeof(Elf64_Phdr)
  * to determine the final elfcorehdr memory buffer/segment size.
  * The value 8192, for example, covers a (sparsely populated) 1TiB system
  * consisting of 128MiB memblock size, while resulting in an elfcorehdr
  * memory buffer/segment size under 1MiB.
  */
#define CRASH_MAX_MEMORY_RANGES 8192