Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 29 Oct 2022 02:17:08 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc:     kernel@collabora.com, kernel-janitors@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Chris Morgan <macromorgan@hotmail.com>,
        Maya Matuszczyk <maccraft123mc@gmail.com>
Subject: Re: [PATCH] power: supply: remove less-than-zero comparison of
 unsigned variables
Message-ID: <20221029001708.fxu6he7pbv7voiy2@mercury.elektranox.org>
References: <20221004064521.498510-1-usama.anjum@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kpqij2bctgflog2o"
Content-Disposition: inline
In-Reply-To: <20221004064521.498510-1-usama.anjum@collabora.com>
Precedence: bulk


--kpqij2bctgflog2o
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Oct 04, 2022 at 11:45:21AM +0500, Muhammad Usama Anjum wrote:
> max_chg_vol_reg and max_chg_cur_reg are unsigned variables. The
> less-than-zero comparison of an unsigned value is never true. Remove
> these checks.
>=20
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---

I'm a bit hesitant to apply this. While the analysis is correct
max_chg_cur_reg is sourced from rk817_chg_cur_to_reg(). That has
has a 'u8' return value as function signature, but tries to return
-EINVAL. I think it makes sense to either fix this at the same
time or change the variable type to signed. Also please Cc the
driver author (done now).

-- Sebastian

>  drivers/power/supply/rk817_charger.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/=
rk817_charger.c
> index 635f051b0821..aa4b33f1bb83 100644
> --- a/drivers/power/supply/rk817_charger.c
> +++ b/drivers/power/supply/rk817_charger.c
> @@ -951,12 +951,12 @@ static int rk817_battery_init(struct rk817_charger =
*charger,
> =20
>  	max_chg_cur_reg =3D rk817_chg_cur_to_reg(max_chg_cur_ma);
> =20
> -	if (max_chg_vol_reg < 0 || max_chg_vol_reg > 7) {
> +	if (max_chg_vol_reg > 7) {
>  		return dev_err_probe(charger->dev, -EINVAL,
>  		       "invalid max charger voltage, value %u unsupported\n",
>  		       max_chg_vol_mv * 1000);
>  	}
> -	if (max_chg_cur_reg < 0 || max_chg_cur_reg > 7) {
> +	if (max_chg_cur_reg > 7) {
>  		return dev_err_probe(charger->dev, -EINVAL,
>  		       "invalid max charger current, value %u unsupported\n",
>  		       max_chg_cur_ma * 1000);
> --=20
> 2.30.2
>=20

--kpqij2bctgflog2o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmNccQAACgkQ2O7X88g7
+pqYLA//VBqbwe7TYlleJXz7Cmqb0nUb+ZG9Pc6wmlWSTpitKPkc1+eAEqJ0azCY
DDZB35scSvAZAyhu/RA1W4+P/v3CW6K172UYSd3xi6IHtwLA9yBNN+k5c/bdpiBH
9nAB/FB2qVN22AHsOeYYRlQ1mTVtvqvvy4DicrM4+AH6WjakJ17QpR/g0xBfjXi/
ZYvYwpzGSGgyBL30IZqFT90dbKlUOTBU6vxsd8bDp448tPhehzfdh0oM0r8lxI34
0d8LDecZlWWY1lbFE7ChDYQ84O5AxEnPABqC3bBVAFUz0pklmAjh0c8rZU8IZcKp
Z6lkETVqwCMLb6auyZfpsbG69JmwnNa53I3qDBB7ub1BauGptcvG0vByqLS6Q7Uc
8kazcsNqiQ+Xmq9ca1rV/p/vSRfraaJJNxGb5zYID0chrsjr7QsirY2AezwgrDi9
x6XzJ1XngE7oTAzdWCfNln0TZ3vUSYOeq+oRduFj4hEEnAuIK1iLTqCUBDS9+Py6
pSho+U2PigHwnh+XTrCHJDIcU1R0By+KLOLUeXvC1k3bvw2uiUsvo2kfDXyecu+v
gsGDTwGwkf4AnMaVKUCPDFPEKhsrIGimP8Pf7I4bR+8zLRxbETznqsBIL0NX2aXa
WRviqu7C1jt3+qYX5Hd3uZgibIyE5Ovtfifa6yiJwG0VTc/ViFA=
=Ig94
-----END PGP SIGNATURE-----

--kpqij2bctgflog2o--