Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3235753rwi; Fri, 28 Oct 2022 18:20:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7bS9MueJsHdcRxrIYQFZ5wZi/gVDANzOekj8WSb6oNJ7UqVYtmAU3K7w/RFoBOGMDmqkP6 X-Received: by 2002:a05:6402:90e:b0:443:ec4b:2b03 with SMTP id g14-20020a056402090e00b00443ec4b2b03mr2039197edz.71.1667006412099; Fri, 28 Oct 2022 18:20:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667006412; cv=none; d=google.com; s=arc-20160816; b=wZLTRueCJdebyvCM2nikvmPqkS5UmcwvZ/HJ/yau/ekf22Cm0yWGq36mlUJuCisx9J m2e/XoucCwM3ivxkVdyyzW46UtDuuIi9+G68qVbtrpNq62SFTwdQW+XuKGDt9+nut/Kk 7gZnG/adai11Uq40a0NCEzS40pJvmf+wE8eQEgsrRVJ0Pst0IM1ZBmzlf62EtRkHlW2/ PolhZ3fERhz+QPkMhGX4YCrmrXcGQkphf4Cs+wJpBwcxxJrWxGrmQgEox37aZAiI5spj 4/ZBl26pK/K4lQJ8XG9RfLvv64+1kBVBvFMHxIPxzFf9Iaqf3DKw6lfWJ25TVicy95gj ySDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=VzirdpB8o7lNjReftiX3IOzTMZDA49bnUBUpRIMEVz0=; b=GPIAiolX0qii8V4MxmTTUuMy+iekEIYn6FNeKSaEgpDGcq81KMLZR3VId6vo2GZjVA U9mrUXbPpg2b9vOlWMZY9q2porhJMTzMWjED7IkQmYEsK1r7mXeE71nnv9/rdfAt9Q0R +3chjUAaEo4/4ysjHPPrKUzB5A48rPVqh/iAMY4hxZFmkX0UMUfPPa+RB+vYfHqWwql9 KBBvmbRUlCzfhXFWBiazWqWkhClVDtZAiVu2WlJbzwTfGCw6MtETfzICOf5ljtT0T4dx k2gV5RidRPoqsZp90/nGh258GJ53wy3aUKhegLRpo7gm2nn8DtfhUYwoZIzd+Z4fTRwt xfIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=C93TkHor; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d7-20020a50ea87000000b0045cd7614e59si228480edo.451.2022.10.28.18.19.47; Fri, 28 Oct 2022 18:20:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=C93TkHor; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbiJ2BMR (ORCPT + 99 others); Fri, 28 Oct 2022 21:12:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbiJ2BMP (ORCPT ); Fri, 28 Oct 2022 21:12:15 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E84591D4401 for ; Fri, 28 Oct 2022 18:12:14 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-348608c1cd3so57508667b3.10 for ; Fri, 28 Oct 2022 18:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VzirdpB8o7lNjReftiX3IOzTMZDA49bnUBUpRIMEVz0=; b=C93TkHor9sG0YrHfYCanrmTbr1ODnssibkMka1CDdjSvu/Qja9+NGxHoPnFObXxZvE GXBANvCg8hYyoao1XJVZQcDuYYKL3hCl8JXwsqfVxvL5RGQoQEjXofWQ+Phej/FE+w2e LM1CCTLbcoxR07mSo8W16zyQ2RRKK5zYAr+dhHIi+eRCHCoJ0CHm8U1iRpIhtclDx4bb 8Bily9FTWUVI93SfVVaif881wa60XSf+Z01xAPviPLn3AadgiNLvr78hrkA8+50Uzft7 8bQ01D7IZ7MVtWs2x5HmKBUo5DugGQadbsn2wzjW4nzOsWY7RyFSH+2r9cffzygQ9G63 tZeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VzirdpB8o7lNjReftiX3IOzTMZDA49bnUBUpRIMEVz0=; b=IIXNTFwQ6xttQE7RelCS87+PeKD3mwsw3jYKuOtWKN1e/HEXQBZACmuz+UR57zOFsw AJW/VfuGlwx65UOs3SCduxXbCpuXRiIQ/LFQJoDQuk6GNgs2suK31GOKZ44dJW9vzgMS nPBMFOp8fzz68E0yXHQnSjYUxkiV1QU+nptlkrQTs8j+KlHVfMEouU8r+leQbVXwha8k heyzdgpJPr0lTZaXOuOqgcCMwz2Ub9cCzemTa93j0/rWcQhPy2QXhy9b4vn10hjaYnFP r92Mr/qiwgsrkSIWJlEqNzJeJhggxCckQOwxuOeuKsaLsSnBaKyGF6R39U3pYC8bePyc oXYw== X-Gm-Message-State: ACrzQf1SMFkWPgAhkiSud3SdY/rOSwFPYpKB9t6zhrmQUJEjlM2UdPJm DUjrONw8Yea+/NnC0c4trE3h+tE= X-Received: from hmarynka.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:925]) (user=ovt job=sendgmr) by 2002:a05:6902:1608:b0:6cb:75a6:7656 with SMTP id bw8-20020a056902160800b006cb75a67656mr1722714ybb.223.1667005934151; Fri, 28 Oct 2022 18:12:14 -0700 (PDT) Date: Sat, 29 Oct 2022 01:12:11 +0000 In-Reply-To: <20221024113005.376059449@linuxfoundation.org> Mime-Version: 1.0 References: <20221024113005.376059449@linuxfoundation.org> X-Mailer: git-send-email 2.38.1.273.g43a17bfeac-goog Message-ID: <20221029011211.4049810-1-ovt@google.com> Subject: Re: [PATCH 5.4 086/255] once: add DO_ONCE_SLOW() for sleepable contexts From: Oleksandr Tymoshenko To: gregkh@linuxfoundation.org Cc: christophe.leroy@csgroup.eu, davem@davemloft.net, edumazet@google.com, linux-kernel@vger.kernel.org, sashal@kernel.org, stable@vger.kernel.org, w@1wt.eu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, This commit causes the following panic in kernel built with clang (GCC build is not affected): [ 8.320308] BUG: unable to handle page fault for address: ffffffff97216c6a [26/4066] [ 8.330029] #PF: supervisor write access in kernel mode [ 8.337263] #PF: error_code(0x0003) - permissions violation [ 8.344816] PGD 12e816067 P4D 12e816067 PUD 12e817063 PMD 800000012e2001e1 [ 8.354337] Oops: 0003 [#1] SMP PTI [ 8.359178] CPU: 2 PID: 437 Comm: curl Not tainted 5.4.220 #15 [ 8.367241] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 [ 8.378529] RIP: 0010:__do_once_slow_done+0xf/0xa0 [ 8.384962] Code: 1b 84 db 74 0c 48 c7 c7 80 ce 8d 97 e8 fa e9 4a 00 84 db 0f 94 c0 5b 5d c3 66 90 55 48 89 e5 41 57 41 56 53 49 89 d7 49 89 f6 07 01 48 c7 c7 80 ce 8d 97 e8 d2 e9 4a 00 48 8b 3d 9b de c9 00 [ 8.409066] RSP: 0018:ffffb764c02d3c90 EFLAGS: 00010246 [ 8.415697] RAX: 4f51d3d06bc94000 RBX: d474b86ddf7162eb RCX: 000000007229b1d6 [ 8.424805] RDX: 0000000000000000 RSI: ffffffff9791b4a0 RDI: ffffffff97216c6a [ 8.434108] RBP: ffffb764c02d3ca8 R08: 0e81c130f1159fc1 R09: 1d19d60ce0b52c77 [ 8.443408] R10: 8ea59218e6892b1f R11: d5260237a3c1e35c R12: ffff9c3dadd42600 [ 8.452468] R13: ffffffff97910f80 R14: ffffffff9791b4a0 R15: 0000000000000000 [ 8.461416] FS: 00007eff855b40c0(0000) GS:ffff9c3db7a80000(0000) knlGS:0000000000000000 [ 8.471632] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 8.478763] CR2: ffffffff97216c6a CR3: 000000022ded0000 CR4: 00000000000006a0 [ 8.487789] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 8.496684] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 8.505443] Call Trace: [ 8.508568] __inet_hash_connect+0x523/0x530 [ 8.513839] ? inet_hash_connect+0x50/0x50 [ 8.518818] ? secure_ipv4_port_ephemeral+0x69/0xe0 [ 8.525003] tcp_v4_connect+0x2c5/0x410 [ 8.529858] __inet_stream_connect+0xd7/0x360 [ 8.535329] ? _raw_spin_unlock+0xe/0x10 ... skipped ... The root cause is the difference in __section macro semantics between 5.4 and later LTS releases. On 5.4 it stringifies the argument so the ___done symbol is created in a bogus section ".data.once", with double quotes: % readelf -S vmlinux | grep data.once [ 5] ".data.once" PROGBITS ffffffff82216c6a 01416c6a