Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 18:44:26 -0700
From:   Brian Norris <briannorris@chromium.org>
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: ehci-pci: Set PROBE_PREFER_ASYNCHRONOUS
Message-ID: <Y1yFejAhNogYVpIW@google.com>
References: <20221028141821.1.I9a5353f81d1509f85f3a04f0cdc9099f6fe60811@changeid>
 <Y1x+KmXhzikbEm8U@rowland.harvard.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y1x+KmXhzikbEm8U@rowland.harvard.edu>
Precedence: bulk

On Fri, Oct 28, 2022 at 09:13:14PM -0400, Alan Stern wrote:
> However, I'm curious to know why this patch makes ehci-pci use 
> PROBE_PREFER_ASYNCHRONOUS even when CONFIG_PM isn't set, whereas the 2/2 
> patch makes xhci-pci use PROBE_PREFER_ASYNCHRONOUS only when CONFIG_PM 
> is set.

That's definitely a bug in patch 2. This has nothing (or, little; probe
order can technically affect the PM suspend/resume order) to do with
CONFIG_PM, except that the .pm hooks tend to sit nearby, and repeated
driver patching makes the author's eyes glaze over sometimes...

Thanks. v2 coming.

Brian