Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Kees Cook <keescook@chromium.org>,
        "Ruhl@www.outflux.net" <Ruhl@www.outflux.net>,
        "Ruhl, Michael J" <michael.j.ruhl@intel.com>
CC:     "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH v3 1/2] igb: Do not free q_vector unless
 new one was allocated
Thread-Topic: [Intel-wired-lan] [PATCH v3 1/2] igb: Do not free q_vector
 unless new one was allocated
Thread-Index: AQHY4tOnBcedB+c6kEOS5ogdMhNIEq4kx1fw
Date:   Sat, 29 Oct 2022 03:29:12 +0000
Message-ID: <BYAPR11MB3367C323EB65A6A52FD16769FC359@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20221018092340.never.556-kees@kernel.org>
 <20221018092526.4035344-1-keescook@chromium.org>
In-Reply-To: <20221018092526.4035344-1-keescook@chromium.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pQ5jeaWTcAYss8LRYj2pJw/UkHa7BiGefkqDfwfNG8XUqHQbWIMCefgxRRtO?=
 =?us-ascii?Q?uPQt5aGQjCNa7m7OJx42fCxgBbr4rydZjvtMbqZKFCE0dCX0kwax1ZdSo5d1?=
 =?us-ascii?Q?hAKgOlCV/j+IEqUqQ++z03piHmtIzyscMNpcS824ypet0bH3q2qZTuSZC7mg?=
 =?us-ascii?Q?lqcV37Ak7v9nxr3mEQ/g8HLGZm6vRmlxvDVTfcRZZE87znBYwvF//svLpRWz?=
 =?us-ascii?Q?RmIbiPYqdr/r/WoBcm44+in0Sw2PWweqRNljvX1j6bQBxkO2aKXsLD2eKZup?=
 =?us-ascii?Q?JGTzDmr1ib2fNy5ltLmcOpfazKHGzounWBwWlaVPSTlNtrjyWmqB3am8ia7S?=
 =?us-ascii?Q?k9jDac5NPC57ZByPyhD+Nt20q9vf+vV1+Y+q409HrX1E5dduwiq+RnRBvOGZ?=
 =?us-ascii?Q?KfhJZGuuddnaViIcTNgOeB5Ona1/Wop4ejcJyZVtYlOJgY1mo9ms2JkNRjOQ?=
 =?us-ascii?Q?VYgH9rJvNp3MTrYCNQNivbpiDVbPVrDrriK5LzbhOTMlQSDea4INzP8RZRe+?=
 =?us-ascii?Q?/C6S4yxLOnRIoyBfZAoGISxCmXROjYNG/GLEEwsN8t0iOC/kam5K6v3DHXvg?=
 =?us-ascii?Q?OWe3dDJmOBZJSNrTLHZJ3Xn0ZkKQcEjBPvi23vvoclwZvNeaOdZlVWfLjldk?=
 =?us-ascii?Q?Qal82vRa0+1sLAE2IoMFizNVveJms/mTplLhzGeXFz1kKi1vy5Z6XGWWSqYB?=
 =?us-ascii?Q?gBDaV8p/HzhKMeR4/LEzperui5qT+Np9LMssugget+Y2U0FR9DnqWN55epz4?=
 =?us-ascii?Q?P5zfxOQAv0jbdblcRgRPcYzb+DtNXVZktNfOFeXTSkdrPjNY/XGhd8/3Fs0l?=
 =?us-ascii?Q?YTl8BCiJI1fqFZI+FeELgaVAU1sK+GrddOf8kGgMJSkjFaOo6Tx95g1rb3yI?=
 =?us-ascii?Q?dn0FVov1Rd08ZID20pkDHz3Ku3fk2SyjWyn2b9FoaouyfKThKJ49GqRFUVEL?=
 =?us-ascii?Q?3Zfxt7IiCeffcGG4poU3tSM8kbTB7y++Fct7vFfe2O4pKJkVmA9kbAfSfEFD?=
 =?us-ascii?Q?IYUnpTbxn8WBEcmxOwntwvU3gYUY0Cv6zJUQNbvtxriOXcaXsWZxltm9mluO?=
 =?us-ascii?Q?TZi2zaoQ98mH97Qb/kQPcv/2GYo2DsuSBQgIo6A1j+rXPj2NkIGJE/UbX9KQ?=
 =?us-ascii?Q?nJma0vwr6J3Fi28tED5zm9rXe1baL+0P/YPey3TszaimwyrM4dlaws29QDhE?=
 =?us-ascii?Q?XDZSGMqncEbtQJuCTSRqFR9/VrfqiMldTEfx+5rcP5yfSDUhKzLLdIK4OOwI?=
 =?us-ascii?Q?jfLB/H1nFNFw7bDseCexQdddg6y+ObCqYugKGV5OvePMBeAtzY1XaQneERee?=
 =?us-ascii?Q?soiPmjcvDVKZm1blhST70gI1DZk50VPJUjHH5RU5C8C/3ketEJvu8aE95pgl?=
 =?us-ascii?Q?4yPiYGY1Us6ghHnpAIy2IpYkBCZRfnlhBNvs3t6HhSk0zij2yaeeiOrGigAW?=
 =?us-ascii?Q?5U+nbiBOKCIY1VYvN23MJxvcuewKZLNLJsmEbN/CWSO1QCIgRYYcxsu/5DHg?=
 =?us-ascii?Q?sziMqKUcsfk+IdHt9aYQrIa+ofSDvpaumszAPs8gSsOjHI/YTUKO0uO2YgWe?=
 =?us-ascii?Q?WzGFrom9b5UbDK4oidIdtHUzZggco7kjuUunxG2e?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69e5778e-d55c-41ab-0e21-08dab95dbfc2
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2022 03:29:12.6296
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jF8NpRKLwsS7a94/cKGxQ2DlR+KB4Rpt+XdRcP9nIgOtNF6IW34Fh1S+uAFyqIeWgA75ip4mAjipTo1Rtsu3QQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6811
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Kees Cook
> Sent: Tuesday, October 18, 2022 2:55 PM
> To: Ruhl@www.outflux.net; Ruhl, Michael J <michael.j.ruhl@intel.com>
> Cc: Kees Cook <keescook@chromium.org>; intel-wired-lan@lists.osuosl.org;
> linux-kernel@vger.kernel.org; Eric Dumazet <edumazet@google.com>;
> linux-hardening@vger.kernel.org; netdev@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller
> <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH v3 1/2] igb: Do not free q_vector unles=
s
> new one was allocated
>=20
> Avoid potential use-after-free condition under memory pressure. If the
> kzalloc() fails, q_vector will be freed but left in the original
> adapter->q_vector[v_idx] array position.
>=20
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>=20

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)