Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Kees Cook <keescook@chromium.org>,
        "Ruhl@www.outflux.net" <Ruhl@www.outflux.net>,
        "Ruhl, Michael J" <michael.j.ruhl@intel.com>
CC:     "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH v3 2/2] igb: Proactively round up to
 kmalloc bucket size
Thread-Topic: [Intel-wired-lan] [PATCH v3 2/2] igb: Proactively round up to
 kmalloc bucket size
Thread-Index: AQHY4tOo1jdmYkTk8Ue0EBJawSM6bK4kx9gw
Date:   Sat, 29 Oct 2022 03:30:37 +0000
Message-ID: <BYAPR11MB33673DF155DB8935BBFDEA02FC359@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20221018092340.never.556-kees@kernel.org>
 <20221018092526.4035344-2-keescook@chromium.org>
In-Reply-To: <20221018092526.4035344-2-keescook@chromium.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oFus70X6BGfE7ELSFtz5uKYE+n3QshR39ZEdLVdSEZcP6pmZqwx9Gg5Tr23n?=
 =?us-ascii?Q?kcdRgTYtc1vY8II+D064g11vphtc9d4183211dOcU4m0KBLF7NH9Mw/zIIIB?=
 =?us-ascii?Q?WC2Kc7ABaxqet5FZO2j7pjGANyWlRvdiLJh5QL0OP7hukSLrYJSH0UKOJjxT?=
 =?us-ascii?Q?wD+KSuXTLTw73NfBkNBPoL7znRgs2Y96LdMB+D95oHPBWpEl4tGxFnBx5d6c?=
 =?us-ascii?Q?/ZnGcl7r+wwFk3IOzu8jsAn0qBU2UN6TBgO9+z8n6bTuliPWhFln7Q4GgpN5?=
 =?us-ascii?Q?XmhwTgse/o6Vpd7+Xy3qaAQJDetgjhiy33gWNsdBWYX1Wj4dFt4k6kgCTYL1?=
 =?us-ascii?Q?H0VS9UcjXiPbIZk/ymiI+oc1TyR59NxKZg+IfayNZJcphByt/cuPR38dOtYV?=
 =?us-ascii?Q?cgoG7FexRloG8Klkm41rQX3zam0PGeew/csGxCLzry5tRGZtoB2nHQgt1m1+?=
 =?us-ascii?Q?2wIgjOep4zowfz9GsxgWp4M6VvU6XmKgrl5pTAcLAVaptykRj3sbSd28mJjc?=
 =?us-ascii?Q?rJXN8lMYc2scNWsjxpuWIWwBgaVNa9GVSCC7T3LPOdxFrGlmvUPanzOIm7BY?=
 =?us-ascii?Q?GYHOH/gWS5uR+mjsWkkd5YjveYMz6oZ/FPUZ5cc5K+vYPQhx6N+1s959LwUD?=
 =?us-ascii?Q?bMUOHVMePdIx4/rxaMPrxWW0/zdDkuh7HA/TtpuUUVDjKNSle2GApxs53opd?=
 =?us-ascii?Q?yLqyWVN2wFY71+yXSbT07VyTa5T+llXoYCp4RNhjMQTHE4g5w5S/cR0x90n4?=
 =?us-ascii?Q?xz1agacF5VAvJd00qbdZe3NzzB5YSus3mIURffHv63NXXqv1p/TMDiVoVf0y?=
 =?us-ascii?Q?/55t6RgsIqagqpnyT1/+/xCGMfgODtDodcWcrwtj9cyq2Sybzl43uqcGoeGq?=
 =?us-ascii?Q?DT5k83GfJ47jWzrOrjQiunac5qhuQGsHYo9eLKJk18e4MUTl5UhA7mqHhObe?=
 =?us-ascii?Q?vIdy0HbG1KUEEsf/VvVPITIFzr3UTRBFKf5KaBKhkHTP8QqQDxZL8CdI6UF2?=
 =?us-ascii?Q?bEzuy/aV4eZvT/1OQNabnFgL7myqx5qN7a+y+a0WCiCXJlNPPjickB3krdPA?=
 =?us-ascii?Q?8E95i0OquFTuoBR/78bKDA7a81AUmQBaD5lwXaau0JtyBWMq3Tc0TvG4NaiV?=
 =?us-ascii?Q?b6PKMuKYnaBj70iaC3T915+Nk72AEZqmr8lxSS+90nmjgK6oQAlTOruhzxzf?=
 =?us-ascii?Q?xiay0oMwk5y5ppoBfGKrjEG20E9zL3rFjr0uh3+8a88ABomYxQKMI42VuOU/?=
 =?us-ascii?Q?TkCEf9vLHkNC5QNLLanGCNDXCSXMtHTQWt6hyfosxpgjr1i9jXKXPqxkZrKC?=
 =?us-ascii?Q?hjcvFA6IU7N0C7JsxecvkkjQu5tpg+CXvMFg/aI1N9M5hlIp1gVJ3ABgOow/?=
 =?us-ascii?Q?a4go4fIHhpPqhMpTpCvbhY4ZB7gaVpFzTt09Tee3E4+W4MS6IQlW9agL6ome?=
 =?us-ascii?Q?53GekdYu8tsCQWTToYLrZB1hIWg0+ICCnfWDWExNeWOapqgHwNVq/hnatxJt?=
 =?us-ascii?Q?d3b4tTD5glvA8+puOys1JjnS+JJkTTltNq+EHZY6W1cxn+w0TpQYT7+AUNnL?=
 =?us-ascii?Q?3T/54ahjOr93SptN0V5XUmwuVIWsrlnIqFJBpaaA?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51a675ac-b11c-49fb-249a-08dab95df24c
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2022 03:30:37.4051
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UxQ0URJdbXV0hpBz6Oioh3nDZqKETN9AC7JA877RYub79543UPFCcDemN7aAD06Zp+/KgkhXbSNeWaD1AfjafA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6811
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Kees Cook
> Sent: Tuesday, October 18, 2022 2:55 PM
> To: Ruhl@www.outflux.net; Ruhl, Michael J <michael.j.ruhl@intel.com>
> Cc: Kees Cook <keescook@chromium.org>; intel-wired-lan@lists.osuosl.org;
> linux-kernel@vger.kernel.org; Eric Dumazet <edumazet@google.com>;
> linux-hardening@vger.kernel.org; netdev@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller
> <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH v3 2/2] igb: Proactively round up to km=
alloc
> bucket size
>=20
> In preparation for removing the "silently change allocation size"
> users of ksize(), explicitly round up all q_vector allocations so that al=
locations
> can be correctly compared to ksize().
>=20
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)