Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fdc98171-e764-5be2-69ed-4395b13c06fe@marcan.st>
Date:   Sat, 29 Oct 2022 15:25:30 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Sasha Finkelstein <fnkl.kernel@gmail.com>
Cc:     thierry.reding@gmail.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, sven@svenpeter.dev,
        alyssa@rosenzweig.io, asahi@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221028165215.43662-1-fnkl.kernel@gmail.com>
 <20221028165215.43662-3-fnkl.kernel@gmail.com>
 <02523fe5-bf99-9891-d00c-347893d5dabe@linaro.org>
 <CAMT+MTTE84XDf8c0D3MLxZ92HiDP6DhXfpHVyQZ7hfYMUkL7dg@mail.gmail.com>
 <3b8441da-31af-2414-1362-0efb05cbf8c0@linaro.org>
From:   Hector Martin <marcan@marcan.st>
Subject: Re: [PATCH 2/4] pwm: Add Apple PWM controller
In-Reply-To: <3b8441da-31af-2414-1362-0efb05cbf8c0@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 29/10/2022 04.49, Krzysztof Kozlowski wrote:
> On 28/10/2022 14:51, Sasha Finkelstein wrote:
>> On Fri, 28 Oct 2022 at 20:54, Krzysztof Kozlowski
>> <krzysztof.kozlowski@linaro.org> wrote:
>>>
>>> On 28/10/2022 12:52, Sasha Finkelstein wrote:
>>>> +config PWM_APPLE
>>>> +     tristate "Apple SoC PWM support"
>>>> +     depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)
>>>
>>> Why this code cannot be build on 32-bit?
>> It uses 64-bit divisions, which causes it to fail to build on 32-bit
>> mips. It should not be a
>> problem, since this hardware is only present on 64-bit SoCs.
> 
> Does not matter, code should be portable and buildable on 32-bit. If it
> does not build then your code is not correct.

This statement does not apply in general. There are plenty of drivers
which cannot reasonably build for 32-bit, and make no sense because no
32-bit hardware exists that could use them. Examples include anything
that accesses 64-bit registers on 64-bit SoCs the normal way, and
further anything that touches CPU stuff like system registers.

In *this* case, if the only issue is some 64-bit math, then yes, it
should be made to build on 32-bit (especially since this is likely to
also work for older 32-bit Apple SoCs). But the (COMPILE_TEST && 64BIT)
pattern is definitely valid in other cases, and I've been adding it
lately to shut up the kernel test bot since it makes no sense to compile
test a whole pile of our drivers on 32-bit architectures - they
fundamentally can't compile without adding pointless hypothetical broken
fluff to the driver like split MMIO accesses (which often can't work on
real hardware), and it serves no purpose.


- Hector