Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221028003128.514318-1-shaneparslow808@gmail.com>
 <CAMZdPi-tz4_vxum8SYbYVuv71UYhe4QUGO6_w8TPFBcw9oydfQ@mail.gmail.com> <Y1wa1JR9URGCUo1P@arch-desk>
In-Reply-To: <Y1wa1JR9URGCUo1P@arch-desk>
From:   Loic Poulain <loic.poulain@linaro.org>
Date:   Sat, 29 Oct 2022 09:24:21 +0200
Message-ID: <CAMZdPi90KNu=J4spz0ggEqnCCOsdugW-oKau-govhpGx8sbCEw@mail.gmail.com>
Subject: Re: [PATCH net-next] net: wwan: iosm: add rpc interface for xmm modems
To:     Shane Parslow <shaneparslow808@gmail.com>
Cc:     m.chetan.kumar@intel.com, linuxwwan@intel.com,
        ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 28 Oct 2022 at 20:09, Shane Parslow <shaneparslow808@gmail.com> wrote:
>
> On Fri, Oct 28, 2022 at 12:35:01PM +0200, Loic Poulain wrote:
> > On Fri, 28 Oct 2022 at 02:37, Shane Parslow <shaneparslow808@gmail.com> wrote:
> > >
> > > Add a new iosm wwan port that connects to the modem rpc interface. This
> > > interface provides a configuration channel, and in the case of the 7360, is
> > > the only way to configure the modem (as it does not support mbim).
> >
> > Doesn't the AT channel offer that possibility? what is the status of
> > 7360 support without this change?
>
> Several initialization functions must be called through the RPC channel
> to bring up the 7360. Without this initialization the modem is not
> functional beyond responding to simple AT commands. After initialization
> through this interface the modem works as expected.

Ok, beyond xmm7360-pci project, it would be good to have this protocol
integrated into an existing modem manager.

>
> Because of this, the 7360 is currently nonfunctional beyond responding
> to a limited set of AT commands. As for the 7560, my understanding is that
> it is currently functional, and this interface simply supplements the MBIM
> interface.
>
> >
> > > The new interface is compatible with existing software, such as
> > > open_xdatachannel.py from the xmm7360-pci project [1].
> > >
> > > [1] https://github.com/xmm7360/xmm7360-pci
> > >
> > > Signed-off-by: Shane Parslow <shaneparslow808@gmail.com>
[...]
>
> Thanks for the feedback. Should I go ahead and submit a V2?

Yes, please.