Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <850085e1-e420-b6eb-104d-15694a400bb7@intel.com>
Date:   Sat, 29 Oct 2022 11:01:38 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v5] overflow: Introduce overflows_type() and
 castable_to_type()
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>
CC:     <arnd@kernel.org>, <mauro.chehab@linux.intel.com>,
        <tvrtko.ursulin@linux.intel.com>, <airlied@linux.ie>,
        <trix@redhat.com>, <dlatypov@google.com>, <llvm@lists.linux.dev>,
        <ndesaulniers@google.com>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>, <gustavoars@kernel.org>,
        <nathan@kernel.org>, <linux-sparse@vger.kernel.org>,
        <linux-hardening@vger.kernel.org>, <rodrigo.vivi@intel.com>,
        <mchehab@kernel.org>, <intel-gfx@lists.freedesktop.org>,
        <luc.vanoostenryck@gmail.com>, <vitor@massaru.org>
References: <20220926191109.1803094-1-keescook@chromium.org>
 <20221024201125.1416422-1-gwan-gyeong.mun@intel.com>
 <ffcfb7ce-7646-c827-8d29-7c41e4b121d6@intel.com>
 <202210290029.3CD089A86C@keescook>
From:   Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
In-Reply-To: <202210290029.3CD089A86C@keescook>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2hhWTAyaStiaG5lMG16QnNLYk5oNzBhZVdmOFBtd2FCckRyNG9GNldnajVJ?=
 =?utf-8?B?ZTJXbXo5RGxaMjFLVmJTeDZNZ2xjM3hCVS9CZW1BbEE4RFlGNDRhMHJ3V01D?=
 =?utf-8?B?RnhPZkNMMkFJcVg3ZWlvZ1JsYkh2WFdleUQ1dk1aTHVWQTdMa21vTWdsWms2?=
 =?utf-8?B?ZXpJOUltTTk1TXFUSzlwSHI1ais0enQ1TWNVYWorQlB4OU12YWt4aGVjbU9v?=
 =?utf-8?B?K1dDY2NobjBjbVlCK1hqMzFaV3VVdTFoZjdxbE5qcWJ3NHhtd1dMNGdxeld6?=
 =?utf-8?B?bHE0UWlRSHFOcUhrSFMxNElOVERFV2lENEs3M0RtR1prb2UralFmMUlPUHNJ?=
 =?utf-8?B?L2hGdHFzZ0g0OFAwbG1hYk40M1ZOYWtvK1JaQk1ac1RsNEczRXQ5c0hKcHlk?=
 =?utf-8?B?QmFYeWZNU2pWM25MWkFjMERMZG1aM29PaXBvOVhWU08yUXc4cjN0V2pwWk83?=
 =?utf-8?B?Qmh1TlFYL3RXcFpHMXdNR01BUDlUQk1YKzRqRUZqRkpPMUFKTDk2bHVBRndv?=
 =?utf-8?B?V3J6TXVkMVhTWEJrZmE5S2JVbGVBckZHMUN5VVlDTXZGNXlGWkZHNzFWc2hs?=
 =?utf-8?B?UW5YQ2dkREowbnJGRGJnUkJuSUZnZjRXVnZkcDFwMVZ4MmZ6R05DTjZuNE1G?=
 =?utf-8?B?TnhvMmM3MGx1NUxZMXNxMWRZV3FKVmdqWi9UclpkVnQrTVpWcVRMUEcxeWFE?=
 =?utf-8?B?SG91RUVNdy81SmlTQ0VjUkIxNEIrNUFvb1lyMWF2ZkJUSTEvcDRGcDhCaVpJ?=
 =?utf-8?B?a1hVZ0h3bmhwRHJpMVpHLy9tamlrOWJpYTJ6OG8zLzhncnJXREY0RTVGVkZx?=
 =?utf-8?B?YW44WXh0SW1yWW95NVFacWNyREd1NVUxeC9aQnhKclZ0WHFTZkF3TzFqeUM4?=
 =?utf-8?B?dmdpUk8xYmdpVytKcUlyYXdRNU9iVXlvZkQxSEtUajlReDVKeFRCM0FFQy9r?=
 =?utf-8?B?c3dZblJNWE5nNE1kTldpZDAvWERtbGJQbUpOUjBYMlViaG9tT29LQ1R2K3Fz?=
 =?utf-8?B?QnNUQWdSTXJ5OUhEd3RyU3hkdjJDU2NNVE14anhDKzhOeGpIUzhZbVB2UEhW?=
 =?utf-8?B?Yk9ETDhZOGZmYTRmdEt5bW9QeW45S3NWYlBTak01UmpiSklLQUNNUGVEVVRq?=
 =?utf-8?B?aW1iSWV6TUhMaTFGZTR1TW00L21OZGg3b1NCa2dBMkRpcUQ5S2JrdUIxKzls?=
 =?utf-8?B?VzBveEt5WUJXKzhjVHZ6eXhST0VKcnlZRDdNdzVMSFhhaEhVcGdBODJKNk5i?=
 =?utf-8?B?bmpPMWhlR2d5VXZLc2txaTYxZGlSWVBZTUVrN2VkVTl6clZqaGlXVjEzdVR5?=
 =?utf-8?B?dVJ5ekZWcWMzRUR2UGNuR3pkdTVBWk1KeE1vVEdqRkpwVFh6OFJZUHdmUWw0?=
 =?utf-8?B?SUpoWEhTNndNNW1pUEMzeXZRb0ZrOFF6ZjlWUVJhQ3dkcG5YWW1PK1AzQlJR?=
 =?utf-8?B?Z1Vid0ovMVBRMDZJeHZtYXFsWXIrejVhSU1VWFhGZlQwVjVoaEJxRzduaUJ1?=
 =?utf-8?B?Z3pOdThBamdUckw0OVdCYmFaVk8xL3BXbWNGU1B5VFRwMEZocStoVGFlY1E2?=
 =?utf-8?B?eWVWNFc0Q2Z6eUNPZkZveWtaRTdrWlNlNEp2S1drcllGTW9hUkJwd1JCQjQz?=
 =?utf-8?B?NkVmejgxU3pUVXNKeHJJdFZYR1FtNDE3WEFrdGtOWTFFTmR1RVNVRXRMb0pH?=
 =?utf-8?B?WDI4VGpnT3U4MWxxL1RFRy9GTSs2RVFWdHE3eFFrU0JNaXo0a1JmdTFLb3hI?=
 =?utf-8?B?eFNCVWoxdEl4dThNeWliYjlqNE1WWXBTQ3luUC92cDZ1Nkt0Sm1BbnFiZ0U2?=
 =?utf-8?B?RGN2azZrYVJ4a3pKa0F0YS9DYXBhTGJDL2l3QjhlcHdGTEdFMks4V1JxZE9I?=
 =?utf-8?B?c2c3MVhIbmVGUGU5YW9ETVZmNDMwUmZEbm9tUGtFdHBxZHplNFQzcXRaSis2?=
 =?utf-8?B?S2dsMFkraVBlcUZQcGpOazJ3Z2hQKy8rTlg5b3RXTUs4eDJobXFxdFdhakZu?=
 =?utf-8?B?N1VnalVJdmhLTzl0NDMzVDN2elh2NVY3Rk5MSXpzL0xVWHBweEQ0OWEvd3Ns?=
 =?utf-8?B?TElJelRFYnRnK0VoMzlVK0tFaFlFUnlFSkYzU1Q4bHNsWVNUZ2hpcnBOQ3dw?=
 =?utf-8?B?T2hnN1QwWDYwb2preUM1UUxJd2ZuUXZiTnRlNzJ3VzlLQ1RTK1NDTi9BUGZ6?=
 =?utf-8?B?Snc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d97c3ba-c39e-4801-96f5-08dab983eeba
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5409.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2022 08:02:32.7468
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9fyoW2rgfr8KTCTQdxpBRaMofTxjeCzh8GPxvlvVopEgeZhV52yKOouASNNCKcXDnD+Rk7JPYlJaBzpdt7zuxB5RA4IEx2ksVHCYz7ntJc0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5128
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/29/22 10:32 AM, Kees Cook wrote:
> On Sat, Oct 29, 2022 at 08:55:43AM +0300, Gwan-gyeong Mun wrote:
>> Hi Kees,
> 
> Hi! :)
> 
>> I've updated to v5 with the last comment of Nathan.
>> Could you please kindly review what more is needed as we move forward with
>> this patch?
> 
> It looks fine to me -- I assume it'll go via the drm tree? Would you
> rather I carry the non-drm changes in my tree instead?
> 
Hi!
Yes, I think it would be better to run this patch on your tree.
this patch moves the macro of i915 to overflows.h and modifies one part 
of drm's driver code, but I think this part can be easily applied when 
merging into the drm tree.

Many thanks,
G.G.
>>