Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0ea97349-afad-e0ab-09c7-f61c782555a0@os.amperecomputing.com>
Date:   Sat, 29 Oct 2022 15:49:24 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH -next v2] hwmon: (smpro-hwmon) Improve switch statments in
 smpro_is_visible()
Content-Language: en-CA
To:     Guenter Roeck <linux@roeck-us.net>,
        Nathan Chancellor <nathan@kernel.org>
Cc:     Jean Delvare <jdelvare@suse.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        patches@lists.linux.dev
References: <20221027231611.3824800-1-nathan@kernel.org>
 <20221028181430.GA2079477@roeck-us.net>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <20221028181430.GA2079477@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTgvMk1jTXdobkIzZms0WlJzay9pZjBSNVFseGRZSUVpL2tZM0diVWVIUVNk?=
 =?utf-8?B?Uzg4UzZtWEhiQVVPbVlHMjhEa1V0dWRnQk9Ba1FDMHdhc2xXcitvU0hjQXpK?=
 =?utf-8?B?RW14WFI5dWhwQktBNUJUeFRGeVlIaG5FTVNkZWt4cExvOStlOVpYTTVGb1c5?=
 =?utf-8?B?Y0lBRWNjdVRvUWJGclNxbW1wOThzTGJmUzdyUkkwSXFIRzM2MXNXakg2cjUx?=
 =?utf-8?B?RjhFUUc0OGhVRzQyb2JKbm9mSWFpMytRMUFITDdSSFBNZERmTlFGdXVYbzVa?=
 =?utf-8?B?cytnQ2lwNnVlR1ZEYkFmV1JNKzdjdmw4cUR5aHUrbE54cDB4YmFUQ0JyaFR2?=
 =?utf-8?B?MzBaWmcxQzRheVNCZjdQd241MlVMcDJlOTF2US9wajBkSzhxVTJvMHhUNzJ1?=
 =?utf-8?B?RmVmR3kxcW9wMmFUOGFhcnEzaGJVSDA5NFNBWXpnV1JsUFhPNTN1OE5FYmJI?=
 =?utf-8?B?aFdzVDM5bVc5RzhRNEZ1cHdJYlpWaWUxWitvU04rK3BsdUgwWXBpeTY4Y2hr?=
 =?utf-8?B?QzJ2WVp3a1lvV2N5eDR3aEVBRm42VVZWZXRhUFpIN3B5WmtrcmJIVTFLZEd5?=
 =?utf-8?B?bldNUitQUlBRUURUREx4NkUyWHpQNTBjOUFFMXJOb1p3YVpBYndiK2l2QmI2?=
 =?utf-8?B?aWJlTHVCeEdkZHV3NDZFNlVQaHZPN3hRTTFkRWRDVnFjSzdydVJHeEJWQU9G?=
 =?utf-8?B?aGloUUc2WmgyR0lkOVdtUXUwT1RHYk1PNVVwWlpITG1OdFprRk5ETmlVRWVh?=
 =?utf-8?B?UWx3MHQ2aVg5VzgydmlpYmVDUlZaYUpYV1RtQkpJNHlOTVVaWGdEeEdsTmk1?=
 =?utf-8?B?VENRSnhqSlZURllmc21JL2NZS1JxcFhpT29uS0ViRisyTjBoV3Q1QzJvZjFP?=
 =?utf-8?B?aVc4aVFQVjJnQm42SUl1ZDUveXliNHByN0xXSzg3Z3NuOW9jZlQ5aVliVEp1?=
 =?utf-8?B?WWp0cVhXSitHVXEwemttbXRpTnhWUmNhM0hnSzZ0a3pmTmtOMTZzU2NIY1hp?=
 =?utf-8?B?OUhVOUFpYWdKMG9hN1pqQWcvMlRHcnI0bDNCV2hyWVQ3dUxsRk5iMVJPT0dL?=
 =?utf-8?B?OTY1c3YvWHUrL1VMTHZDcmxOckloY2l1M2VrZis3UFFkaDFKRGloUlVKaCtT?=
 =?utf-8?B?Rkgrc2tSZjN3Z0xZdmNqME9rVVNyK2lqODRlSWN6WUxQdE40dUVTNmgvVzU2?=
 =?utf-8?B?Ynh4R04vL2huOWI1UnVYOVpobW5XT2pueklOOFVPRy9UMzBGNEQrM2V4YWVw?=
 =?utf-8?B?bWJOMTk5QXVxWGRUTzl1YTJwa3ZadXJZYkZCSXFlbTBtSFRma1pxaWhOdFZX?=
 =?utf-8?B?K0JuNWovZUFzd3UrUHo1TGF2MlRwS0k4cnJyS1F5YWNnUGFpSE85T00xeFcx?=
 =?utf-8?B?ZVhFVFVxNnVDRmlQUHBQUFIrZHo5dHJkWWhzelN5WDZpeGo5S3ppTlRtemM2?=
 =?utf-8?B?MmdLb25yNnFCSTFoeitkRGh3UXU2NVVrUVFMckhIMWlzZ2wvM3JaNG9sdFBn?=
 =?utf-8?B?S2o1NE14ekN1amZnNHN1RnljRC9uV1JkNUpWV2V0SnVKMXFJdlVFTThJakdS?=
 =?utf-8?B?Ujk2Ujk0bmp1ZktrS2hBWmRWelhhaWp1eThDOWtSSFB1SHFiRmEwNW8zdkNS?=
 =?utf-8?B?Ris4TEZjV3hwUm82bmNVRlA4ZTdDMkpsRUZVbk0xenIxemtSeTZWeXpNSXRE?=
 =?utf-8?B?V1BjV3JyL2NpRXpqOWhKSVpDTmpwYmo0L1FWOGpjSG5EaWdrTW5zSkNmMDR3?=
 =?utf-8?B?UmZ2SERkU2N4T0ViekRxQ2tIMU5IWU9NTGFYNUxtaXR1bDV3dTJkd3dnbHpX?=
 =?utf-8?B?RXBENEJwRDNOTjBEVTZndFNqUUFuUTZZRmNFWjZaK21xNWVVMTRZSXJpTFlN?=
 =?utf-8?B?MGVuSUFFckxYOEdPVk0zbWEzQ1BCakUrbHh6SEQvK0lvN0w4WjdES1hEWWox?=
 =?utf-8?B?T0V2VU9WZTArL0doeTZ5VjVwRkZsWFBrYStuVEkzRWZOeVk0NEwyOUxPQml2?=
 =?utf-8?B?Zms0OHlrVlFiT0doNVg1WEIrbDY0cmFCWTlzd1ZqUzk0dE84a0lnYlRDN1Qw?=
 =?utf-8?B?RGY0WVE5b0xDNkUxeGNoU2NqU0ozY29uM0owYW5XVkp4WkFRN3I4dUkyb21T?=
 =?utf-8?B?aTM0YmUzY0hWNXhrd3pOcm55NlVCdmdUUmVpVm9qbW5RcWllVVJmaEZLNEV4?=
 =?utf-8?Q?Nm7xfzXsmmJXHf4bpg9hpcA=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf73794a-ca7a-498a-3cfa-08dab98a8567
X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2022 08:49:42.2526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aQJEOmV5BnFswUZtxDzkMWZrgQ3JsSScHhRSWOXlFMfoVQjU1jZ2cJw6u1eLDXpeDrhWKX4okXW3Z/SUAFgZcdAHkMVR0GZVIpgmffuzQOE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR01MB2208
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks Nathan for the fix.
- Quan

On 29/10/2022 01:14, Guenter Roeck wrote:
> On Thu, Oct 27, 2022 at 04:16:12PM -0700, Nathan Chancellor wrote:
>> Clang warns:
>>
>>    drivers/hwmon/smpro-hwmon.c:378:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
>>            default:
>>            ^
>>    drivers/hwmon/smpro-hwmon.c:378:2: note: insert 'break;' to avoid fall-through
>>            default:
>>            ^
>>            break;
>>    1 error generated.
>>
>> Clang is a little more pedantic than GCC, which does not warn when
>> falling through to a case that is just break or return. Clang's version
>> is more in line with the kernel's own stance in deprecated.rst, which
>> states that all switch/case blocks must end in either break,
>> fallthrough, continue, goto, or return.
>>
>> Add the missing break to silence the warning. Additionally, adjust the
>> indentation of a break and add a default case to the inner switch
>> statement.
>>
>> Fixes: a87456864cbb ("hwmon: Add Ampere's Altra smpro-hwmon driver")
>> Link: https://github.com/ClangBuiltLinux/linux/issues/1751
>> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> 
> Applied.
> 
> Thanks,
> Guenter
> 
>> ---
>>
>> v2:
>>
>>      * Add missing default case to inner switch statement (Guenter)
>>      * Fix indentation of break in inner switch statement (Guenter)
>>      * Reword commit message to include these changes
>>
>> v1: https://lore.kernel.org/20221027195238.1789586-1-nathan@kernel.org/
>>
>>   drivers/hwmon/smpro-hwmon.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>>
>> base-commit: 0ffb687b6508c36a17b99bdaf014b38532404182
>>
>> diff --git a/drivers/hwmon/smpro-hwmon.c b/drivers/hwmon/smpro-hwmon.c
>> index ee54e21c2c12..a76c49dd8438 100644
>> --- a/drivers/hwmon/smpro-hwmon.c
>> +++ b/drivers/hwmon/smpro-hwmon.c
>> @@ -373,8 +373,11 @@ static umode_t smpro_is_visible(const void *data, enum hwmon_sensor_types type,
>>   			ret = regmap_read(hwmon->regmap, temperature[channel].reg, &value);
>>   			if (ret || value == 0xFFFF)
>>   				return 0;
>> -		break;
>> +			break;
>> +		default:
>> +			break;
>>   		}
>> +		break;
>>   	default:
>>   		break;
>>   	}