Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Julia Lawall' <julia.lawall@inria.fr>,
        UMWARI JOVIAL <umwarijovial@gmail.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "outreachy@lists.linux.dev" <outreachy@lists.linux.dev>
Subject: RE: [PATCH] Remove Unnecessary typecast of c90 int constant
Thread-Topic: [PATCH] Remove Unnecessary typecast of c90 int constant
Thread-Index: AQHY6p4QqXp6c6aJbUmajhb1BaK9064lOaUg
Date:   Sat, 29 Oct 2022 11:15:27 +0000
Message-ID: <aca0b365ab6b46789fd20dec14454ad6@AcuMS.aculab.com>
References: <20221028063711.GA35659@rdm>
 <alpine.DEB.2.22.394.2210280918550.2845@hadrien>
In-Reply-To: <alpine.DEB.2.22.394.2210280918550.2845@hadrien>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Julia Lawall
> Sent: 28 October 2022 08:23
> 
> On Fri, 28 Oct 2022, UMWARI JOVIAL wrote:
> 
> > According to Linux kernel coding style.
> >
> > Reported by checkpatch:
> > WARNING: Unnecessary typecast of c90 int constant - '(int)2.412e8' could be '2.412e8'
> > WARNING: Unnecessary typecast of c90 int constant - '(int)2.487e8' could be '2.487e8'
> 
> It's not ideal to just include the checkpatch messges verbatim in your log
> message.  It woudl be better to say what you are doing and why, in
> complete sentences ("According to the Linux coding style" is not a
> complete sentence).
> 
> I also suspect that the checkpatch message is wrong.  Floating point
> numbers cannot be used in the kernel, and the case of the constant ensures
> that the value will be converted to an integer at compile time.

Much better to just use 241200000u (or 241200u * 1000 for readability).

	David

> 
> julia
> 
> >
> > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
> > ---
> >  drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > index fdf867a5dd7a..4fc4fb25d8d6 100644
> > --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > @@ -41,8 +41,8 @@ int rtllib_wx_set_freq(struct rtllib_device *ieee, struct iw_request_info *a,
> >
> >  	/* if setting by freq convert to channel */
> >  	if (fwrq->e == 1) {
> > -		if ((fwrq->m >= (int)2.412e8 &&
> > -		     fwrq->m <= (int)2.487e8)) {
> > +		if ((fwrq->m >= 2.412e8 &&
> > +		     fwrq->m <= 2.487e8)) {
> >  			int f = fwrq->m / 100000;
> >  			int c = 0;
> >
> > --
> > 2.25.1
> >
> >
> >

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)