Received: by 2002:a05:6358:795:b0:dc:4c66:fc3e with SMTP id n21csp475492rwj; Sat, 29 Oct 2022 06:12:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7s/btOLFs/JOjg3i4+t2unjydvyWvtT2+seY/cEMG2g/6q15FfMI/IcnZDbohDtvWB2Ej8 X-Received: by 2002:a63:da43:0:b0:46f:9193:466b with SMTP id l3-20020a63da43000000b0046f9193466bmr1011665pgj.419.1667049122122; Sat, 29 Oct 2022 06:12:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667049122; cv=none; d=google.com; s=arc-20160816; b=M+BvhmmvRvgIzhsUXOBllYAoTATbhMoQkRCOI0RgjBxucAAuIJPFH+fx9kjeLSgy+G 6KhnWCPV7IUht0vdR8mjzthVHUJR1/w2H98mWSglI1L5x7Oyu1GYw/KD+fQKfbOyeFBo KtiVBKZMZlbQGtjfflleFEaoeofoMPS0hB3S9d3YNtqEJZUsqa1kE7OeyIPubbStjC8R azdZaUPRHwa73dFujI4qYjG01u3u38oWgNPSCPrR7m8xFZ7efU2SWE8WAIbH4Ty6OQtM u1VNjPA3pJNTUb8vtzaGon1djatgn8kF2yRw+LtKidc/uRFv3CoTgghXeIGWxeY1CWs/ jM9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CHFRbCsmJ3dVyk9/s6K6EIrz1SwWtm0J274pFVZQ86c=; b=U4n2AD/KU1H1R/qDyLgItbT9vXgaUjePgPYQkIxCUcC5B5MVEErXtA3KPpsJlXivxP Q/55+RYhg1goU7kHAS4UfjFH8w1mAccs8ZAln3jPjUYpZvw/aHqyXKOSA85yoymcbRHX hTAX7h2nYx2V6OOMxa+PtzKJk8enjzXMPcAnt2WollZuKjTrMfEIVqsbq7ew8t6DeXCw UdFEgTqIPYSlybOSWQK6PbTy/OcDClIv3f0bZKU7oVaN+vjiayzJgLCzpzjer3g6CyRR lsXtGtDqK1iVODb+GbKtmzEQvX+jJ3zfjrPd/6DGvf60AfBXvpT0EAOuLaSvgB+6lzvh 4+ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w200-20020a627bd1000000b0056bc64d158csi1861789pfc.172.2022.10.29.06.11.50; Sat, 29 Oct 2022 06:12:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229729AbiJ2NBA (ORCPT + 99 others); Sat, 29 Oct 2022 09:01:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbiJ2NA6 (ORCPT ); Sat, 29 Oct 2022 09:00:58 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B45A6266F for ; Sat, 29 Oct 2022 06:00:55 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oolSF-0006ID-3J; Sat, 29 Oct 2022 15:00:51 +0200 From: Heiko Stuebner To: Ondrej Jirman , linux-rockchip@lists.infradead.org Cc: Heiko Stuebner , "open list:DRM DRIVERS FOR ROCKCHIP" , Chris Morgan , Daniel Vetter , open list , Sandy Huang , "moderated list:ARM/Rockchip SoC support" , David Airlie Subject: Re: [PATCH] drm/rockchip: dsi: Fix VOP selection on SoCs that support it Date: Sat, 29 Oct 2022 15:00:47 +0200 Message-Id: <166704843774.1532410.10169614627003469571.b4-ty@sntech.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221023160747.607943-1-megi@xff.cz> References: <20221023160747.607943-1-megi@xff.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS, T_SPF_HELO_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 23 Oct 2022 18:07:47 +0200, Ondrej Jirman wrote: > lcdsel_grf_reg is defined as u32, so "< 0" comaprison is always false, > which breaks VOP selection on eg. RK3399. Compare against 0. > > Applied, thanks! [1/1] drm/rockchip: dsi: Fix VOP selection on SoCs that support it commit: 553c5a429aee26c9cfaf37ae158a8915540270fe Best regards, -- Heiko Stuebner