Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Heiko Stuebner <heiko@sntech.de>
To:     John Keeping <john@metanate.com>, dri-devel@lists.freedesktop.org
Cc:     Heiko Stuebner <heiko@sntech.de>,
        linux-arm-kernel@lists.infradead.org,
        Daniel Vetter <daniel@ffwll.ch>,
        Johan Jonker <jbx6244@gmail.com>,
        linux-rockchip@lists.infradead.org,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Sandy Huang <hjc@rock-chips.com>, linux-kernel@vger.kernel.org,
        David Airlie <airlied@gmail.com>
Subject: Re: [PATCH] drm/rockchip: fix fbdev on non-IOMMU devices
Date:   Sat, 29 Oct 2022 15:00:46 +0200
Message-Id: <166704843772.1532410.11915201216204142960.b4-ty@sntech.de>
In-Reply-To: <20221020181248.2497065-1-john@metanate.com>
References: <20221020181248.2497065-1-john@metanate.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 20 Oct 2022 19:12:47 +0100, John Keeping wrote:
> When switching to the generic fbdev infrastructure, it was missed that
> framebuffers were created with the alloc_kmap parameter to
> rockchip_gem_create_object() set to true.  The generic infrastructure
> calls this via the .dumb_create() driver operation and thus creates a
> buffer without an associated kmap.
> 
> alloc_kmap only makes a difference on devices without an IOMMU, but when
> it is missing rockchip_gem_prime_vmap() fails and the framebuffer cannot
> be used.
> 
> [...]

Applied, thanks!

[1/1] drm/rockchip: fix fbdev on non-IOMMU devices
      commit: ab78c74cfc5a3caa2bbb7627cb8f3bca40bb5fb0

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>