Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 29 Oct 2022 20:35:49 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Mukesh Ojha <quic_mojha@quicinc.com>
Cc:     catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
        broonie@kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: entry: Fix typo
Message-ID: <Y10sNSE6/B2p95+I@debian.me>
References: <1667027268-1255-1-git-send-email-quic_mojha@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="jd+hTkK2iZEDLYlo"
Content-Disposition: inline
In-Reply-To: <1667027268-1255-1-git-send-email-quic_mojha@quicinc.com>
Precedence: bulk


--jd+hTkK2iZEDLYlo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 29, 2022 at 12:37:48PM +0530, Mukesh Ojha wrote:
> diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-c=
ommon.c
> index 9173fad..b694d8f 100644
> --- a/arch/arm64/kernel/entry-common.c
> +++ b/arch/arm64/kernel/entry-common.c
> @@ -30,7 +30,7 @@
>  /*
>   * Handle IRQ/context state management when entering from kernel mode.
>   * Before this function is called it is not safe to call regular kernel =
code,
> - * intrumentable code, or any code which may trigger an exception.
> + * instrumentable code, or any code which may trigger an exception.
>   *
>   * This is intended to match the logic in irqentry_enter(), handling the=
 kernel
>   * mode transitions only.
> @@ -63,7 +63,7 @@ static void noinstr enter_from_kernel_mode(struct pt_re=
gs *regs)
>  /*
>   * Handle IRQ/context state management when exiting to kernel mode.
>   * After this function returns it is not safe to call regular kernel cod=
e,
> - * intrumentable code, or any code which may trigger an exception.
> + * instrumentable code, or any code which may trigger an exception.
>   *
>   * This is intended to match the logic in irqentry_exit(), handling the =
kernel
>   * mode transitions only, and with preemption handled elsewhere.
> @@ -97,7 +97,7 @@ static void noinstr exit_to_kernel_mode(struct pt_regs =
*regs)
>  /*
>   * Handle IRQ/context state management when entering from user mode.
>   * Before this function is called it is not safe to call regular kernel =
code,
> - * intrumentable code, or any code which may trigger an exception.
> + * instrumentable code, or any code which may trigger an exception.
>   */
>  static __always_inline void __enter_from_user_mode(void)
>  {
> @@ -116,7 +116,7 @@ static __always_inline void enter_from_user_mode(stru=
ct pt_regs *regs)
>  /*
>   * Handle IRQ/context state management when exiting to user mode.
>   * After this function returns it is not safe to call regular kernel cod=
e,
> - * intrumentable code, or any code which may trigger an exception.
> + * instrumentable code, or any code which may trigger an exception.
>   */
>  static __always_inline void __exit_to_user_mode(void)
>  {
> @@ -152,7 +152,7 @@ asmlinkage void noinstr asm_exit_to_user_mode(struct =
pt_regs *regs)
>  /*
>   * Handle IRQ/context state management when entering an NMI from user/ke=
rnel
>   * mode. Before this function is called it is not safe to call regular k=
ernel
> - * code, intrumentable code, or any code which may trigger an exception.
> + * code, instrumentable code, or any code which may trigger an exception.
>   */
>  static void noinstr arm64_enter_nmi(struct pt_regs *regs)
>  {
> @@ -170,7 +170,7 @@ static void noinstr arm64_enter_nmi(struct pt_regs *r=
egs)
>  /*
>   * Handle IRQ/context state management when exiting an NMI from user/ker=
nel
>   * mode. After this function returns it is not safe to call regular kern=
el
> - * code, intrumentable code, or any code which may trigger an exception.
> + * code, instrumentable code, or any code which may trigger an exception.
>   */
>  static void noinstr arm64_exit_nmi(struct pt_regs *regs)
>  {
> @@ -192,7 +192,7 @@ static void noinstr arm64_exit_nmi(struct pt_regs *re=
gs)
>  /*
>   * Handle IRQ/context state management when entering a debug exception f=
rom
>   * kernel mode. Before this function is called it is not safe to call re=
gular
> - * kernel code, intrumentable code, or any code which may trigger an exc=
eption.
> + * kernel code, instrumentable code, or any code which may trigger an ex=
ception.
>   */
>  static void noinstr arm64_enter_el1_dbg(struct pt_regs *regs)
>  {
> @@ -207,7 +207,7 @@ static void noinstr arm64_enter_el1_dbg(struct pt_reg=
s *regs)
>  /*
>   * Handle IRQ/context state management when exiting a debug exception fr=
om
>   * kernel mode. After this function returns it is not safe to call regul=
ar
> - * kernel code, intrumentable code, or any code which may trigger an exc=
eption.
> + * kernel code, instrumentable code, or any code which may trigger an ex=
ception.
>   */
>  static void noinstr arm64_exit_el1_dbg(struct pt_regs *regs)
>  {

What about "... it is unsafe to call regular kernel, instrumentable, or
any other code ..." instead?

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--jd+hTkK2iZEDLYlo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY10sMgAKCRD2uYlJVVFO
o2znAQDROD4B4MW/h2UtIpvM/S8ULS2o+L+Q6c5XC6UzJV6Y8gEA/or0r7pjXDwN
IfH5LgYp0u+3xs/bzhUc3SakWtYtKgA=
=mREl
-----END PGP SIGNATURE-----

--jd+hTkK2iZEDLYlo--