Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6e5b1e5e-b10c-2a7f-7b32-c603db423f25@somainline.org>
Date:   Sat, 29 Oct 2022 16:17:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v2 05/12] arm64: dts: qcom: sc8280xp-pmics: Add PMK8280
 ADC7 block
Content-Language: en-US
From:   Konrad Dybcio <konrad.dybcio@somainline.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        andersson@kernel.org
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        johan+linaro@kernel.org, quic_jprakash@quicinc.com,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, steev@kali.org
References: <20221029051449.30678-1-manivannan.sadhasivam@linaro.org>
 <20221029051449.30678-6-manivannan.sadhasivam@linaro.org>
 <2842a802-3f5a-7f28-5e81-b46d7a3abca5@somainline.org>
In-Reply-To: <2842a802-3f5a-7f28-5e81-b46d7a3abca5@somainline.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 29.10.2022 16:15, Konrad Dybcio wrote:
> 
> 
> On 29.10.2022 07:14, Manivannan Sadhasivam wrote:
>> Add support for ADC7 block available in PMK8280 for reading the
>> temperature via the AMUX pins.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
>> index 4a3464f5e6e9..3c56e4cb5b5b 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
>> @@ -75,6 +75,15 @@ pmk8280_pon_resin: resin {
>>  				status = "disabled";
>>  			};
>>  		};
>> +
>> +		pmk8280_vadc: adc@3100 {
>> +			compatible = "qcom,spmi-adc7";
>> +			reg = <0x3100>;
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>> +			#io-channel-cells = <1>;
> Maybe having interrupts after reg and all the -cells below that would look better.
> 
> For the contents though:
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> 
> Konrad
Sorry for double noise, I just noticed you didn't disable this by default. Was that intended?

Konrad
>> +		};
>>  	};
>>  
>>  	pmc8280_1: pmic@1 {