Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bc8cf710-c0ad-24e8-7849-6282c8e3bcff@acm.org>
Date:   Sat, 29 Oct 2022 20:33:22 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v2] block: simplify blksize_bits() implementation
Content-Language: en-US
To:     Dawei Li <set_pte_at@outlook.com>
Cc:     axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <TYCP286MB232371C798BE0500E979E24CCA349@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
 <8ccaabc1-2834-dad6-7d46-19bfc2adcc9a@acm.org>
 <TYCP286MB23234B5C344600A604B17242CA349@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <TYCP286MB23234B5C344600A604B17242CA349@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/29/22 20:25, Dawei Li wrote:
> On Sat, Oct 29, 2022 at 08:00:58PM -0700, Bart Van Assche wrote:
>> On 10/29/22 19:17, Dawei Li wrote:
>>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
>>> index 57ed49f20d2e..7b537afe8b38 100644
>>> --- a/include/linux/blkdev.h
>>> +++ b/include/linux/blkdev.h
>>> @@ -1349,12 +1349,7 @@ static inline int blk_rq_aligned(struct request_queue *q, unsigned long addr,
>>>    /* assumes size > 256 */
>>>    static inline unsigned int blksize_bits(unsigned int size)
>>>    {
>>> -	unsigned int bits = 8;
>>> -	do {
>>> -		bits++;
>>> -		size >>= 1;
>>> -	} while (size > 256);
>>> -	return bits;
>>> +	return order_base_2((size + SECTOR_SIZE - 1) >> SECTOR_SHIFT) + SECTOR_SHIFT;
>>>    }
>>
>> Why the rounding ("+ SECTOR_SIZE - 1")? The blksize_bits() argument should
>> be an argument of two.
> 
> Yeah, that's what's supposed to be.
> But I thought maybe a "just in case" is more robust?
> Should we consider these corner cases(!is_power_of_2())?

I don't think that the Linux kernel supports block sizes that are not a 
power of two. Hence my request to leave out the rounding code. Keeping 
that code would be misleading because it would suggest that the 
blksize_bits() argument can be something else than a power of two.

Thanks,

Bart.