MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@elte.hu>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kill an obsolete sub-thread-ptrace stuff
In-Reply-To: Oleg Nesterov's message of  Saturday, 4 August 2007 01:04:41 +0400 <20070803210441.GA247@tv-sign.ru>
Message-Id: <20070803215101.481DD4D04BC@magilla.localdomain>
Date: Fri,  3 Aug 2007 14:51:01 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 834
Lines: 21

> There is a couple of subtle checks which were needed to handle ptracing from
> the same thread group. This was deprecated a long ago, imho this code just
> complicates the understanding.

Looks ok to me.

> And, the "->parent->signal->flags & SIGNAL_GROUP_EXIT" check in exit_notify()
> is not right. SIGNAL_GROUP_EXIT can mean exec(), not exit_group(). This means
> ptracer can lose a ptraced zombie on exec(). Minor problem, but still the bug.

This bug never happens because this check is only in the now-impossible
ptrace-same-group case.  The code can certainly go.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/