Received: by 2002:a05:6358:795:b0:dc:4c66:fc3e with SMTP id n21csp1475915rwj; Sun, 30 Oct 2022 01:07:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4UAoPfKYNU1oKz2/1VvDaiSW0UK0XI1xK5SER7MvuMPF3/FIVLCIeaSHj+8AHifa4Qu/40 X-Received: by 2002:a05:6a00:e1b:b0:537:7c74:c405 with SMTP id bq27-20020a056a000e1b00b005377c74c405mr8007779pfb.43.1667117233485; Sun, 30 Oct 2022 01:07:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667117233; cv=none; d=google.com; s=arc-20160816; b=oJDx8xWjcMnfXarEoynTamFqLldPRR9hlCbmQS44GVjHrZEo0sE/Zei3U9TRbPAm90 zhiavu//uKlrgcaw387YlmNZqhXT+imQeLpG9YYOcQyNW6dcIiYHpm+VIJsUIT9y4gF1 UcoVHxSIJO/Faqm1zkjTcR2u/SHN2rUg4zZX8tXMZAA5zoJQxNwkRvV8W+dgg5lAWKvS b5RBCwrrTx0Dz59GtixxxhXTueFURunfuiWUqHI7rVt7FzofrOagbYO+YitoaTeMTlU1 AW20h/x1lWbkTo5/8Ye6W7fbOm4DrwDyzShSn2tp7Fx5Mm4/NayS1SPbBupy5SewWVZG CiAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=kgqhqTpvMc+cWiUwDXIS6sh/vvZeJN7EB9DwBD51KR4=; b=QLIU+i+7vtznaXxWe46Twrbp7FAwImZl57/jZtk4ODak7u4Zt0HNGXQbmtbAX/6a6t cVsEoX4MKAYRYjz0wqY+S/FVQv288T1g+QvVNom0PkWpGJDdq62kriaQdYlgREUUTvRm onuGk8NNj5kCOZmEgeNxqFWMr5ZLIAZlP7TLYkJVwiZyzWTDfdFFs3Vdi+4JNts1oNBr zofoNPSIdCxzNAxrVoCo774fiy258/qWzMtpMIh9y9Bf8CNYsQDkJlGEW07bv87rgQ33 1oivMMrRfGUYsLNqyjlK0D1P1WJcFB/gX0vGeqMaw3g3uRmperlcmV2pPbDcua1bLrYr Sxvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c1-20020a170902d48100b00179f69eae64si4764160plg.620.2022.10.30.01.07.02; Sun, 30 Oct 2022 01:07:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbiJ3Hg7 (ORCPT + 99 others); Sun, 30 Oct 2022 03:36:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbiJ3Hg5 (ORCPT ); Sun, 30 Oct 2022 03:36:57 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17FAD296; Sun, 30 Oct 2022 00:36:56 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 69D5168AA6; Sun, 30 Oct 2022 08:36:52 +0100 (CET) Date: Sun, 30 Oct 2022 08:36:52 +0100 From: Christoph Hellwig To: Dawei Li Cc: axboe@kernel.dk, bvanassche@acm.org, hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] block: simplify blksize_bits() implementation Message-ID: <20221030073651.GA4131@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'm not sure if it matters, but the change does look fine to me: Reviewed-by: Christoph Hellwig