Received: by 2002:a05:6358:795:b0:dc:4c66:fc3e with SMTP id n21csp1482799rwj; Sun, 30 Oct 2022 01:15:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6dUoBG2C+2NNiOw2n7lpZxqKT2xLPV2sPCsRyKOPlvvx0L1EAXS3cMuOOolyMJqiGqgoZ7 X-Received: by 2002:a17:90b:3705:b0:212:e2e5:c0c0 with SMTP id mg5-20020a17090b370500b00212e2e5c0c0mr8663730pjb.239.1667117703679; Sun, 30 Oct 2022 01:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667117703; cv=none; d=google.com; s=arc-20160816; b=j8ROCpg/ne4Ua4r8QRX/A5HIkF+h98kaabSOuMEHQno8U5pFVPlbhcgAig+mji57oJ pQk8oDlNvA1p/+88D56iG/VAp3PFaryZGNmF/KKYD1LV/Dt1jNs0XSGXxc/H2vUR8bAC 7GVuwaDnKkFdR+HI/fqlUPPG+C5vKyHHyqZWE2cDgDV7/Qo5srtuMrGsrMMdPHF3yoBb TPdvkrkCHxNCngjFintHHcwWRgfkJaHWfFswHPILD1BKIeoWXT8JiARS1Rna0sg4s0DD 6NHW52O7PUanbm0e9b9ufe9ZIjrefqtQrjdq59SR0WxuUIAnoJt8iFrwTUvQy+manUhO Op+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gJ98wxFzzxPUDc22OR9ASbqMHYFuqE9w1qyKDc06qr8=; b=BwUp4u96g3QLB9Ys6BGcsAy+jyHzCiRv168a8F9H2DGCfOMkp/TgiZtFR/3xFl5iyq fGK+XanXcfZTT4sjx9CL4MyGuSXtuo3rgU97b70aXYIue5HZ2BzulP7OY/YsrE5nIUtF igkR8JrKd4pYdvW8wHJFZRCjDYvzzZJpPfTFtvymMAhsD1jAKh39u9MmykRaTSSdzz4A 8CO+Lh6cr0t7pKRlF32Fk2UHdAs+plHwL5Nrg+x5Ws13NcGwQlluTyJSHTkpluOmLsQ+ lN29NsZyAMr/jsDzfNSU27er52DuYQS9cX6MWDxsdvfZQXqCuv6/PgpOmrAMGKWDpwk5 OHnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x26-20020a056a000bda00b00536fa6bbb11si3661529pfu.344.2022.10.30.01.14.52; Sun, 30 Oct 2022 01:15:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbiJ3IFt (ORCPT + 99 others); Sun, 30 Oct 2022 04:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbiJ3IFq (ORCPT ); Sun, 30 Oct 2022 04:05:46 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A577A640C; Sun, 30 Oct 2022 01:05:44 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 1527B68AA6; Sun, 30 Oct 2022 09:05:41 +0100 (CET) Date: Sun, 30 Oct 2022 09:05:40 +0100 From: Christoph Hellwig To: Alexey Kardashevskiy Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Ashish Kalra , Pankaj Gupta , Tom Lendacky , Robin Murphy , Marek Szyprowski , Christoph Hellwig Subject: Re: [PATCH kernel] x86/swiotlb/amd: Half the size if allocation failed Message-ID: <20221030080540.GH4214@lst.de> References: <20221027052607.260234-1-aik@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221027052607.260234-1-aik@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The subject looks wrong - this just touches the swiotlb code, and nothing x86 or AMD specific. The code flow now looks a little confusing. Can yu just add a little swiotlb_memblock_alloc helper that does the two variants of memblock allocation and remap, so that we can keep a simply loop around them in the caller?