Received: by 2002:a05:6358:795:b0:dc:4c66:fc3e with SMTP id n21csp1492691rwj; Sun, 30 Oct 2022 01:28:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6P0jLhRuazC0jsto/MvqL8JGJCIUxeEahDuyQuW6dBKjj6O4gq8Y20S7f0NoqiUTcHwlAe X-Received: by 2002:a05:6402:4511:b0:45c:b2b4:3e69 with SMTP id ez17-20020a056402451100b0045cb2b43e69mr7751157edb.339.1667118503452; Sun, 30 Oct 2022 01:28:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667118503; cv=none; d=google.com; s=arc-20160816; b=RFBeNj3b0gBdgQOetB8kvexFYVPa7rl7/V+fk87h8LJKwFUx5GWnTSpe9fzFRmSqg9 cjlkmUdwRcf2cNn8sN6wHWjhPOMSf0Z34D4n4Bv4bEmSQmTV7uC/84BUlQrZHW3O/NYU /31OBraNFgQyA4SHv5Px0CHopm0ZUQR4oGaZQ3Sy+ZwFSlHeiGiVlWH56MGt8mvsXpHr bmMk22iAXBMi6SG+IC3+j6H95ABRmwHwbSz1Yjznq9ccfpY+Dv2vx+CmCnl/bsZOidtk J8JvsbuwZigGhv1KF7OZKTZzvpIPkVu8yulpFSGvDFxjzWkoDmtqZcIfM4Ftt6WP2/48 mYKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qDxMZSkyyFWSUZLR/zgbATIw970wK8DPWliBx9KgMxU=; b=nRgCxgZQ8w0YVxg83swIu4qh1QmOoT3z6agLezF1N1a6MTX5D1FTODfmIPjmPI1q5M yiVzkRsCCZJeSo0F3h9B78UqciAkNxzAlmVXN4zZTfAA9/0mHv/1q6oSlsfA18uca5Uq mF64uziSblGlV/v5tZ0bxQJzUdD6KUOehknrNOUFHLlGj3Ct3LFYNSLvZthvJFTXZWxn by9V9TBXGlQJrzTonzmWUbBFe2KymO4RjxZDDmycl+cW9pVZCyC7JBhpgdb3629NEgU5 WGwQFgK7dYiR6PSwQGcGL2Dpo2reAhA4xIL82KWOHFXj38eUmUXszgJU0+5YSDLh8Fy2 6Tzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=I3h1LwtQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji17-20020a170907981100b0078b41dcf4b8si3163387ejc.479.2022.10.30.01.27.58; Sun, 30 Oct 2022 01:28:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=I3h1LwtQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbiJ3IN0 (ORCPT + 99 others); Sun, 30 Oct 2022 04:13:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbiJ3INY (ORCPT ); Sun, 30 Oct 2022 04:13:24 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B25C718B; Sun, 30 Oct 2022 01:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qDxMZSkyyFWSUZLR/zgbATIw970wK8DPWliBx9KgMxU=; b=I3h1LwtQTwdn70nvX8XupBOqlo KZZqvJTNMJuUYLS/stq2eRAL45oqsgygNvWAFl6dp5ytI5pawaMmrXNWcg8gzgnF6HfKbKAxmrKI/ cUo5UI43DFPCPWvXciTVXC7gM5xcpjWKlmKqEMDs3jaV9uGg7F2ZAo9GexG/79bAdWubiAHm3Wc0A uaVFC+7iphDXTdIyk2nQ0fgfMr+dCS8qdJFsNJHLoOk7crZaNgbyLoQ2reQ+iA/U2OjmiME8SG4Ii ZpaanpKLABFgOYIGnJxIRMG6nMJbx0X9CqHzvCdd1hxOA+gCV80iLHgnQZkWA9skhvcY7FfDLTc73 feU2CDeQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1op3RB-00E4vm-0j; Sun, 30 Oct 2022 08:12:57 +0000 Date: Sun, 30 Oct 2022 01:12:56 -0700 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , David Howells , willy@infradead.org, dchinner@redhat.com, Steve French , Shyam Prasad N , Rohith Surabattula , Jeff Layton , Ira Weiny , torvalds@linux-foundation.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/12] get rid of unlikely() on page_copy_sane() calls Message-ID: References: <20221028023352.3532080-1-viro@zeniv.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221028023352.3532080-1-viro@zeniv.linux.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This could explain why your are dropping the unlikely, 'cause just from the page this is non-obvious. Especially as the patch seems to do a lot more than just removing an unlikely.