Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bedb0125-fb81-56c3-4495-cbb942dc31ca@fujitsu.com>
Date:   Sun, 30 Oct 2022 16:08:39 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2] selftests: pidfd: Fix compling warnings
Content-Language: en-US
From:   Li Zhijian <lizhijian@fujitsu.com>
To:     <brauner@kernel.org>, <shuah@kernel.org>,
        <linux-kselftest@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>
References: <1662002254-7-1-git-send-email-lizhijian@fujitsu.com>
 <9052fe6c-6a56-8662-2747-9387447d11fa@fujitsu.com>
In-Reply-To: <9052fe6c-6a56-8662-2747-9387447d11fa@fujitsu.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

ping again


On 29/09/2022 08:55, Li Zhijian wrote:
> ping
>
> On 01/09/2022 11:17, Li Zhijian wrote:
>> Fix warnings and enable Wall.
>>
>> pidfd_wait.c: In function ‘wait_nonblock’:
>> pidfd_wait.c:150:13: warning: unused variable ‘status’ [-Wunused-variable]
>>    150 |  int pidfd, status = 0;
>>        |             ^~~~~~
>> ...
>> pidfd_test.c: In function ‘child_poll_exec_test’:
>> pidfd_test.c:438:1: warning: no return statement in function returning non-void [-Wreturn-type]
>>    438 | }
>>        | ^
>>
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>> v2: fix mistake assignment to pidfd
>> ---
>>   tools/testing/selftests/pidfd/Makefile     | 2 +-
>>   tools/testing/selftests/pidfd/pidfd_test.c | 2 ++
>>   tools/testing/selftests/pidfd/pidfd_wait.c | 2 +-
>>   3 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/pidfd/Makefile b/tools/testing/selftests/pidfd/Makefile
>> index f4a2f28f926b..778b6cdc8aed 100644
>> --- a/tools/testing/selftests/pidfd/Makefile
>> +++ b/tools/testing/selftests/pidfd/Makefile
>> @@ -1,5 +1,5 @@
>>   # SPDX-License-Identifier: GPL-2.0-only
>> -CFLAGS += -g -I../../../../usr/include/ -pthread
>> +CFLAGS += -g -I../../../../usr/include/ -pthread -Wall
>>     TEST_GEN_PROGS := pidfd_test pidfd_fdinfo_test pidfd_open_test \
>>       pidfd_poll_test pidfd_wait pidfd_getfd_test pidfd_setns_test
>> diff --git a/tools/testing/selftests/pidfd/pidfd_test.c b/tools/testing/selftests/pidfd/pidfd_test.c
>> index 9a2d64901d59..d36654265b7a 100644
>> --- a/tools/testing/selftests/pidfd/pidfd_test.c
>> +++ b/tools/testing/selftests/pidfd/pidfd_test.c
>> @@ -435,6 +435,8 @@ static int child_poll_exec_test(void *args)
>>        */
>>       while (1)
>>           sleep(1);
>> +
>> +    return 0;
>>   }
>>     static void test_pidfd_poll_exec(int use_waitpid)
>> diff --git a/tools/testing/selftests/pidfd/pidfd_wait.c b/tools/testing/selftests/pidfd/pidfd_wait.c
>> index c3e2a3041f55..0dcb8365ddc3 100644
>> --- a/tools/testing/selftests/pidfd/pidfd_wait.c
>> +++ b/tools/testing/selftests/pidfd/pidfd_wait.c
>> @@ -148,7 +148,7 @@ static int sys_waitid(int which, pid_t pid, siginfo_t *info, int options,
>>     TEST(wait_nonblock)
>>   {
>> -    int pidfd, status = 0;
>> +    int pidfd;
>>       unsigned int flags = 0;
>>       pid_t parent_tid = -1;
>>       struct clone_args args = {
>