Received: by 2002:a05:6358:795:b0:dc:4c66:fc3e with SMTP id n21csp1514134rwj; Sun, 30 Oct 2022 01:55:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6e/+x8wmyPoGJnsbcLAZ5y95Y8MSdD48YSYaAMt9hq8uVZFo+1Jzk33sClYOkn8P7jugMX X-Received: by 2002:a17:90b:1a8a:b0:213:20c:a427 with SMTP id ng10-20020a17090b1a8a00b00213020ca427mr8808184pjb.9.1667120107001; Sun, 30 Oct 2022 01:55:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667120106; cv=none; d=google.com; s=arc-20160816; b=JBapet5eu72x5WDqITGKxKTScv7rR3zgAmwHHBjho6qr9/hYbubOCSpQ5VTXewGrnR Gz7NFYFr4QC5tMIfz3R/AfEXOF2yXHnLUGywQ0MI/BUPTH4t0AXMDcK5okuYBPh+VECw aU7z5gzzTDRorqRbBpVHgE2V526CbE4QL5KHOyy1J/ctpCa30+Ye0iFM/6o6Sh1MEpF1 P+f3wrFJJ9yhqCjmw9ArkGDxSqTv2f0sS38GflMekolBnzwC+QhnYxpRTNJkCKpfUkXN VZaLezU/4mpmLNjupXTWNBAkiPaL0b1aQwkNGY7ARU0oS9tGvkxPTA0enY6UmLiggvXB FGAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=9EPnA/hq2EBkoehhwQO0BFN5Ap7Flc7aM1N6yawhBN8=; b=UxRrOKm/nGE7ZIWqAqLVG1KLnnf09NX/uKeAL9dWf8O6ljT2iyUb51ANDtuaAkDYEl WBV2NeGO5c5erQMbbo3+97J100md0xaku/pOhw//Mmulz4PzkD03f+ZyxjpuX1ZmTN3c ROuiw5S/IiCpq54AuVMCb7KC2u60KEEdpIGFBW7EmO6eYGfiz7HdgsrurQVvlIe4QN6L 8WnXhIqK+DPEYflB3tvuTaSsqTSufTsk61H/D97p7FuHZ5JkZfP0QTepPiY91gt+2kuJ DVU5tY3cgajk5bU9JUFBkNBg6aLKwiZT853sMRRbPfDl1UQVb3jgsNWwSdWgVDwPkPcN C0RA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b12-20020a170902d40c00b0017d2311af5dsi3620074ple.69.2022.10.30.01.54.24; Sun, 30 Oct 2022 01:55:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbiJ3IVh (ORCPT + 99 others); Sun, 30 Oct 2022 04:21:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbiJ3IVe (ORCPT ); Sun, 30 Oct 2022 04:21:34 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7AA3C0A; Sun, 30 Oct 2022 01:21:32 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 52D9768AA6; Sun, 30 Oct 2022 09:21:30 +0100 (CET) Date: Sun, 30 Oct 2022 09:21:30 +0100 From: Christoph Hellwig To: Jinlong Chen Cc: Christoph Hellwig , axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me, bvanassche@acm.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [RESEND PATCH v2 3/3] block: hide back blk_freeze_queue_start and export its blk-mq alias Message-ID: <20221030082130.GA4930@lst.de> References: <3f2b51cc7f5c21e49bfa089e594cb203a4015183.1667107410.git.nickyc975@zju.edu.cn> <20221030074010.GD4131@lst.de> <2671e78e.152908.18427f9be8d.Coremail.nickyc975@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2671e78e.152908.18427f9be8d.Coremail.nickyc975@zju.edu.cn> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 30, 2022 at 04:19:49PM +0800, Jinlong Chen wrote: > I agree that the freezing stuff (maybe also the quiescing stuff) should > move out of the mq namespace. If now is not the proper time, I'll leave > them alone. I'll resend patch 1 alone without the comment. The quiesce actually is entirely blk-mq specific, which just have some careless callers.