Received: by 2002:a05:6358:795:b0:dc:4c66:fc3e with SMTP id n21csp1557304rwj; Sun, 30 Oct 2022 02:44:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM57B32pdchDlLxZSQR9/kMV4B2WK9KB6QOn7WaHMiG6kXuOC6FFNqxiUCcWJzynTf6pPBG1 X-Received: by 2002:a17:907:75d0:b0:7ad:8a7a:1a53 with SMTP id jl16-20020a17090775d000b007ad8a7a1a53mr7332719ejc.47.1667123085106; Sun, 30 Oct 2022 02:44:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667123085; cv=none; d=google.com; s=arc-20160816; b=KmSjZSHslE3FN9iHuZJPXZhf95GXI6NDpic4mylnS5H4dKAhGQh9OC86U+GHscZLWe bTR9foSCqekXn+r0ieUhupBm333xivhnpy8xcldX4mob+pZMt7PZ5roCTWXmyTWocQK4 PB57wdK5FcMkLdc+1oyKE57i1lsaY/+wzeyGmy65McjdKzIwHTPbABDEULE1H/qC5CiW zlFubzHnlad1Cenrfdi6NGHjw5mZ9ndnUhywi4pHmrVTHUVbhWebwvJfurP2FukeGH9i 6j1JBwUwJ1zmObUgJSoZdT/KS/9GsMeTlbI1XRbYGzjubOyk6V2QaP6OT4zUy/a4rWln mp/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=ljnoEOnD6Ax3raDEJYe2I3ae2E1xGx0rypzA7RDDnmVC41Z9ey3F0DEFaTv+abyWXP YP0sd9W8kYWOtGTGjc5uZ3iaTBxEp3e2To4bUC94FhvqjZ1q4q6nEjYARrVW9SD+tZTT f7eup22Q4tx6R0BJkJIoAdg/NCHbhcPBPZ7qQl772XJVQn9aQlZFiBp7l8BeSsNCPD6w yikw6RmwsaLV73MtqdQeI0euGrTlH2Leg8ecmfeHJ07hJxGjdXTxfd4btUp9KOjgE5tW y0JwNhgclsHiz5Q8FkxGKjRyh3bzhjZp6/MB2o5h16NlPWSBQ5fYwDfvNjYAbBEAHKwH cQsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=WcJiU5X6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr7-20020a1709073f8700b007ada030c2e9si4864022ejc.944.2022.10.30.02.44.20; Sun, 30 Oct 2022 02:44:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=WcJiU5X6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229886AbiJ3JeJ (ORCPT + 99 others); Sun, 30 Oct 2022 05:34:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbiJ3JeI (ORCPT ); Sun, 30 Oct 2022 05:34:08 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B6C2C22; Sun, 30 Oct 2022 02:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=WcJiU5X6PvxdiZPJws4GoHmPGJ 31Q47DbjSIjWkG9ULGAOwaBGvgN/tGnUXBmHMaVZfY6AKb69ue3hAyBM1mILHfSfPH4hIBCpxvJQq 2/rMSIpi4NfxWn45M6NHlv6XNKMWuo+S+eWRZtYGvT7YERtUCKMogCiZo/vEB38UBGj4DokAh5NYn cqgmgTCRULL9i0lzm92sytat9EnFxbE8HyKzG83F/76A3bkWFB7fHgLmRqD8AUKkPEmSv3CutGPQt Ob4K5Nj1ONTLsevmR2jG62IM1mvAKxBhLOy/hfpoks2DXSamwNTAjwXutyhTnAy6OznWi99hL2dtW g3Ddijkw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1op4hj-00EsLR-LH; Sun, 30 Oct 2022 09:34:07 +0000 Date: Sun, 30 Oct 2022 02:34:07 -0700 From: Christoph Hellwig To: Chen Zhongjin Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk, mcgrof@kernel.org, hare@suse.de Subject: Re: [PATCH] block: Fix possible memory leak for rq_wb on add_disk failure Message-ID: References: <20221029071355.35462-1-chenzhongjin@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221029071355.35462-1-chenzhongjin@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig