Received: by 2002:a05:6358:795:b0:dc:4c66:fc3e with SMTP id n21csp1667909rwj; Sun, 30 Oct 2022 04:43:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5mue+yyIWSczN0lXKc3OXBVNz+8IhD07p8pjxiMQJDj1HSrBnKNYsbVHo7fpBOrUMFY2tG X-Received: by 2002:a65:6951:0:b0:42b:b13:b253 with SMTP id w17-20020a656951000000b0042b0b13b253mr8011200pgq.555.1667130210175; Sun, 30 Oct 2022 04:43:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667130210; cv=none; d=google.com; s=arc-20160816; b=nmUuHy/3rb58mNVAVpOgF5X0HIXFneKDu2lL+FDQHBtgCMfV1O/866UqFRVCj1wUJh 6Wzhpf4eb8rAIrsSYFEus3S591+k8YI582A99eWljqbK6hpYXeG2a6Z+ONcftRAv/0GS Tq4yYKYmszClven6jpCeQc1GlsZrupwwnK14WKjr5D50nZKLxhkPLt+vFHCy+eeJC1m6 O7RP6fDRyIrwWRs80WZ/Zxc2H4GlfRVZsYf/XUtG/8d/BtUPAwHxHcNMM7Y+8Sex1B48 Ky2usiU1yG9movEm0KSg5DrrV3qob9m8E4hDinXZqvpbM/Hj+Gr4IaLJKcfXJnVoh0B7 QG/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=fWh0jiw47wr5EpTblkOIk2Y0gZ5oFXjTyvGDtppfH6g=; b=hh5lM2dBY2CuGw9DQXLL7vdokWVGAQVTIEdmzI9j8PV+4le8rld1/P7dFu36ZydxlL P0HVk6UHDd2lQ8CVp52dASTD4S5GXVAR1sGh4/+9vbbODhh2FdsXI/9Cw1eqTW506LMv UN+5n/1RTnknhGrwtDnqKzLpGbLT7M/LoJDeKLdlaPWeVrX01hhtu5QlB/7vsSLUnQ4W rkxYvmLsSqVBs5Wqcxhk0rezdHq/9szKxfmORx6HUZAzAOaMCxXCn0zOYM//qkqBSplT Zeh3GFyuQMEIQ5Bf0WyLph8RZ/sM4kPYrDnj/7stsw8sQSobunut+4pt0hTjnYz04FrX uSyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RvdX4EeB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a170903234500b001869fd74e0csi5439044plh.311.2022.10.30.04.43.18; Sun, 30 Oct 2022 04:43:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RvdX4EeB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229932AbiJ3KkM (ORCPT + 99 others); Sun, 30 Oct 2022 06:40:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbiJ3KkJ (ORCPT ); Sun, 30 Oct 2022 06:40:09 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A370B7E7 for ; Sun, 30 Oct 2022 03:40:08 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id x2so13797472edd.2 for ; Sun, 30 Oct 2022 03:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fWh0jiw47wr5EpTblkOIk2Y0gZ5oFXjTyvGDtppfH6g=; b=RvdX4EeB4VauGLFSIqplc5pDhWhiZW2n2yUHMU9dsTSPAKV4OwnyOcHfzJkpYzk/nQ L6Zmdzi5HtlwmuQLHHZO8UnFuPMVaMEH38lYLXkky0MZO1Wg4Fy5Z6QI1X0Liubtb6ZC zOijB7Ogv8CM9UVlgkORYNbd/SqguGVSenqbTv4q8sbyRcDJzwqk8cGGhmj06UGHPVqE 1n5BecfsKoYGmXWdlMa/3lRY0vaithZyjpDW56YNP4ZJklpLU2aA7ZlT+5x63jr0C2iL hdyn62Y21IYQVATUdV+zPmZSQ1ANsRtIFDi8/XC4DJ3gTFTnGAc+NzFb7SsIiyWBVDxg Gbzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fWh0jiw47wr5EpTblkOIk2Y0gZ5oFXjTyvGDtppfH6g=; b=m+pAFagPCyLGwoHrcieE7Elx/bidrs/F5Niy+0wIWDD2x0QMN9HxidEyrEAZIA3X+d QT8L5llyKNug8kNy404+wM2Q7Dx+gtmc70815xhNXUcnalmWyhh9sYa/tf6mQ8Iis2Om gMi2wU47WEuTLf+LpYFWrZA2Cd1ROT7IIHZ7TcVr45OIbAtdUmCp5Q7lOYhkmcPRv0He 149WBrChWx3Hm6LzSBXB5wjKGpsdARq/V/d9P/Selkue7iQHg8XaUwkzlfHBbIgDaSWM 8LaKhX48uDA+LR0sV1hss9PGII6S+dviwS4E5EcaYPbG5T13kTvk13B5a83DfRP3a/I/ K+Cw== X-Gm-Message-State: ACrzQf1RaBMXz/HKms/Z2AtstMTArHRIiSf7/EsdVCcisotUb94/BY1n uraGIFGtCQ3/jR+Sdz9Bxdw= X-Received: by 2002:a05:6402:2989:b0:44e:90d0:b9ff with SMTP id eq9-20020a056402298900b0044e90d0b9ffmr8049193edb.110.1667126406972; Sun, 30 Oct 2022 03:40:06 -0700 (PDT) Received: from [192.168.1.102] (p57935738.dip0.t-ipconnect.de. [87.147.87.56]) by smtp.gmail.com with ESMTPSA id i2-20020aa7c9c2000000b00458947539desm1906119edt.78.2022.10.30.03.40.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Oct 2022 03:40:06 -0700 (PDT) Message-ID: Date: Sun, 30 Oct 2022 11:40:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 00/13] staging: r8188eu: clean up action frame handlers Content-Language: en-US To: Martin Kaiser , Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20221029172337.1574593-1-martin@kaiser.cx> From: Philipp Hortmann In-Reply-To: <20221029172337.1574593-1-martin@kaiser.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/22 19:23, Martin Kaiser wrote: > Clean up the handlers for action frames. Summarize common code, remove > unnecessary return values. > > Please apply this on top of the "remove the last get_da calls" series. > > Martin Kaiser (13): > staging: r8188eu: replace a GetAddr1Ptr call > staging: r8188eu: remove duplicate category check > staging: r8188eu: make on_action_public static void > staging: r8188eu: make OnAction_back static void > staging: r8188eu: make OnAction_p2p static void > staging: r8188eu: remove category check in OnAction_p2p > staging: r8188eu: replace switch-case with if > staging: r8188eu: replace GetAddr1Ptr call in OnAction_p2p > staging: r8188eu: clean up on_action_public > staging: r8188eu: remove return value from on_action_public_vendor > staging: r8188eu: remove return value from on_action_public_default > staging: r8188eu: rtw_action_public_decache's token is a u8 > staging: r8188eu: check destination address in OnAction > > drivers/staging/r8188eu/core/rtw_mlme_ext.c | 116 +++++------------- > .../staging/r8188eu/include/rtw_mlme_ext.h | 7 -- > 2 files changed, 28 insertions(+), 95 deletions(-) > Tested-by: Philipp Hortmann # Edimax N150