Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Oct 2022 13:14:41 +0800
From:   Tzung-Bi Shih <tzungbi@kernel.org>
To:     Brian Norris <briannorris@chromium.org>
Cc:     Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] platform/chrome: cros_ec_lpc: Move mec_init/destroy
 to device probe/remove
Message-ID: <Y19ZwWXnnl89i1QI@google.com>
References: <20221028141411.1.I0728421299079b104710c202d5d7095b2674fd8c@changeid>
 <Y19VXaB1531V64EI@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y19VXaB1531V64EI@google.com>
Precedence: bulk

On Mon, Oct 31, 2022 at 12:55:57PM +0800, Tzung-Bi Shih wrote:
> On Fri, Oct 28, 2022 at 02:14:45PM -0700, Brian Norris wrote:
> > Disregarding the weird global state hiding in this cros_ec_lpc_mec_*()
> > stuff, it belongs in device probe/remove. We shouldn't assume we can
> > access hardware resources when the device isn't attached to the driver.
> 
> It's also weird that cros_ec_lpc_mec_destroy() destroies a statically
> allocated mutex[1].  How about let's remove it?

If it makes sense:
https://patchwork.kernel.org/project/chrome-platform/patch/20221031050657.3899359-1-tzungbi@kernel.org/