Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Oct 2022 12:41:40 +0530
From:   Deepak R Varma <drv@mailo.com>
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        outreachy@lists.linux.dev, dri-devel@lists.freedesktop.org,
        linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count
Message-ID: <Y191LI7zKVRA5LEb@ubunlion>
References: <Y1vZXUi0Bjiub8HZ@ubunlion>
 <Y1zXIjCe3LGwApWD@kroah.com>
 <Y11b0oCmle2pbRel@ubunlion>
 <alpine.DEB.2.22.394.2210291931590.2917@hadrien>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2210291931590.2917@hadrien>
Precedence: bulk

On Sat, Oct 29, 2022 at 07:34:26PM +0200, Julia Lawall wrote:
>
>
> On Sat, 29 Oct 2022, Deepak R Varma wrote:
>
> > On Sat, Oct 29, 2022 at 09:32:50AM +0200, Greg Kroah-Hartman wrote:
> > > On Fri, Oct 28, 2022 at 07:00:05PM +0530, Deepak R Varma wrote:
> > > > The ARRAY_SIZE(foo) macro should be preferred over sizeof operator
> > > > based computation such as sizeof(foo)/sizeof(foo[0]) for finding
> > > > number of elements in an array. Issue identified using coccicheck.
> > > >
> > > > Signed-off-by: Deepak R Varma <drv@mailo.com>
> > > > ---
> > > >  drivers/staging/fbtft/fbtft.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> > > > index 2c2b5f1c1df3..5506a473be91 100644
> > > > --- a/drivers/staging/fbtft/fbtft.h
> > > > +++ b/drivers/staging/fbtft/fbtft.h
> > > > @@ -231,7 +231,7 @@ struct fbtft_par {
> > > >  	bool polarity;
> > > >  };
> > > >
> > > > -#define NUMARGS(...)  (sizeof((int[]){__VA_ARGS__}) / sizeof(int))
> > > > +#define NUMARGS(...)  ARRAY_SIZE(((int[]){ __VA_ARGS__ }))
> > >
> > > Please please please test-build your patches before sending them out.
> > > To not do so just wastes reviewer resources :(
> >
> > Hello Greg,
> > I did build the .ko files by making the driver/staging/fbtft/ path. I verified
> > .o and .ko files were built.
> >
> > I did a make clean just now and was again able to rebuild without any errors.
> > Please see the attached log file.
> >
> > Is there something wrong with the way I am firing the build?
>
> The change is in the definition of a macro.  The compiler won't help you
> in this case unless the macro is actually used in code that is compiled.
> Find the uses and check for any nearby ifdefs.  For file foo.c you can
> also do make foo.i to see the result of reducing ifdef and expanding
> macros.  Then you can see if the code you changed is actually included in
> the build.

Okay. This is helpful. I understand. Looking into the file where the macro
expansion is reported to be failed.

Thank you,
./drv

>
> julia
>