Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202210310123.aklkcZzK-lkp@intel.com>
In-Reply-To: <202210310123.aklkcZzK-lkp@intel.com>
From:   Alexander Potapenko <glider@google.com>
Date:   Mon, 31 Oct 2022 09:27:25 +0100
Message-ID: <CAG_fn=VqT+ORnMwR=YCsp6SxOMESqL9-O_t8G-5BdsNNBe13Mg@mail.gmail.com>
Subject: Re: arch/powerpc/kexec/crash.c:311:22: error: variable 'i' might be
 clobbered by 'longjmp' or 'vfork'
To:     kernel test robot <lkp@intel.com>
Cc:     oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        Kees Cook <keescook@chromium.org>,
        =?UTF-8?Q?Maciej_=C5=BBenczykowski?= <maze@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Looks unrelated to this 2-year old commit?

On Sun, Oct 30, 2022 at 6:12 PM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi=
t master
> head:   882ad2a2a8ffa1defecdf907052f04da2737dc46
> commit: f0fe00d4972a8cd4b98cc2c29758615e4d51cdfe security: allow using Cl=
ang's zero initialization for stack variables
> date:   2 years, 4 months ago
> config: powerpc-wii_defconfig
> compiler: powerpc-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=3D1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi=
n/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.=
git/commit/?id=3Df0fe00d4972a8cd4b98cc2c29758615e4d51cdfe
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/=
git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout f0fe00d4972a8cd4b98cc2c29758615e4d51cdfe
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-12.1.0 make.cro=
ss W=3D1 O=3Dbuild_dir ARCH=3Dpowerpc SHELL=3D/bin/bash arch/powerpc/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>    arch/powerpc/kexec/crash.c: In function 'default_machine_crash_shutdow=
n':
> >> arch/powerpc/kexec/crash.c:311:22: error: variable 'i' might be clobbe=
red by 'longjmp' or 'vfork' [-Werror=3Dclobbered]
>      311 |         unsigned int i;
>          |                      ^
>    cc1: all warnings being treated as errors
>
>
> vim +311 arch/powerpc/kexec/crash.c
>
> 496b010e1e70a9 arch/powerpc/kernel/crash.c Michael Neuling  2008-01-18  3=
08
> cc53291521701f arch/powerpc/kernel/crash.c Michael Ellerman 2005-12-04  3=
09  void default_machine_crash_shutdown(struct pt_regs *regs)
> cc53291521701f arch/powerpc/kernel/crash.c Michael Ellerman 2005-12-04  3=
10  {
> 496b010e1e70a9 arch/powerpc/kernel/crash.c Michael Neuling  2008-01-18 @3=
11     unsigned int i;
>
> :::::: The code at line 311 was first introduced by commit
> :::::: 496b010e1e70a9b4286fa34f19523f24a194f119 [POWERPC] kdump shutdown =
hook support
>
> :::::: TO: Michael Neuling <mikey@neuling.org>
> :::::: CC: Paul Mackerras <paulus@samba.org>
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp


--=20
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636 M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg