Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp337436rwi; Mon, 31 Oct 2022 01:55:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4dRHjdi2bJ4/hyUY2AeengtxdpTcpqS498Tbu5jw9po3f2rJ3vT0MakdZGYmcXNBasMUAK X-Received: by 2002:a17:906:db0e:b0:77b:82cf:54a6 with SMTP id xj14-20020a170906db0e00b0077b82cf54a6mr11570844ejb.691.1667206535880; Mon, 31 Oct 2022 01:55:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667206535; cv=none; d=google.com; s=arc-20160816; b=lg9oqXSyvmuJTn3llkkmJnvbzTBzeO0mFcHudPVYx5OfEqSX2ZGWnq4Zd4iophykR9 GuK/Tb/yPO8xSMLvCndHyzyISVdgkJql0ib2pN8rnSTQ3XBuVJshOTF0D66+axWk8WI7 mfOZXpWMNNvBWLWS7YX+AUlvQ0UEm3oYu+gG/qgZ3MHtQLj/6UUjHRZ4a2uaHw/JqS6A RBVTMAmAKsVifWe4go7WMMhajeLT3Cdjm4Tn5R/E8FgKOyzEku48hIo73qpmPcEcLQEp SkAtsBB9FRCYoSWGNBuewponxDNG8OvTyOCEzJJ9Ea5DTYFlc8CucjMqgxhLMlcQIcI7 2kPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=aXRPuiHZaRWVgY282JRBGy/9Tk3lAeKZwm5Knjm6br0=; b=aav2OQaeMHoJQFamQ8yX7XwyPUe2KjXeOi9p+k/3QCpKFLS8jyid5WSjtITcuU8bmw DhJd68Cfrr4I1WczR3jXZ7K8ixmcOxk1jHt66KtYv6lvRLo8lUeINgbRVfqCbcQpvj0m vBLwsRstLsKABHawkKALpTcJgINZE+JY6W3buuQUPgVQa5csR+ncGNrH4O7TJ6LL5u9i di/G9JertDEosRqwdTggWjbv3zC/N97WFitFSlOcwbnQFCAlidyaQhTT++DZBb8Qbn1c xYU8+zY+yilF3B5Eb77S+dxTF+2H24uDEaoJnSODAaMr3dUq2X3ifE1YYkZvTrUEI80J eWmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z99-20020a509e6c000000b0046276cd1219si6615305ede.239.2022.10.31.01.55.10; Mon, 31 Oct 2022 01:55:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbiJaI2z (ORCPT + 99 others); Mon, 31 Oct 2022 04:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbiJaI2v (ORCPT ); Mon, 31 Oct 2022 04:28:51 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2F5CD260C for ; Mon, 31 Oct 2022 01:28:49 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 568F080CD; Mon, 31 Oct 2022 08:19:20 +0000 (UTC) Date: Mon, 31 Oct 2022 10:28:47 +0200 From: Tony Lindgren To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, tglx@linutronix.de Subject: Re: [PATCH v2] clocksource/drivers/timer-ti-dm: fix missing clk_disable_unprepare in dmtimer_systimer_init_clock() Message-ID: References: <20221029114427.946520-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221029114427.946520-1-yangyingliang@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yang Yingliang [221029 11:36]: > If clk_get_rate() fails which is called after clk_prepare_enable(), > clk_disable_unprepare() need be called in error path to disable the > clock in dmtimer_systimer_init_clock(). Reviewed-by: Tony Lindgren