Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp356847rwi; Mon, 31 Oct 2022 02:14:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM41fM9xVDaO5Ktf2ICg1xHpFuFlgme26L/Q5LRhnpUnoUnWzvOSWbiFC9z5WqsaffbVopNg X-Received: by 2002:aa7:da84:0:b0:463:7873:119a with SMTP id q4-20020aa7da84000000b004637873119amr1986292eds.329.1667207674135; Mon, 31 Oct 2022 02:14:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667207674; cv=none; d=google.com; s=arc-20160816; b=Pczq9aqQqqMYReDmvywM34L5O3mg2ic9Z8gzpOVyw927QAHNDsVH5EVKG50X/KIzZh GvUh5XWGXf9oU96gxxr6YysVp2N6z/Q93QXgP+MZ+e5VNXQS1bA5h3vPc+09OpfKsxUh w6NxbTxsbrkQw2WmM6IWkk3wHDyPCWK+LD/4eL0FJl3mrvdbqJnMrOapKJNNKkQ5sDY7 fEW/8/Oa+Y2hCucLUudPVdTRL6cY62LtCMc8HEek5y+XrzfH2QypEIrKw5vD/oUcjLVs zbeBwRQ4RT+cq6JH/VOOxguk52F5DOyXlDNDXSM8Jl4eirTCDPlqwmCr/n1LqEPMy8v2 ms8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=g0snT4n//h/2k97Qobb3JRu1DhhY5eqFOKQUrnEmwJA=; b=TGabHmlpQm6MpT8bcdtiG4UBMPRXw3K6hMneAA1BbWojmDhVHOyK8kDbBprr9lHAmG uQqPIt580W4OtwR2/u3Kg0I/PKVw1zECA9+bjnI8N33IgQukdxbU9CNLgu5XqH2W2LKz j+lKNhkKcmIiSh4JxxKP6EoPfxMnd4ndDLkB60FxvQgsSlZpNZcJBUEDFgKg81MZSsK8 AB6hdfnlGdZxiFIpFBpEYcxlx8VWtGJY1LAVxSWpABY3JGizdOF0ktBbmRoRP04nvxgm TSD42NASBB/+W21EMLhPWP3D4zRd6Jx8HcIcZPoetKbOrFSk+IoGD/S0dyP01HPBbgiu Vd8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EadVQDvX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bx11-20020a0564020b4b00b00461c7ad026csi6703098edb.61.2022.10.31.02.14.10; Mon, 31 Oct 2022 02:14:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EadVQDvX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbiJaJGO (ORCPT + 99 others); Mon, 31 Oct 2022 05:06:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiJaJGM (ORCPT ); Mon, 31 Oct 2022 05:06:12 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7676020C; Mon, 31 Oct 2022 02:06:11 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id d26so27667741eje.10; Mon, 31 Oct 2022 02:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g0snT4n//h/2k97Qobb3JRu1DhhY5eqFOKQUrnEmwJA=; b=EadVQDvXTd2a2c0lt8q3h3DJE69Qed2JO2ph+XpyOEsWL16C732jST4btYtzdn2prT GBR/zf4c/Sc5wlSPe0lnAgDD/DhuKBTm3jE6FNHx3x/4/TxkJyrre16xDYCd056nLkKv hSQy0iOkqLK8uMaWYFemSgXMeue6NXfSazQhL6EsF9gKVotozpakMkM03mKocbrL/FuZ YU1OwhUCtHQMtfq96N58S9fFhSjoN7Ow6DsfPx5wYPKstLxFC1Lt0hiM9EIfY/kpdCiO AtbWuIAE+a4VfUzcnTGoxGfh0/ZRsuSu3pzC4Bl3gzg89zDO0EisQG/+MbWB/HYnaWsc a8JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g0snT4n//h/2k97Qobb3JRu1DhhY5eqFOKQUrnEmwJA=; b=0OZ3iidl3NFSD5D/EbQImErlzHuPp1XO6y5WTeEBv2d114CsCfZDThsKUnmOiwweog KCI6uh2gv4UFqhOSBFw7/S3fSkb3hiKjLwaLQk7wP0YGCu8lUtRz77Nau98BunS5y3er jggyVqnxWWgb8cJ0OQdVfZfRUyVXqvRV2eWz4XdNRuDKT2TeHbX5X5PK/TxEyE826xRH XPHrfGhVGl3jSd3X00SMtdmdo5rnRVXtT3KXlqKvW90zWAi4VSbJXOL2GsIdqWYOjOMz 9l+mJ0+YQ9MgUmolcXDlwWC2P4Ci8vqNptHFjVINcJJZ3t/4/iy4BqsnbLyeZSjAkG8d nQpQ== X-Gm-Message-State: ACrzQf16TqTzGYwKZuFah5TW2eHEauXXc8gcJU6/MxhEPpy8YfKwqG3x TAInKFPWx4hLdifnmzjKHnrEIj6V/jo= X-Received: by 2002:a17:907:b07:b0:7a8:beb3:aa2a with SMTP id h7-20020a1709070b0700b007a8beb3aa2amr11742021ejl.459.1667207169941; Mon, 31 Oct 2022 02:06:09 -0700 (PDT) Received: from kista.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id jx24-20020a170907761800b00730bfe6adc4sm2752122ejc.37.2022.10.31.02.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 02:06:09 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Paul Kocialkowski Cc: Yong Deng , Paul Kocialkowski , Mauro Carvalho Chehab , Chen-Yu Tsai , Samuel Holland , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v6 12/43] media: sun6i-csi: Remove controls handler from the driver Date: Mon, 31 Oct 2022 10:06:07 +0100 Message-ID: <2651862.mvXUDI8C0e@kista> In-Reply-To: <20220826183240.604834-13-paul.kocialkowski@bootlin.com> References: <20220826183240.604834-1-paul.kocialkowski@bootlin.com> <20220826183240.604834-13-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne petek, 26. avgust 2022 ob 20:32:09 CET je Paul Kocialkowski napisal(a): > The driver does not expose controls directly and thus does not need > a controls handler for its own use. > > Controls attached to subdevs used to be exposed that way, however this > can easily lead to issue when multiple subdevs attached to the same > v4l2 device expose the same controls. Subdev controls should be set > through each individual subdev node instead. > > Signed-off-by: Paul Kocialkowski Acked-by: Jernej Skrabec Best regards, Jernej