Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp385033rwi; Mon, 31 Oct 2022 02:42:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4VU/xOt+39JmwF0Bc6VKwGBEmuaf49r0+cSS3ikBTZA7SbxKv+xXKEvp1vYORDeegteRHy X-Received: by 2002:a17:906:da85:b0:741:40a7:d08d with SMTP id xh5-20020a170906da8500b0074140a7d08dmr12702536ejb.263.1667209346292; Mon, 31 Oct 2022 02:42:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667209346; cv=none; d=google.com; s=arc-20160816; b=fwLjTqAbMYOcnpRA3eszhrJDQvPH/uyzALDwwgk4eFx369lQI2mOF/ehthk6xi/70A r8+Hf1K4uZvySr4QNfLcTlVF0rL5zMG2GkJJBKuORc4/NOW1fCOVPCywuQZLQARr8XTM Q7/p2nDqotviRWFCLqfsqwMMUYcFXU2OB94TXwXI9Vf+WGUMTW31j7ZSUUxfOn807nnu csW2uXC18JKzU1oPnwZcuLB7/piuks3pwIg/p7TUXhq3r3UbI37DYZDT9Tmv5CbU/E5f P9VmvywhVg8W1qLbzWjY34oc247eUgn5uip1VkPwOgcFYBNDIFr8vQY/z2dxAVaNVH+F tRCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=QO1rjPvU83HjO4f4aw4imOYtNBn5Txei8pDwxZxfomc=; b=w043S8/KrasqQJMkSo1O0/Hsv7n6qeJ2xmy19tkCaeNtHI2WS9E5oZG5UwTnzdtNTW D7RzShrMdxObMxexkCeA6CzwBG7sxDzzr4GYhg13ts8ogZZuawNPIMnunjBpCifSBjx2 hIhSVZFa5d1rnZ+7XMiKAEMKHpVC5a2ldrcBnRwOlPRw1InU9ryJjczzk879whSVMSEt KcqzTE4BfoQoiLMnHn17Xyd4ZSwF4HFmTSs3t3pb4Q4xj9Y7Er0JLHJMJTIjX9Q9JP/h dJvZ3a9r1y7cm51FK8/NPOuZKIO4TR90tyQ4NvU+WWRz92ZqDu3zR0dRio61ACuPJhAH gNWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OHSqXBoF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb41-20020a170907162900b007ad812915c9si9087340ejc.581.2022.10.31.02.42.02; Mon, 31 Oct 2022 02:42:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OHSqXBoF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbiJaJaV (ORCPT + 99 others); Mon, 31 Oct 2022 05:30:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230046AbiJaJaU (ORCPT ); Mon, 31 Oct 2022 05:30:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8534DE8D; Mon, 31 Oct 2022 02:30:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ACAB7B812A4; Mon, 31 Oct 2022 09:30:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 60162C433B5; Mon, 31 Oct 2022 09:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667208616; bh=2hirn8oZToaPOo0zJF6+I7mD28CkBLy+ib/GNfmyPpU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=OHSqXBoFM5oIKe8gpAqgjpIbMANpYAfSjNAmA6AUUpllHmIwYtKK2nrneGaUAqys0 mYJK+tg8mHW9Oa9D13b634mXvbpVweYdmBqbf42smPTFLVklEc9INDaDnGowuHMnI7 ZeE5RbksG4xlO/Ya3HiXBJyqjr9+Uktj79lwrEk7cEVaZN55M7+l2fITvLxk+RdlY+ T4x0Wi6zxutFyCsbRa30y9xV0SlVVbG7jmzq1UUfA2ijFCpTPwa1hRbms4gAyMRTRy +C6f7MIdu/D1xJ1TpaQiTaqNa7+gwth4GC9JzudYnRvFgQJVqiF55/hlGvRKEhHEXL sM+umoTnlpCDQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 39D9DC41621; Mon, 31 Oct 2022 09:30:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] net: fec: fix improper use of NETDEV_TX_BUSY From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166720861622.19318.350956641724128666.git-patchwork-notify@kernel.org> Date: Mon, 31 Oct 2022 09:30:16 +0000 References: <1666922951-1645-1-git-send-email-zhangchangzhong@huawei.com> In-Reply-To: <1666922951-1645-1-git-send-email-zhangchangzhong@huawei.com> To: Zhang Changzhong Cc: qiangqing.zhang@nxp.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, B38611@freescale.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 28 Oct 2022 10:09:11 +0800 you wrote: > The ndo_start_xmit() method must not free skb when returning > NETDEV_TX_BUSY, since caller is going to requeue freed skb. > > Fix it by returning NETDEV_TX_OK in case of dma_map_single() fails. > > Fixes: 79f339125ea3 ("net: fec: Add software TSO support") > Signed-off-by: Zhang Changzhong > > [...] Here is the summary with links: - [net] net: fec: fix improper use of NETDEV_TX_BUSY https://git.kernel.org/netdev/net/c/06a4df5863f7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html