Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp458897rwi; Mon, 31 Oct 2022 03:49:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4c5/JTzCBgk6RTtVHVvxN46w6Lv6BiCvSZqlF2OwHdY8xp/o5Jf+WtjjKRO0+qtAtvxY/A X-Received: by 2002:a17:90a:6f83:b0:213:9e97:d5e1 with SMTP id e3-20020a17090a6f8300b002139e97d5e1mr15371789pjk.149.1667213382091; Mon, 31 Oct 2022 03:49:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667213382; cv=none; d=google.com; s=arc-20160816; b=z47mRBdYRrZxAX+ZDFPVwZwjwUg6O9dTPZ2zCppOkYfTS7qtP2JV/y7RnS6134yJJe MLBJj5/4UGxglFuq0uTM/gafTQnhEkZJYduGRfEQajFONQiE8OUMXFjxHYF3/6j2/6I4 XoAlp4qubvkICrkb1G71nbHhsVkUq88Qoi+FW+BoTNMtaCaQXdY499IOenwD7hcMbABL 9KzcLQBSBLEcEzBk24up0o2vF93oSbCk+nlgkkqvVNp4bErZW/7Nd4c+aQd6Zd4rsgll 9HFeYj9J/g8OCSwqi46oPUTmuinjMPoLnGyE6lcHj/+6ZbVjcgmun+yGDA/nnkuoMyKe g7NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=E7+K2agDo3PWDiJqVGMFuc1n6P62g6uovokW/fknxaA=; b=HzgwyRUPTu1Jhuwi5oPqR88LBYunvsd1CaW4E5RCgMwEuV2fZGPSU9HIa4BtHSYlGy /1eP1bX9Lvz0zWD5toGbtfVTJqHSklihQFZFMNxx7W5WqJnAxTxWdurq2YL0c6MnsZmF 3dugMWeSuIy9zbaa8d6M2nl9kr+SlI6Q7Wb4M4Idiq6U3+XW7rgWkEj0mKavpJEfn8+k Ma3+tyB+RImOWE6lHfc5ZM9lEPH3MyrGKZ7GKYaovUYCer/8TsSsB98QG7bu9I/bg+jX 8QSVuOiXFxWYulgZFFYo8joSo1RSFRHPArg9n+NPrx2v1CHlbw7vzd0duRTr9h37yLf1 76UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Zk9hoPSp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pj6-20020a17090b4f4600b002130a792110si9774007pjb.103.2022.10.31.03.49.28; Mon, 31 Oct 2022 03:49:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Zk9hoPSp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230408AbiJaK06 (ORCPT + 98 others); Mon, 31 Oct 2022 06:26:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbiJaK0x (ORCPT ); Mon, 31 Oct 2022 06:26:53 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF94CDF83; Mon, 31 Oct 2022 03:26:51 -0700 (PDT) Received: from zn.tnic (p200300ea9733e7cf329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7cf:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2DF351EC0535; Mon, 31 Oct 2022 11:26:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1667212010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=E7+K2agDo3PWDiJqVGMFuc1n6P62g6uovokW/fknxaA=; b=Zk9hoPSpjGxLc164VkfRjc3kxF3H5rdM5S2OIk8Sm2KSIfuJ3RKiVpKzNYmGfHeTViGApG amin5PfneXFixhMrbpF8F+8UQ4rwNPUNZzpWdq8cpBNHEjkeSFJw/R9BEUjMzD4sktnPGs nzTzehkkbh1DZFK28+khZ7EQcOGLWok= Date: Mon, 31 Oct 2022 11:26:44 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Smita.KoralahalliChannabasappa@amd.com, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org Subject: Re: [PATCH] EDAC/mc_sysfs: Increase legacy channel support to 12 Message-ID: References: <20221018153630.14664-1-yazen.ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221018153630.14664-1-yazen.ghannam@amd.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 10:36:30AM -0500, Yazen Ghannam wrote: > Newer AMD systems, such as Genoa, can support up to 12 channels per EDAC > "mc" device. These are detected by the device's EDAC module, and the > current EDAC interface is properly enumerated. However, the legacy EDAC > sysfs interface provides device attributes only for channels 0 to 7. > Therefore, channels 8 to 11 will not be visible in the legacy interface. > This was overlooked in the initial support for AMD Genoa. > > Add additional device attributes so that up to 12 channels are visible > in the legacy EDAC sysfs interface. > > Ignore checkpatch warnings about "Symbolic permissions" to maintain > coding style. > > Fixes: e2be5955a886 ("EDAC/amd64: Add support for AMD Family 19h Models 10h-1Fh and A0h-AFh") > Signed-off-by: Yazen Ghannam > Cc: > --- > drivers/edac/edac_mc_sysfs.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) Applied, thanks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette