Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Maarten Zanders <maarten.zanders@mind.be>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
CC:     "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/3] ASoC: adau1372: fix mclk
Thread-Topic: [PATCH 1/3] ASoC: adau1372: fix mclk
Thread-Index: AQHY6uG2O57QBw25i0+j33gkklPZ4a4oX71w
Date:   Mon, 31 Oct 2022 11:20:41 +0000
Message-ID: <SJ0PR03MB6778A0EB0CD15A3A917BFE4A99379@SJ0PR03MB6778.namprd03.prod.outlook.com>
References: <20221028152626.109603-1-maarten.zanders@mind.be>
 <20221028152626.109603-2-maarten.zanders@mind.be>
In-Reply-To: <20221028152626.109603-2-maarten.zanders@mind.be>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?gEHxsWvAHwETe3l6vyFV5qGtcpzdsORFx900NcKCY071NSQwyGczjIC2V+?=
 =?iso-8859-1?Q?xP7jyqb1fv37ZBIPnLisO1JikopQ7UDtvcLMhohc8a0Ck5Cc+NNUJ5/ctB?=
 =?iso-8859-1?Q?hQnkMM9zKYs6f13fgmWSIuqPtQcLjIbEULuBF73QIoN8HFNaD7KSz2dk+C?=
 =?iso-8859-1?Q?fCmHoxJ204XHf7VtLld0T4lCfWxpDT37PxlGvzCYdo8a/WZt/yqqa25ftA?=
 =?iso-8859-1?Q?uJD3OBk2b6bCRoyouTx5qfoWR0EQ2KLo7NlUsiw9PtgHsz+PI1JuYKzqrO?=
 =?iso-8859-1?Q?Jd8YuWgRxfXuO66iS6M+zNxx+mxP0Dch+6pZBpkHbABJvKM8goJkj622gI?=
 =?iso-8859-1?Q?o3H6B/Z2wDAYPpAse7vIen7A7dGjU0Bweza1JM2djh9H7g/9quEGd7JEvs?=
 =?iso-8859-1?Q?eu9j5SU75aieA4FFnbVkcpJ8/ADbfA21F7fSA4OaFeKGCOfKlF8veSqt+K?=
 =?iso-8859-1?Q?qc/kJ/5STEFx232KWRISCJwVBUtceKC//VAx9g6cNNcTJUp9iacBI5Ds9z?=
 =?iso-8859-1?Q?Vx2EGVUbWRGdcla8NsfkQZkjfmShyOfGZZbPrOmXLHnAGQT5t8XFMdE8kD?=
 =?iso-8859-1?Q?61Br9E51pX0DPUzsww5vRAlFsBF93FYYgkcSzO7ULnTrX7YxElDH6Q5GAV?=
 =?iso-8859-1?Q?LEXvR2pR5JCQNaLRJSOXnzKJ3mUhILObkEyE1lDIoMewnRS42QqCeQAcI1?=
 =?iso-8859-1?Q?Nj+kRpDPY/y8uVrNnCdeNwbcxqOUj26WI0/tcIrnt4+rGG3p2+QInr+VnP?=
 =?iso-8859-1?Q?aO94LzEE8cdMcfuDfGIGLdtuyCCpXWtRGea6L1huDl8PGK3bZ05faqhfUL?=
 =?iso-8859-1?Q?GNzJH+1QkFZniS6OVzavvnEqi+NmzEz2/V5x2qyWYLC60tRQaRLPGFEQ59?=
 =?iso-8859-1?Q?VuVzUHY+c7mVD5kcfR5JZ4w07lEMptiv5efqTt70iIBUjW/nmlncggw4kl?=
 =?iso-8859-1?Q?VGBvSXamapGwQWf4f1y2uy4cUPRftaYfMPF8SZrMgn1pj7vH0Osjh0tBdw?=
 =?iso-8859-1?Q?1OIUc9UxKgIq7/Rc82lYy1jR58+FOe1C3ZN+cicEPWRYhbiiST+dzo9Lob?=
 =?iso-8859-1?Q?CoYuFrgYMd0ZlnFL0BX06f8oI9rL/lCA3tpCaBJd3L2QFWpxwe5oeTi04f?=
 =?iso-8859-1?Q?D4EH0Wqy+LNbYiEODPzdwJDEkOr+s08vHQLKi0xj0dLojb06bi6bd7iF2N?=
 =?iso-8859-1?Q?f1agmVYyDNettHfcrApCfcsGcupQDwttmUZrTGFAFCCkfe4zvAXUhVamnW?=
 =?iso-8859-1?Q?Nabl/WIte4wbXbxjUk1ByiH07M+WsTE44rGX/q7Gl9FL8EQR5p3pS7UOS7?=
 =?iso-8859-1?Q?naDmNcFIiRiLj1HKXxrrqPqiQIzZcw9meH0c3PVYMXwfKlA1s/tY1rlbJ2?=
 =?iso-8859-1?Q?ImxBlH05dz7G6e0iHz9i/oQwiaWZR6/s/dgvjKp6BNKZ/WlEAFE3zIDflQ?=
 =?iso-8859-1?Q?mTlkbGEawVYch8yKhdBlCYKgKM70yHnozDzpAn/tIuaeAWNrdPq3fi0bnG?=
 =?iso-8859-1?Q?LuL1M+ixuRTZ91GSK1UBXT8biL3pxZNuaB4bVwLBK7sS6UEi0w/nDrhBti?=
 =?iso-8859-1?Q?9w3yLC2Jmq6CRfeCS4LXDuBmW7aC9RIbjcHSn8NlCLXFjChpRewuy/zyzk?=
 =?iso-8859-1?Q?RSZ7/tRGNd735XY3K+0EGmhgF0gui/q6cD?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6778.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b14b09c0-3835-4679-405d-08dabb31f253
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2022 11:20:41.9055
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iFR7VJgqsdjrnxgwTBKn8DEIobJMzVw81PHiXT+T/BgccHb6EZUr0vTfpcjBZwlxgmfRAOox1938jr+CJMtfdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6635
X-Proofpoint-GUID: nQOfb4wHRDQhJnQd0HFgjSlSXrzh87bV
X-Proofpoint-ORIG-GUID: nQOfb4wHRDQhJnQd0HFgjSlSXrzh87bV
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-31_06,2022-10-31_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0
 suspectscore=0 clxscore=1011 impostorscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 priorityscore=1501 mlxlogscore=672 spamscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210310071
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Maarten Zanders <maarten.zanders@mind.be>
> Sent: Friday, October 28, 2022 5:26 PM
> To: Lars-Peter Clausen <lars@metafoo.de>; Sa, Nuno
> <Nuno.Sa@analog.com>; Liam Girdwood <lgirdwood@gmail.com>; Mark
> Brown <broonie@kernel.org>; Jaroslav Kysela <perex@perex.cz>; Takashi
> Iwai <tiwai@suse.com>
> Cc: Maarten Zanders <maarten.zanders@mind.be>; alsa-devel@alsa-
> project.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 1/3] ASoC: adau1372: fix mclk
>=20
> [External]
>=20
> "mclk" is retrieved from the configuration and assigned to adau1372->clk.
> However adau1372->mclk (=3D=3DNULL) is used for clk_prepare_enable() and
> clk_disable_unprepare() which don't have any effect.
>=20
> Remove .clk from struct adau1372 and use .mclk throughout.
> This change ensures that the input clock is switched on/off when the
> bias level is changed.
>=20
> Signed-off-by: Maarten Zanders <maarten.zanders@mind.be>
> ---

I guess this needs a Fixes: tag?

- Nuno S=E1