Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22a8dc6e-2955-9b5e-7b9b-5f31625fe057@redhat.com>
Date:   Mon, 31 Oct 2022 13:42:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v3 4/5] memblock tests: add generic NUMA tests for
 memblock_alloc_exact_nid_raw
Content-Language: en-US
To:     Rebecca Mckeever <remckee0@gmail.com>,
        Mike Rapoport <rppt@kernel.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <cover.1666203642.git.remckee0@gmail.com>
 <44611cd9c0939cdf2e3f232298b547efee4d772a.1666203644.git.remckee0@gmail.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <44611cd9c0939cdf2e3f232298b547efee4d772a.1666203644.git.remckee0@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19.10.22 20:34, Rebecca Mckeever wrote:
> Add tests for memblock_alloc_exact_nid_raw() where the simulated physical
> memory is set up with multiple NUMA nodes. Additionally, all but one of
> these tests set nid != NUMA_NO_NODE. All tests are run for both top-down
> and bottom-up allocation directions.
> 
> The tested scenarios are:
> 
> Range unrestricted:
> - region cannot be allocated:
>        + there are no previously reserved regions, but requested node is
>          too small
>        + the requested node is fully reserved
>        + the requested node is partially reserved and does not have
>          enough space
>        + none of the nodes have enough memory to allocate the region
> 
> Range restricted:
> - region can be allocated in the specific node requested without
>    dropping min_addr:
>        + the range fully overlaps with the node, and there are adjacent
>          reserved regions
> - region cannot be allocated:
>        + range partially overlaps with two different nodes, where the
>          second node is the requested node
>        + range overlaps with multiple nodes along node boundaries, and
>          the requested node starts after max_addr
>        + nid is set to NUMA_NO_NODE and the total range can fit the
>          region, but the range is split between two nodes and everything
>          else is reserved
> 
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb