Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <petrm@nvidia.com>
CC:     <netdev@vger.kernel.org>, <davem@davemloft.net>,
        <maxime.chevallier@bootlin.com>, <thomas.petazzoni@bootlin.com>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <joe@perches.com>,
        <linux@armlinux.org.uk>, <Horatiu.Vultur@microchip.com>,
        <Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next v4 1/6] net: dcb: add new pcp selector to app
 object
Thread-Topic: [PATCH net-next v4 1/6] net: dcb: add new pcp selector to app
 object
Thread-Index: AQHY6rM8OFrHDA25H0OhHnc4y1yB/a4oXkWAgAAa2oA=
Date:   Mon, 31 Oct 2022 12:39:39 +0000
Message-ID: <Y1/EbRMDM4ah2qd6@DEN-LT-70577>
References: <20221028100320.786984-1-daniel.machon@microchip.com>
 <20221028100320.786984-2-daniel.machon@microchip.com>
 <87o7tsw7ji.fsf@nvidia.com>
In-Reply-To: <87o7tsw7ji.fsf@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sXHqvr4RcEMU4/+Fz21A1J5ur0vbwMzG74cLekBf3YGAbYfPYI4FNl00V8BE?=
 =?us-ascii?Q?m5qb31e5gKoPTEAFj9c3YqxsjbTq40drW4We/KPPQn9qYO375acfrqlW0AJ8?=
 =?us-ascii?Q?rEiFbCXlt9caQUZHm9QsMHdClWXE2EHuwKV9WJkV0h/gfu8+qIW8aHdQCHpM?=
 =?us-ascii?Q?juGpsQ40S2j9LfzUkyfeEVq3tZEBTnI5IfLvV2PDaH+yP45f+CsYlsNR6Mof?=
 =?us-ascii?Q?9AzWQHVT9fYPUmYxI7tLdTYt76X+XE8og50D93kR0pLElAC94itZqgJi9FoT?=
 =?us-ascii?Q?NfLDkyKKPxJxaXukwsbAjuOTA6uXDXWGe6Sb78/zMrFT+8S9kY9a0XlLsVoe?=
 =?us-ascii?Q?k3QP82TGV72y+6Oh3F2O3K42W989UbXD8vQiWhcWSdgjLU0BO/nbBggEQTqV?=
 =?us-ascii?Q?J+hut5bKVfEC5YFZSm1nrwWeX4h7W0qOYIgG34crnAeL5kfVDnS4jhjtG54u?=
 =?us-ascii?Q?8V5VZTPiFlqflu5HEUb1yXJskX1sryoJqkytb+3hVgS5XqqPvZUQT/W9XPtG?=
 =?us-ascii?Q?1oNMjzs8E4L6IsGOt7lfDO28tIRzKjaAho9abfIfUdgrh7E5ogr37OeOKT/5?=
 =?us-ascii?Q?QBtrvEMmxJpJ4AeH1gUa5QTN1dcecu+tvBKQjtiCCsIqJUEw6dTLdY4SPfJ3?=
 =?us-ascii?Q?y0MA9yfRtnBnf0XgPeeZZkxfhtGG8UdUYJ5cAG3RxgTTpIO855yI+BsoKC//?=
 =?us-ascii?Q?d5BZxDdy4izoDc0RRqiiORV/iSn/HHDCwPWm3MQkkReTcUckPGyE9oAUzaqH?=
 =?us-ascii?Q?3i474bdRMrEJ8ExI7k2wYIDq1nZBkfw0GYP8HkCgYKH/7/11TLsxCmNV+0QT?=
 =?us-ascii?Q?t7qZFVL32nDW8i+6RETNPdxYxwr+aNMT3c67W95Nz7vx/B+1Tx2iaRp3lT0f?=
 =?us-ascii?Q?Xp/SNQlS95pHIg8iAVaeONZb89h45ZCnYcn/1pDmhGAJtUPaskWHqjTZ5xuE?=
 =?us-ascii?Q?nitw64Js/Kq3/W7FeGgy7uMv3yY1CgHXgViXAXtBR1XEgZ9l1f1ibtNFhgih?=
 =?us-ascii?Q?Zd0TEJaBjdfiTDJk8U3gqjJWPKk6hfgMRqdFqQKvluAXafCGXFcBC2I8hBlE?=
 =?us-ascii?Q?INKFTN/L7mmlF8Ytnb2XIur22nMfn6y12ukQRVQ9EVN6PjJalBr6tFz5BUce?=
 =?us-ascii?Q?1AF5W4i6RS93wBBpiTxiG1TV9zuVgC4UtG+lINA0dq2548oddvuOukyb2izk?=
 =?us-ascii?Q?9ipDRGhgkr8ZPoJI04KzKdqz5dyBS0tFA0fi9IisThNBvxAu9TRMhCmcM56S?=
 =?us-ascii?Q?DjECNt2iHmk518n54lHC0JtqNal+HGPCo5ocWgcjQUlL58XwG2Qp85LYyBgj?=
 =?us-ascii?Q?eSXBFDNvNfheRbZ+Tf4CWxvVVvSWD3M4x5eS3FDYW1Y+C0CwCWlgitRSN1th?=
 =?us-ascii?Q?OdGxaKxh8BFyJE/ToGllRgrjtF/OhStdZlc4hvkR8wDFztfUqGstyLT36xHM?=
 =?us-ascii?Q?TIddLkTgAxNdzosGQteIor2b+6zEBswcRlQx/XFTEPjV8KaueRKkRuBEKV9d?=
 =?us-ascii?Q?yN/WU6gQb8bc2oMMA7jcQK+aYTu6dfrBEEJGB0h1FxdqzLsKb4muy2YNVFVa?=
 =?us-ascii?Q?rJ7Mn/PxQPL/RKcRufRddm8fVzM5AcVNlgbHmmQ/Ly82Wl6ZBDS+ZHXVH65h?=
 =?us-ascii?Q?e4rf1Ese79EYRDghFbdYLP4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AB5A76D4A485264888C88A7AE293B759@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5569.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2942d62-86a9-48d4-f366-08dabb3cf9f5
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2022 12:39:39.2111
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IJBGIVFQtTKUnGhs0jZVr2SPPzcl1tqyUe/kOP2uyMBcFer/7L0Y9wIlWfSg1Plh7QvtM3N1oRBPvRkdwIL0B+0szdc47OBwFIOYM/CM5RA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6623
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
> > index dc4fb699b56c..68e033a459af 100644
> > --- a/net/dcb/dcbnl.c
> > +++ b/net/dcb/dcbnl.c
> > @@ -179,6 +179,57 @@ static const struct nla_policy dcbnl_featcfg_nest[=
DCB_FEATCFG_ATTR_MAX + 1] =3D {
> >  static LIST_HEAD(dcb_app_list);
> >  static DEFINE_SPINLOCK(dcb_lock);
> >
> > +static enum ieee_attrs_app dcbnl_app_attr_type_get(u8 selector)
> > +{
> > +     switch (selector) {
> > +     case IEEE_8021QAZ_APP_SEL_ETHERTYPE:
> > +     case IEEE_8021QAZ_APP_SEL_STREAM:
> > +     case IEEE_8021QAZ_APP_SEL_DGRAM:
> > +     case IEEE_8021QAZ_APP_SEL_ANY:
> > +     case IEEE_8021QAZ_APP_SEL_DSCP:
> > +             return DCB_ATTR_IEEE_APP;
> > +     case DCB_APP_SEL_PCP:
> > +             return DCB_ATTR_DCB_APP;
> > +     default:
> > +             return DCB_ATTR_IEEE_APP_UNSPEC;
> > +     }
> > +}
> > +
> > +static bool dcbnl_app_attr_type_validate(enum ieee_attrs_app type)
> > +{
> > +     switch (type) {
> > +     case DCB_ATTR_IEEE_APP:
> > +     case DCB_ATTR_DCB_APP:
> > +             return true;
> > +     default:
> > +             return false;
> > +     }
> > +}
> > +
> > +static bool dcbnl_app_selector_validate(enum ieee_attrs_app type, u32 =
selector)
> > +{
> > +     switch (selector) {
> > +     case IEEE_8021QAZ_APP_SEL_ETHERTYPE:
> > +     case IEEE_8021QAZ_APP_SEL_STREAM:
> > +     case IEEE_8021QAZ_APP_SEL_DGRAM:
> > +     case IEEE_8021QAZ_APP_SEL_ANY:
> > +     case IEEE_8021QAZ_APP_SEL_DSCP:
> > +             /* IEEE std selectors in IEEE std attribute */
> > +             if (type =3D=3D DCB_ATTR_IEEE_APP)
> > +                     return true;
> > +             else
> > +                     return false;
>=20
> AKA return type =3D=3D DCB_ATTR_IEEE_APP;
>=20
> > +     case DCB_APP_SEL_PCP:
> > +             /* Non-std selectors in non-std attribute */
> > +             if (type =3D=3D DCB_ATTR_DCB_APP)
> > +                     return true;
> > +             else
> > +                     return false;
>=20
> Likewise here.
>=20
> > +     default:
> > +             return false;
> > +     }
>=20
> Also, it really looks like the following would be equivalent?
>=20
> static bool dcbnl_app_selector_validate(enum ieee_attrs_app type, u32 sel=
ector)
> {
>         return dcbnl_app_attr_type_get(selector) =3D=3D type;
> }

Ah, yes. Less code. Much better indeed, thanks :-)

>=20
> Also, shouldn't it be u8 selector?

Will be fixed in next version.=