Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <petrm@nvidia.com>
CC:     <netdev@vger.kernel.org>, <davem@davemloft.net>,
        <maxime.chevallier@bootlin.com>, <thomas.petazzoni@bootlin.com>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <joe@perches.com>,
        <linux@armlinux.org.uk>, <Horatiu.Vultur@microchip.com>,
        <Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next v4 2/6] net: dcb: add new apptrust attribute
Thread-Topic: [PATCH net-next v4 2/6] net: dcb: add new apptrust attribute
Thread-Index: AQHY6rNmzkvI/HYxK0+8z78mmLSQGK4ocgOAgAAI3QA=
Date:   Mon, 31 Oct 2022 12:45:55 +0000
Message-ID: <Y1/F5n+geZHAitoW@DEN-LT-70577>
References: <20221028100320.786984-1-daniel.machon@microchip.com>
 <20221028100320.786984-3-daniel.machon@microchip.com>
 <87k04gw54m.fsf@nvidia.com>
In-Reply-To: <87k04gw54m.fsf@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OOfiERTH0uR/EFOUlOMGpgrOU7Q86c5fN+CmdOJr81oSopWjQhZAnyp8mdLb?=
 =?us-ascii?Q?aYuFU0JEPhBX5FrBN3DU9IWBuaC2rxgjpKDtiz7gjbNRkU9xiZdhkFhIVnZc?=
 =?us-ascii?Q?US8BlTSC7p8+K1ew5ynlciVkrq4LrsT89We4tfuyDMaizg5Mc7vhWB7FvtwC?=
 =?us-ascii?Q?m0PSfaoi/UUoZTwE4CbQyXAD/NHchRQWuYjbJRNC6c9/0ftzCdb3RJBshUeo?=
 =?us-ascii?Q?c+f7ca4Nyuzpx/yxRXdVaXcD3Un78M5DCv4iS1uqh5BElc5EUyNjW0aqGqVH?=
 =?us-ascii?Q?27Ey8aQU9e5io3Be/5i5tqQlhwI2PbIoSvzd7AuqGqBWN5cADz51m98/xm77?=
 =?us-ascii?Q?tTmg3l7giK16vrGU0eJ2Hy6DoQnkpNVCSkEcZGODEJ7nMk5n9fJKaA6531eV?=
 =?us-ascii?Q?I5mBCit1glGQij+3qN9OtW/s2uC3emTp+4Xatbn09xrdZYt7FMbSrtrV67Ar?=
 =?us-ascii?Q?gP5/QcRVm79TIa6CwuGpEye4i5/+AVdKYuwP9brzY/mrrkuji4tPkvtCDghs?=
 =?us-ascii?Q?Yejo1y6kckMgk0WRCYWdJkPeyVoAqdz/JoZRLp8G+Cm6QqCbrJtiZxhmtTBf?=
 =?us-ascii?Q?WWBd70t5W0jM693Lp6PbSwLrP565lt+jfqad7KhW2DdY80u7X2B7ne5Mj/E8?=
 =?us-ascii?Q?PnSycQjKOdVBCRVWmBb+n3zrkUvtnm3VWjEB2kX/nDENQ8H2LmrDZZtWSQOJ?=
 =?us-ascii?Q?i35xBrYROvs+ki1BOnyZNU1Stv80u6gAwjPYU43EOvOQT0YCA9w8tS8773ku?=
 =?us-ascii?Q?ndlCuINtKS1EBgkchUaQW8aUpM9e23tImO2PHAopcWTVzWHiLvFGIyoIDa8Z?=
 =?us-ascii?Q?9l1Pqu8dXVdbbMcV59YhelnS+vCEsmJczOg9RlhSgjkmvJHBIeeGGShxJ3tc?=
 =?us-ascii?Q?bpLHEjdDS4CXamnDYKyoRtWmeptnus6zVUIbNpi0HHAAtxL+0BHaLmCFCfCK?=
 =?us-ascii?Q?q43BfRZ9RMkg8yDL0Gfvbuh8kyIptduAgemrVvj4fVN7Yy9yJ0dhm629PzP8?=
 =?us-ascii?Q?g4M4yh85mG/iTVhjamsUolt2xenNF5Q68Dv4/6QfNetsyXmBqQskx4GKgVX4?=
 =?us-ascii?Q?6pRsaIe+dEin7nAoWv1prbVgNchTqL9z4pp4MXoNl92XYiHTgOYTUNls3QEt?=
 =?us-ascii?Q?yruXCv06IIyfVworgJwOQ8eCNl1OQuMzGaim0LI0iG8h2s1u+n0cg82bf4qW?=
 =?us-ascii?Q?Tcne0IEgAEwIa1tc3iY5K9jE6+JS980prNyAinttmPqVH9znIANU9oR2B/xV?=
 =?us-ascii?Q?tS6vwNGXzgtYIGnGl57j7ieI4tjmsdJ0c2xCX10sEF3g9eANCa9BG4fUX+/c?=
 =?us-ascii?Q?IvqMjaZcTatW285fMiu7llQzUVAc9mDihVQ5p2E9oUnD43lfK5CqcCtJ9vEI?=
 =?us-ascii?Q?EE3Q3ARo5YNcNkeRcaQyxNWdeqsJYnPAgx6rAobwmvW/lcc7HjtaSL7kaNha?=
 =?us-ascii?Q?r0zvvUiUxnqzRrbs1so5tLJpi1thqTUmTeAyxYmEs66kj5U6PP59viuOul0F?=
 =?us-ascii?Q?siWOAlK9LYQoHTAuuTfZIdZmEoaman6tUIF4coIm16dFtkvtQjU3GwoMzaqg?=
 =?us-ascii?Q?MqKFoRoxiDUcW2Aam/goiREugFasWOQ4BgdNNsrGLX2TYaPVZ2Z6tJd1btE3?=
 =?us-ascii?Q?g4mZC9miMjYf7EF+VqcuIO0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <257F66476E87E74794A9699F53B9408C@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5569.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e48fba67-2aa1-44ba-df3d-08dabb3dda73
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2022 12:45:55.8616
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FQHfvLoyybWqBvVXNjK6Ka/e7BjxD1pgP2bUxfYy0GujFKZpD2LCFQxneRHghqEzwzrwfkI9c2Wt2kq2k5T/v/ue/8DUvhvAq/GWCef+VaE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6623
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +     if (ieee[DCB_ATTR_DCB_APP_TRUST_TABLE]) {
> > +             u8 selectors[IEEE_8021QAZ_APP_SEL_MAX + 1] =3D {0};
> > +             struct nlattr *attr;
> > +             int nselectors =3D 0;
> > +             u8 selector;
> > +             int rem, i;
> > +
> > +             if (!ops->dcbnl_setapptrust) {
> > +                     err =3D -EOPNOTSUPP;
> > +                     goto err;
> > +             }
> > +
> > +             nla_for_each_nested(attr, ieee[DCB_ATTR_DCB_APP_TRUST_TAB=
LE],
> > +                                 rem) {
> > +                     if (nla_type(attr) !=3D DCB_ATTR_DCB_APP_TRUST ||
> > +                         nla_len(attr) !=3D 1 ||
> > +                         nselectors >=3D sizeof(selectors)) {
> > +                             err =3D -EINVAL;
> > +                             goto err;
> > +                     }
> > +
> > +                     selector =3D nla_get_u8(attr);
> > +                     switch (selector) {
> > +                     case IEEE_8021QAZ_APP_SEL_ETHERTYPE:
> > +                     case IEEE_8021QAZ_APP_SEL_STREAM:
> > +                     case IEEE_8021QAZ_APP_SEL_DGRAM:
> > +                     case IEEE_8021QAZ_APP_SEL_ANY:
> > +                     case IEEE_8021QAZ_APP_SEL_DSCP:
> > +                     case DCB_APP_SEL_PCP:
>=20
> This assumes that the range of DCB attributes will never overlap with
> the range of IEEE attributes. Wasn't the original reason for introducing
> the DCB nest to not have to make this assumption?
>=20
> I.e. now that we split DCB and IEEE attributes in the APP_TABLE
> attribute, shouldn't it be done here as well?

Hmm, doesn't hurt to do strict checking here as well. We can even get rid
of the DCB_ATTR_DCB_APP_TRUST attr and just pass DCB_ATTR_DCB_APP and
DCB_ATTR_IEEE_APP? Then use the same functions to do the checking.

/ Daniel=