Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jens Axboe <axboe@kernel.dk>
To:     Dawei Li <set_pte_at@outlook.com>
Cc:     hch@lst.de, bvanassche@acm.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
In-Reply-To: <TYCP286MB23238842958D7C083D6B67CECA349@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
References: <TYCP286MB23238842958D7C083D6B67CECA349@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
Subject: Re: [PATCH v3] block: simplify blksize_bits() implementation
Message-Id: <166722282123.67008.17742280061886191847.b4-ty@kernel.dk>
Date:   Mon, 31 Oct 2022 07:27:01 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sun, 30 Oct 2022 13:20:08 +0800, Dawei Li wrote:
> Convert current looping-based implementation into bit operation,
> which can bring improvement for:
> 
> 1) bitops is more efficient for its arch-level optimization.
> 
> 2) Given that blksize_bits() is inline, _if_ @size is compile-time
> constant, it's possible that order_base_2() _may_ make output
> compile-time evaluated, depending on code context and compiler behavior.
> 
> [...]

Applied, thanks!

[1/1] block: simplify blksize_bits() implementation
      commit: adff215830fcf3ef74f2f0d4dd5a47a6927d450b

Best regards,
-- 
Jens Axboe